Quincy Morgan
31eb837596
Fix issue where fixes would not expand when clicking an issue
...
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan
6cb4359d13
Fix issue where entity issues UI could show stale issues
2019-02-15 12:52:09 -05:00
Quincy Morgan
b57e5a75b8
Tweak issue pane icon badge
2019-02-15 12:19:48 -05:00
Quincy Morgan
058a8ee8ff
Merge branch 'master' into validation
2019-02-15 12:03:57 -05:00
Quincy Morgan
0b86be7bcb
Fix bug where highlight would not appear on the first target node when continuing drawing a way
2019-02-15 11:56:31 -05:00
Quincy Morgan
96a1ec92c7
Fix prior commit
...
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan
55c10d2183
Only check to suppress vertex-snap highlighting for nodes (re: #5875 )
2019-02-15 09:09:35 -05:00
Bryan Housel
08d4c3268e
pacify eslint
2019-02-14 17:26:57 -05:00
Bryan Housel
078b19c828
Better handle undo/interruption during behaviorDrawWay
2019-02-14 17:24:09 -05:00
Quincy Morgan
75c7fd770d
Fix entity not found error
2019-02-14 16:21:29 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c86f11c359
Don't suggest extending disconnected line if it is closed
...
Extend at start/end doesn't make sense in this situation
2019-02-14 14:09:44 -05:00
Quincy Morgan
4c9ec3e9e8
Merge branch 'master' into validation
2019-02-14 13:35:14 -05:00
Quincy Morgan
ea3a85e88e
Merge pull request #5888 from openstreetmap/dynamic-line-icon-lines
...
Dynamic line previews in line preset icons
2019-02-14 12:27:02 -05:00
Quincy Morgan
c7e861c0ca
Merge branch 'master' into validation
2019-02-14 12:16:23 -05:00
Quincy Morgan
d0c29f8554
Tweak line icon display
2019-02-14 10:06:50 -05:00
Quincy Morgan
d63430e66a
Line preset icons:
...
- Render vertices with SVG
- Add viewBox to SVG
- Don't reload static parts of the SVG on every update
- Use dimensions that are friendly for low-res displays
- Use nicer-looking stroke dash patterns for ferry routes and railways
2019-02-14 09:40:17 -05:00
Bryan Housel
6525bbf154
Exclude current entity's value from address nearby values lookup
...
re: https://github.com/openstreetmap/iD/issues/5887#issuecomment-463385328
2019-02-14 00:27:32 -05:00
Bryan Housel
9e2acd836c
Use case sensitive combos in address fields
...
(closes #5887 )
This allows users to correct mistyped address parts
2019-02-14 00:20:38 -05:00
Bryan Housel
6a560861b2
Add notification badge to Issue pane icon
2019-02-13 16:56:17 -05:00
Quincy Morgan
ed95fafac9
Add endpoint vertices to the preset icon line
2019-02-13 16:12:29 -05:00
Bryan Housel
5bca360f50
Don't show the entity_issues section if there are no issues
...
(I think it worked this way before)
2019-02-13 13:57:46 -05:00
Bryan Housel
c292a32a66
Better message padding, remove double tooltip
2019-02-13 13:47:00 -05:00
Quincy Morgan
09ec7ea802
Remove redundant line preset icons
...
Fix lint errors
2019-02-13 13:28:34 -05:00
Quincy Morgan
f443144fc6
Update preset icons to use same tag classes as map SVG
2019-02-13 13:11:27 -05:00
Quincy Morgan
041e05ec90
Make the line component of the line preset icons dynamic and match the line styling in the map
2019-02-13 12:01:40 -05:00
Bryan Housel
46ab561724
Merge pull request #5885 from SilentSpike/forced
...
Persist forced visible entities on move/rotate
2019-02-12 21:21:12 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd
Only recenter view if necessary, select after delay, fix maprules type
2019-02-12 17:25:54 -05:00
SilentSpike
a7e0c779b3
Persist forced visible entities on move/rotate
2019-02-12 22:25:47 +00:00
Quincy Morgan
393bb7f5e3
Fix several bugs with arrow key navigation in preset list
2019-02-12 17:17:13 -05:00
Quincy Morgan
5e586419fa
Remove unnecessary float styles and cleanup CSS in the preset list
2019-02-12 16:29:52 -05:00
Bryan Housel
14896b0ce5
Documentation, and move validation type up to top of each file
2019-02-12 16:07:08 -05:00
Quincy Morgan
82f6bd73ae
Account for all tags added upon choosing a preset, not just those in the preset's tags property
2019-02-12 15:16:02 -05:00
Quincy Morgan
2efe2adec9
Restore previous behavior of features hidden and autoHidden but accounting for 0 count features
2019-02-12 15:05:02 -05:00
Quincy Morgan
9007ccb8fd
Disable preset buttons for hidden layers
2019-02-12 14:43:04 -05:00
Bryan Housel
9ebc9a22e9
perf: use Object instead of Array for lookup, cache on osmEntity.key
2019-02-12 14:23:50 -05:00
Bryan Housel
4e6ade08b1
Comment out cache in getIssuesForEntityWithID
...
It seems like entity editor draws before the validator runs so the
rendered list is often one history change behind.
2019-02-12 00:22:24 -05:00
Bryan Housel
6cb1656cac
Animate expand fix menus
2019-02-12 00:00:12 -05:00
Bryan Housel
81bd734849
WIP uiEntityIssues cleanups, simplify
...
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel
f4ccd8a3dc
Update issue text/icon on update selection
2019-02-11 16:22:24 -05:00
Bryan Housel
c083d1d0af
More nitpicky code formatting issues
...
- no multiline var declarations
- avoid lodash unless necessary
- linefeeds for readability
2019-02-11 14:51:21 -05:00
Bryan Housel
9d58c4d0a2
Alphabetic
2019-02-11 14:11:35 -05:00
Bryan Housel
251a83ff7a
Nitpicky code formatting stuff
...
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
Quincy Morgan
19e262643d
Fix issue where "other" ways were not sorted into the "other" category for hiding purposes
2019-02-11 13:38:37 -05:00
Bryan Housel
a6e05b8ac5
Rename for consistency - these are called "annotations" elsewhere
2019-02-11 13:36:02 -05:00
Quincy Morgan
e1da28bcd6
Hide lines that are members of boundary relations when boundaries are hidden ( close #5601 )
2019-02-11 13:22:20 -05:00
Bryan Housel
a5ffec5665
utilHighlightEntities accept an array instead of calling it in a loop
2019-02-11 12:40:23 -05:00
Quincy Morgan
0826050b55
Only zoom to the clicked issue in the entity sidebar if it isn't visible
2019-02-11 12:10:57 -05:00
Quincy Morgan
6a9bb2d138
Add crossing tags when connecting paths crossing roads with the quick fix
2019-02-11 12:03:56 -05:00