Commit Graph

2372 Commits

Author SHA1 Message Date
Martin Raifer
404e08518e use correct margins when limiting photoviewer size, fixes #10558
replaces hardcoded values with dynamically calculated heights/margins.

closes #10563
2024-12-04 13:03:34 +01:00
Deeptanshu Sankhwar
e48aa3c2c4 Ensure correct this context for addMembership function to call the blur method correctly. Fixes #10555 (#10560)
* Pass the  reference explicitly to the  function to ensure the correct context is available.

* refactor: handle blur() in a closure to separate UI logic from addMembership

* spacing

* Fixed typo

---------

Co-authored-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
2024-11-30 22:43:54 -08:00
Minh Nguyễn
6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Kyle Hensel
7afecd39ec minor tweaks to make some tests pass 2024-09-03 19:23:21 +10:00
Martin Raifer
34bb143561 fix undefined translation string, see #10417 2024-08-22 13:54:23 +02:00
Martin Raifer
31bef9f064 fix calculation of non-node feature extents, fixes #10417 2024-08-22 13:52:24 +02:00
Martin Raifer
945fea1dc0 allow to enter strings with quote marks in raw tag editor's text mode (#10371)
and use fully quoted strings for cases which have characters that need to be encoded

old: tag=foo\"bar\" -> new: tag=foo"bar" or tag="foo\"bar\""
old: tag=foo\nbar   -> new: tag="foo\nbar"

falls back to raw tag values if a quoted string cannot be parsed
2024-08-01 15:19:33 +02:00
Martin Raifer
e89121b550 fix vegbilder overlay from being overwritten by panoramax layer 2024-07-31 17:53:33 +02:00
Martin Raifer
9407f309a7 Merge branch 'develop' into panoramax 2024-07-29 15:13:38 +02:00
Martin Raifer
984f25adbb Merge pull request #10046 from laigyu/add-button-to-mapillary
Add a button in the mapillary image photo viewer to "add the current image id as field to feature"
2024-07-16 22:14:21 +02:00
Martin Raifer
d13c202ac0 update "add mapillary tag" button state when tags of the feature change
addresses https://github.com/openstreetmap/iD/pull/10046#pullrequestreview-2176313208
2024-07-16 22:10:08 +02:00
Martin Raifer
42f274f73f move reused regex to exported constant 2024-07-16 17:04:49 +02:00
Sam Ho
43c65bf994 Fix localized field hidden despite nonempty subkeys (Closes#10323) 2024-07-16 12:38:06 +01:00
Martin Raifer
e195947509 Merge branch 'develop' into panoramax 2024-07-12 18:22:53 +02:00
Martin Raifer
7d65b19d6d simplify code 2024-07-12 18:02:14 +02:00
Martin Raifer
1d0f9e6447 lint 2024-07-12 17:53:41 +02:00
Martin Raifer
d9c973b745 disable button when photo is too far from selected feature 2024-07-12 17:49:34 +02:00
Martin Raifer
b604ef8f6f make button work on newly created features; refactor code
code: we should not to not rely on directly manipulating/accessing other components DOM elements
2024-07-12 17:22:03 +02:00
Martin Raifer
6e9d225828 use slightly smaller "plus" icon
(this one is also used in other similar UI locations, e.g. the "add tag" in the raw tags editor, etc.)
2024-07-12 17:20:09 +02:00
mattiapezzotti
a9d8da10d1 prepared for pr 2024-07-12 00:01:05 +02:00
Mattia Pezzotti
20e6473842 Merge branch 'openstreetmap:develop' into panoramax 2024-07-10 10:37:15 +02:00
mattiapezzotti
91281df1df the slider works now. 2024-07-10 10:35:32 +02:00
arch0345
14794ee992 Remove references to ImproveOSM 2024-07-08 17:15:38 -07:00
mattiapezzotti
a6c667d9a9 still working on the slider 2024-07-07 15:19:13 +02:00
mattiapezzotti
fee3d4a3f7 trying to fix the date slider save thing arggg 2024-07-06 14:47:05 +02:00
mattiapezzotti
b1f787c94d fixed typos and syntax errors 2024-07-06 13:38:29 +02:00
mattiapezzotti
fd7534b175 fixed age slider label, added current selected year label and maximum oldest year 2024-06-29 09:11:43 +02:00
mattiapezzotti
bdcebcab33 date slider filter (kinda finished just buggy label) 2024-06-28 17:54:37 +02:00
mattiapezzotti
6b0d6f7017 added photo age filter 2024-06-25 14:58:48 +02:00
Martin Raifer
49492a0e06 keep chosen dropdown item if user clicked on one
fixes a bug where in case multiple items with the same `value` are present in the combobox' dropdown, always the first one is returned in the `accept` event
2024-06-05 19:56:56 +02:00
Martin Raifer
97d1aa5e2d Fix address field overwriting existing data when switching features
fixes #12060

This bug can occur occasionally under the following circumstances:

* map feature 1 is selected
* the cursor is in an address (sub) field
* map feature 2 gets selected directly
* now, in some cases, the contents of the address fields of feature 2 are written into feature 1's tags
2024-06-05 19:55:51 +02:00
Martin Raifer
99d7a85ab4 Merge remote-tracking branch 'k-yle/highway-ladder' into develop 2024-06-05 12:58:56 +02:00
mattiapezzotti
ff2f508575 trying stuff with API (again) (some issues uh) 2024-05-30 14:59:00 +02:00
Martin Raifer
342a03bcfe allow type/id syntax in id hash param, and add support for notes 2024-05-28 20:18:53 +02:00
Kyle Hensel
c7731f5499 support highway=ladder 2024-05-25 16:25:59 +10:00
Pavel Zbytovský
aa53bbf550 Sort "more fields" dropdown items (#10181) 2024-04-25 15:34:39 +02:00
Martin Raifer
5251ee6b65 add new method to reuse localized text span, closes #8994 2024-04-24 17:29:06 +02:00
Martin Raifer
fc4e05601a reduce unnecessary html injection 2024-04-24 13:53:43 +02:00
laigyu
42691dec9d fix onclick handler when closing/reopening notes with comment (#10205) 2024-04-24 13:49:25 +02:00
laigyu
6a6f30b5a8 fix link button when dragging combo field chips #10153 (#10209) 2024-04-24 12:24:52 +02:00
laigyu
904c802587 Merge branch 'openstreetmap:develop' into add-button-to-mapillary 2024-04-17 22:59:27 +08:00
laigyu
b1ff86cd29 tooltip update 2024-04-15 14:54:43 +08:00
Martin Raifer
211b6dde5f upgrade to eslintv9 (config format, lint to updated rules) 2024-04-12 18:44:04 +02:00
laigyu
2325de4662 update butotn logic 2024-04-12 18:37:26 +08:00
laigyu
6b8b41c2ff tooltip style change 2024-04-08 18:22:58 +08:00
laigyu
d448b586ed revert error handler 2024-04-07 23:19:41 +08:00
laigyu
94e32a85b0 revert field button 2024-04-07 22:04:22 +08:00
laigyu
8bb1d0dfa9 Merge remote-tracking branch 'upstream/develop' into add-button-to-mapillary 2024-04-05 13:17:59 +08:00
Hirako
85278c35e4 Field: fix wikiURL by URL encoding it - and slight refactors (#10165)
* Field: fix wikiURL by URL encoding it - and slight refactors

* Field: fix wikiURL only encodeURIComponent instead of redundant full URL

* Field: refactors function to generate wikiURL, ensures anchor part is also URI encoded, ensures the anchor ref is not encoded, adds unit tests

* Field: refactors wikipedia URI encoding of the anchor logic, removes legacy anchorencode effort via try-catch that replaced percentage character with dots, adds unit further  tests, reduces exessive inlining
2024-03-21 00:42:08 -07:00
Asif Sheriff
1683313621 preserve rows with empty tag values in raw tag editor (#10151) 2024-03-15 01:13:07 +01:00