CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,620 Commits 2 Branches 0 Tags
35b3102006f3fe931589c8221faa652e5aadd439
Commit Graph

91 Commits

Author SHA1 Message Date
Quincy Morgan
f5a8615f5c Fix bug where iD could add empty source tag to changeset (close #6405) 2019-05-22 10:47:23 -04:00
Quincy Morgan
961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00
Quincy Morgan
5160754dcc Display issues for disabled rules in the commit UI 
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
 2019-05-07 13:07:31 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
239c622044 Don't tag redundant ignored warnings counts on changesets 2019-04-26 13:02:13 -07:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
f2ca5316b0 Add total ignored warnings count to changeset tags (re: #6123) 2019-04-25 09:34:07 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
b5c5a00abc Get rid of the many_deletions validation 🔪 
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
 2019-04-19 13:33:29 -04:00
Bryan Housel
ae06e28f9b Try to avoid style recalculation when typing on the comment box 
I think this doesn't completely work.. It reduces the amount
of unnecessary DOM changes, but there are still some more.
 2019-04-19 10:02:25 -04:00
Bryan Housel
35049ab40a Replace getErrors/getWarnings with getIssues/getIssuesBySeverity 
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
 2019-04-11 14:48:23 -04:00
Quincy Morgan
5e4e2ff7ee Fix an issue where stale warning counts would still appear in changeset tags if they had all been resolved (re: #6123) 2019-04-07 14:29:05 -07:00
Bryan Housel
cda8f657ac Swap fast-deep-equal for lodash isEqual 
(re: #6087)
 2019-03-29 22:17:29 -04:00
Quincy Morgan
f4367f96c0 Add ignored warning counts to the changeset tags (close #6123) 2019-03-28 09:46:59 -04:00
Bryan Housel
31ae7fc800 Make sure hashtag checkers work with arrays and not nulls 
(closes #6116)

This is breakage related to #6087 in replacing _.uniqBy with a Set
The lodash functions are much more tolerant of nulls and dodgy inputs.
 2019-03-27 09:20:19 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union 
(re: 6087)
 2019-03-27 01:22:11 -04:00
Bryan Housel
0e90167513 Remove lodash clone 
(re: #6087)
 2019-03-22 23:18:25 -04:00
Quincy Morgan
7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
SilentSpike
9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
Quincy Morgan
46f3cea33a Reorganize validation code 
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
 2019-02-01 11:20:51 -05:00
Quincy Morgan
19a2a60bf4 Add tooltip to disabled upload button to specify what is blocking the upload 2019-01-30 13:20:56 -05:00
Bryan Housel
55a92ca79d Add closed:note changeset tag for closed OSM notes 2019-01-11 10:14:55 -05:00
Bryan Housel
5ebe0976fe Add closed:keepright changeset tag for closed issues 
The issues are written as `schema:error_id` and semicolon delimited
e.g.  `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
 2019-01-10 23:27:55 -05:00
Max Grossman
1471b55122 lint! 
ref #5614
 2018-12-18 12:02:26 -05:00
Max Grossman
ae9d43b0ac remove double class 
ref #5614
 2018-12-18 11:16:37 -05:00
Max Grossman
18c021b5d5 add css 
ref #5614
 2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da add close button w/out css 
ref #5614
 2018-12-18 11:00:40 -05:00
Bryan Housel
577e0c6503 Don't add "None" to imagery_used tag when other imagery was used 
(closes #5565)
 2018-12-11 16:37:52 -05:00
Bryan Housel
fa6e195c2d Add user info, require authentication to edit a note 2018-07-17 00:55:43 -04:00
Thomas Hervey
61ae541cfc updated: notes save buttons 2018-07-03 10:57:53 -04:00
Bryan Housel
644985c8e3 Don't write 'undefined' to storage when deleting the changeset source 
(closes #5012)

Also includes some code to ignore/remove any 'undefined' source values which
happen to be stored in localStorage. Because the saved source/comment/hashtags
expire after 2 days, this code can go away in iD v2.9
 2018-05-13 12:57:49 -04:00
Bryan Housel
d8f6fafe74 Don't add empty source tag on a changeset 
(closes #4993)
 2018-04-18 17:33:56 -04:00
Bryan Housel
61c7f64077 Remember changeset source, make it settable via url param 
(closes #4899)
 2018-03-16 09:20:32 -04:00
Bryan Housel
a63c4a72fe Improvements to save flow 
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056)
- Block reentry of save, and dont keep focus on save button (closes #4641)
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
 2018-01-05 15:11:44 -05:00
Bryan Housel
8914d1ce36 Variable cleanups and formatting 2018-01-04 16:13:13 -05:00
Bryan Housel
34cdab9197 uiDisclosure now handles expanded state in localStorage 
Now all the places that use a uiDisclosure won't have to do that
 2017-11-27 17:13:57 -05:00
Bryan Housel
35a9f77a63 Preserve selected entity when cancelling save mode 
(closes #4407)
 2017-11-12 12:34:04 -05:00
Colin Kennedy
c81cf703f2 Fix #4443 Imagery only updated on first save 2017-10-15 15:45:53 -04:00
Seth Fitzsimmons
0b770450cd Allow -,_,+,& as hashtag characters 2017-10-09 14:56:49 -04:00
Bryan Housel
8f82caf554 Adjust hashtagRegex: allow '_', change * (0 or more) to + (1 or more) 2017-10-09 14:39:02 -04:00
Seth Fitzsimmons
37cf22e1a2 Treat punctuation as hashtag delimiters 
Unicode ranges for punctuation are simpler than creating a Unicode-aware
word class, so delimit on non-words.

Fixes #4398
 2017-10-09 10:14:25 -04:00
Bryan Housel
3d13620705 Convert lodah-es and d3 to named imports for ui 2017-09-26 11:22:43 -04:00
Bryan Housel
595053621b Wrap request review UI in div and label 
(closes #4354)
 2017-09-18 14:10:14 -04:00
Bryan Housel
0f153d7d55 Ignore URLish fragments when detecting hashtags in changeset comment 
(closes #4289)
 2017-09-11 12:11:22 -04:00
Bryan Housel
ba8a1e6bc6 Several changes to avoid storing stale hashtags 
(closes #4304)

- remove context.storage hashtags whenever hashtags are detected in comment.
- when changing the comment, override hashtags with any found in comment.
 2017-09-11 11:50:59 -04:00
Bryan Housel
9719a31c79 Match less punctuation in hashtags 
(closes #4303)
 2017-09-11 09:55:29 -04:00
Bryan Housel
f034092b44 Write post-save count, not pre-save count to the changesets_count tag 
(closes #4283)
 2017-08-26 15:46:56 -04:00
Bryan Housel
121a1fa629 Avoid making an empty hashtags tag 2017-08-17 12:06:16 -04:00
Bryan Housel
2bf7a5e08b Write changeset tags for new mappers to indicate walkthrough progress 
These tags all start with `ideditor:`
(closes #3968)

```
ideditor:walkthrough_completed=yes
ideditor:walkthrough_progress=welcome;navigation;point;area;line;building;startEditing
ideditor:walkthrough_started=yes
```
 2017-08-16 20:10:01 -04:00