CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 17:52:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,736 Commits 2 Branches 0 Tags
39b3f1df6830a69419b05eab829f8c656a623b90
Commit Graph

1821 Commits

Author SHA1 Message Date
Bryan Housel
39b3f1df68 Avoid creating comboboxes 
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
 2018-12-11 16:07:00 -05:00
Bryan Housel
222b3f1b04 Don't render contents of collapsed sections 
(speeds things up if raw tag editor is hidden)
 2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel
ff646fa2c8 Dispatch a 'cancel' event if the user hits escape 2018-12-11 00:09:55 -05:00
Bryan Housel
6cf1d63b48 Make sure dropdown doesn't remain visible 
(closes #5575)

Also improves keyboard navigation, and adds some scrollintoview
workarounds to make sure that the selected option is visible
while also not causing the whole page to move.
 2018-12-10 23:54:06 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js 
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
 2018-12-10 12:38:21 -05:00
Bryan Housel
54a4546306 WIP to avoid _wrapper state variable, move towards combobox singleton 2018-12-10 12:15:50 -05:00
Bryan Housel
5c9f9ac012 Always show save count 0.. makes responsivness easier 
(closes #5576)
 2018-12-09 23:31:52 -05:00
Quincy Morgan
4285f2f5c0 Added "moreFields" property to the field schema 
The "Add field" dropdown can now be used to add preset-specific fields in addition to universal fields
 2018-12-09 13:51:57 -08:00
Bryan Housel
cbcafaee15 Make sure sidebar is expanded before entering walkthrough or saving 
(closes #5574)
 2018-12-08 10:03:43 -05:00
Bryan Housel
7fd06f69b8 Use .select instead of .selectAll to propagate the bound data 
(closes #5573)
 2018-12-07 17:46:14 -05:00
Bryan Housel
d574bfcd77 Disable autocomplete on the localized field 
(closes #5558)
 2018-12-07 17:19:02 -05:00
Bryan Housel
247900f727 Change several of the event things, remove numeric index 
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
 2018-12-07 16:54:32 -05:00
Bryan Housel
77a9dde6f7 Make sure combobox can always receive arrow and esc events 2018-12-05 15:59:06 -05:00
Bryan Housel
b494684e4f v2.12.1 2018-12-05 01:58:18 -05:00
Bryan Housel
bee01d8497 Destroy all old background layer tooltips before making new ones 
(closes #5551)
 2018-12-05 00:35:45 -05:00
Quincy Morgan
b366ace770 Switches from == to === in prior commit 2018-12-04 17:33:39 -08:00
Quincy Morgan
3cb2b8c901 Fixes an issue where the walkthrough would not display and cause an error 2018-12-04 17:29:19 -08:00
Bryan Housel
5451d0f3fe v2.12.0 2018-12-03 22:14:05 -05:00
Bryan Housel
8b2e5c98bd Fix tests - test for _entity before using it 2018-12-02 01:46:35 -05:00
Bryan Housel
0a286bbd9d Lock name field when there is a wikidata tag 
(re: #5515)
 2018-12-02 00:14:51 -05:00
Bryan Housel
8456b387e0 pacify eslint 2018-12-01 22:44:02 -05:00
Bryan Housel
5a6671d728 Cache wikidata results 
Because wikidata field potentially shown on hover now
and the results of this lookup will never change
 2018-12-01 22:06:17 -05:00
Bryan Housel
f559fc57bb Silly code formatting stuff, remove unused .entity() accessor 
- prefix state variables with a _
- var on each line
 2018-12-01 21:51:08 -05:00
Quincy Morgan
55c47021fa Fixes Wikidata field lint errors 2018-12-01 18:14:51 -08:00
Quincy Morgan
afcc474d3c Wikidata entity labels and descriptions are now fetched and displayed in the field, if present 2018-12-01 17:39:16 -08:00
Quincy Morgan
a28147aea2 Updates Wikidata field for the latest field flexbox changes 
Adds an Identifier label to the Wikidata QID input
 2018-12-01 13:16:41 -08:00
Quincy Morgan
3643877be6 Merge branch 'master' into wikidata-field 2018-12-01 11:57:09 -08:00
Quincy Morgan
b0dccc81de Condenses CSS for access, cycleway, and structure field lists 2018-12-01 11:55:21 -08:00
Bryan Housel
4f8f45ec52 Fix issues with slow scrolling and improper panning on windows 
(closes #5512)
 2018-11-30 22:57:30 -05:00
Bryan Housel
c7fc3ea062 Reset the scroll to the top of the inspector when redrawing it 2018-11-30 14:21:14 -05:00
Bryan Housel
d177ab7fcf Shrink the directional way markers slightly 
(closes #5533)
 2018-11-30 01:56:33 -05:00
Bryan Housel
8b0e729b9c Merge pull request #5502 from jguthrie100/redraw_restrictions_on_sidebar_drag 
Redraw restrictions panel when dragging sidebar
 2018-11-30 01:30:03 -05:00
Bryan Housel
50d204866b Flexbox the raw member, membership controls, finish tag editor 2018-11-29 22:31:58 -05:00
Bryan Housel
d0612ba519 Fix css for address and wikipedia fields, fix hover styles 2018-11-28 23:20:52 -05:00
Bryan Housel
958d7fac4f wip changing all fields to use flexbox everywhere 2018-11-28 18:15:38 -05:00
Bryan Housel
0b98811377 Avoid multiline variable declaration 2018-11-27 11:22:13 -05:00
Bryan Housel
4c2f14230b Merge pull request #5529 from huonw/arrows-for-cliffs 
Add one-sided triangular markers to ways with sides (e.g. natural=cliff).
 2018-11-27 11:15:48 -05:00
Bryan Housel
4533603a88 preset-input-wrap -> form-field-input-wrap 
This better describes what it does.
Also, took this opportunity to update a bunch of the uifield code
(no multi line variable declarations, prefix state variables with _,
eliminate unnecessray lodash, etc)
 2018-11-27 10:54:03 -05:00
Huon Wilson
dd0be84da4 Add one-sided triangular markers to ways with sides (e.g. natural=cliff). 
This generalizes the oneway arrow logic for adding SVG markers along a
line. Using that functionality, certain tags get arrows on their
right-hand side, indicating which side is "inside", e.g. the
right-side of a cliff is the lower side.

The list of tags considered to be sided (unless there's a
two_sided=yes tag) is:

- natural=cliff
- natural=coastline
- barrier=retaining_wall
- barrier=kerb
- barrier=guard_rail
- barrier=city_wall
- man_made=embankment

The triangles attempt to be reminiscent of the triangles used for
rendering cliffs on OSM (and elsewhere). The different tags get
different renderings (e.g. colors that match the main way, and
different spacings). In addition, natural=coastline is special-cased
to have blue markers (despite having a green way), to emphasise that
the "inside" of a coastline is the water.

Fixes https://github.com/openstreetmap/iD/issues/1475.
 2018-11-28 01:45:50 +11:00
Bryan Housel
986b663c9e Get rid of extra form-label-button-wrap div 
Buttons can now be directly appended to the form-field-label flex container
 2018-11-27 09:14:11 -05:00
Bryan Housel
d2687d9068 pacify eslint 2018-11-26 22:13:38 -05:00
Bryan Housel
822917466c Display name suggestion presets on 2 lines 
(closes #5514)
 2018-11-26 21:55:13 -05:00
Bryan Housel
7170e93b39 Adjust tooltip 2018-11-26 17:35:38 -05:00
Bryan Housel
df91eb2959 Cleanup style, make sure multilingual fields always render 2018-11-26 17:13:55 -05:00
Bryan Housel
9341e477a6 Merge remote-tracking branch 'origin/master' into brand-name-protection 2018-11-26 15:27:56 -05:00
Bryan Housel
f6f146f79b Lock down some fields when a brand preset has been chosen 2018-11-26 15:13:40 -05:00
Bryan Housel
c1b19e7c9e Generate unique _id for each tooltip 
This lets allows multiple tooltips around nested elements.
The previous code did a bunch of  .selectAll('.tooltip') that would
break if it matched multiple tooltips.
 2018-11-26 14:14:19 -05:00
Bryan Housel
4972fed136 Don't show the combobox control for a readonly input field 2018-11-26 11:18:04 -05:00