Commit Graph

726 Commits

Author SHA1 Message Date
Bryan Housel
f74d21557c Force redraws after moving a note or cancelling a note
similar to 95ea0dbbc, there is no history change event to force a redraw
2018-07-24 19:34:01 -04:00
Bryan Housel
b95aa08900 Add cancel button, simplify button code 2018-07-24 16:22:21 -04:00
Bryan Housel
0552a90a9f Remove category field - it's not an osm tag 2018-07-24 14:58:04 -04:00
Bryan Housel
640596340e Improve the add-note icon in help, minor changes to help text 2018-07-24 12:40:16 -04:00
Bryan Housel
46dc44b35b Make the mode buttons dynamic
- show/hide the note button when the notes layer is enabled/disabled
- enable/disable the note button based on notesEditable
2018-07-23 22:21:47 -04:00
Thomas Hervey
7312d7024b added notes to help ui 2018-07-23 18:26:43 -04:00
Thomas Hervey
e1cb25d824 merge from 'master' 2018-07-23 18:24:02 -04:00
Thomas Hervey
e23ef4ba4a redraw on note drag. TODO: change dispatch call 2018-07-23 15:09:25 -04:00
Thomas Hervey
4038c8200e added note section to help docs 2018-07-22 00:05:15 -04:00
Thomas Hervey
00bb733736 changed note annotation icons 2018-07-21 22:49:12 -04:00
Bryan Housel
8811933009 Split up loadTiles and loadNotes code
Code is similar but different enough that I'd rather have 2 separate
functions rather than a single function with a bunch of ifs
2018-07-21 22:31:04 -04:00
Thomas Hervey
c3fe1fedd9 updated categories, added category to note service 2018-07-21 21:09:17 -04:00
Thomas Hervey
658721a150 WIP: added note category, TODO: update input 2018-07-21 19:36:13 -04:00
Thomas Hervey
373353f40d added breathe behavior & cleaned hover/select styling on notes 2018-07-21 15:54:47 -04:00
Thomas Hervey
e8fc9f2eda simplify save buttons 2018-07-21 12:31:22 -04:00
Thomas Hervey
06a410107b cleaned up merge relics and comments 2018-07-20 23:31:49 -04:00
Thomas Hervey
1d61355d08 added service for new note 2018-07-20 22:19:57 -04:00
Thomas Hervey
bf9b19359a WIP drag note 2018-07-20 21:41:44 -04:00
Thomas Hervey
2cde7843f2 merged branch 'master' into drag-note 2018-07-20 14:30:21 -04:00
Thomas Hervey
438756103d update checking if note is new 2018-07-18 17:11:17 -04:00
Bryan Housel
1b7493081e Show linkified text in notes, hide scrollbars when hovering
(closes #5151)
2018-07-18 16:16:34 -04:00
Thomas Hervey
b017616993 added new note icon and completed sidebar 2018-07-18 09:38:59 -04:00
Bryan Housel
ae4c742851 Merge pull request #5155 from openstreetmap/fix-note-date
fix browser-specific Date() issues in notes
2018-07-17 22:43:31 -04:00
Bryan Housel
7737c571aa Shrink the photo viewer if the map has been resized to be smaller 2018-07-17 17:47:05 -04:00
Bryan Housel
e221dcae58 Dispatch new dimensions with photoview resize, resize all layers
-Adds ability to resize OpenStreetCam and Bing Streetside layers
-Also slightly increases the width of the resize handles
-Also limits max resize so it won't go larger than the map
2018-07-17 17:06:59 -04:00
Thomas Hervey
b0ba681538 fix browser-specific Date() issues in notes 2018-07-17 16:07:47 -04:00
Thomas Hervey
ea2fffbd49 fix toggling new note button 2018-07-17 14:25:06 -04:00
Bryan Housel
b9a6996048 Merge branch 'feat-photoviewer-resize' of https://github.com/mapillary/iD into mapillary-feat-photoviewer-resize 2018-07-17 12:38:52 -04:00
Thomas Hervey
af2b67663b added new-note button 2018-07-17 11:35:27 -04:00
Bryan Housel
fa6e195c2d Add user info, require authentication to edit a note 2018-07-17 00:55:43 -04:00
Bryan Housel
73d0f30453 Merge branch 'notes' 2018-07-16 16:59:35 -04:00
Bryan Housel
694cc60893 Add thread dots to note header icon, disable comments on closed nodes 2018-07-16 16:53:45 -04:00
Bryan Housel
70f87632c7 Cleaner note icon rendering
Before: We drew 2 fontawesome comment icons, on on top of the other
After: Moved icon into iD spritesheet and gave it an actual `stroke` property that can be styled
2018-07-16 13:18:38 -04:00
Thomas Hervey
7fb42ac9d6 added note reporting and margin to save buttons 2018-07-13 17:09:51 -04:00
Bryan Housel
1a106f5253 Make uiViewOnOSM work for notes too, add it to note_editor footer 2018-07-13 15:55:58 -04:00
Matias Volpe
0ea0749135 Add minimum resize height/width 2018-07-13 09:16:36 -03:00
Bryan Housel
8a1079c3c6 Update notes on status change 2018-07-13 00:15:30 -04:00
Bryan Housel
57da729837 Implement note save button code 2018-07-12 23:50:29 -04:00
Bryan Housel
645cc790a3 Add docs about OSM API, finish implementing postNoteUpdate
`postNoteUpdate` can hangle status changes and comment additions
(I named it that to be like `putChangeset`)

Also renamed `user` to `loadUser` to be consistent with other calls
2018-07-12 23:46:07 -04:00
Bryan Housel
19560ebc90 Properly save and restore caches when entering/leaving the walkthrough 2018-07-12 15:39:04 -04:00
Matias Volpe
836517a9fe Add ability to resize to PhotoViewer 2018-07-12 09:41:10 -03:00
Bryan Housel
fe7086f753 Add header close 'X' button, add grey hover styling 2018-07-12 02:51:49 -04:00
Bryan Housel
5e5601f555 Store the unsaved comment in the note itself 2018-07-12 02:09:24 -04:00
Bryan Housel
91add0c33e WIP on buttons, simplify, remove some event dispatch
- I made the buttons work like GitHub comment-on-issue buttons
before typing:  "Close Note" / "Comment" (disabled)
after typing:   "Close and Comment" / "Comment" (enabled)

- I removed a bunch of the event dispatches.  These are useful for sending
events to listeners/observers outside of the module.  In this case I think
we can handle most of the things from within the uiNoteEditor.  We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.

TODO - make the buttons work / check the OSM API stuff.
2018-07-11 23:10:01 -04:00
Bryan Housel
3454753bf6 Drop more/less toggle and just use a scrollbar for long comments 2018-07-11 16:00:54 -04:00
Bryan Housel
e9e2f9ba8f Style note header 2018-07-11 15:41:43 -04:00
Bryan Housel
0d7c292c23 Refactor out uiNoteHeader and uiNoteComments into separate modules
uiNoteEditor was getting big!
2018-07-10 21:45:02 -04:00
Thomas Hervey
eafae6c58c WIP: update service calls; todo: note update event handling 2018-07-10 13:50:36 -04:00
Bryan Housel
9c275d58b5 Comment out .mvt data layer for now 2018-07-09 14:36:16 -04:00
Bryan Housel
69e83099a5 Fix icon names in map_data panel 2018-07-09 14:31:20 -04:00