Commit Graph

3152 Commits

Author SHA1 Message Date
Bryan Housel fadd8e2e8a Switch KeepRight markers to use touch targets
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel cd9203975d Use touch targets for notes, fix a few bugs with note dragging
(closes #5213)
2019-01-04 15:48:39 -05:00
Bryan Housel d0343c9fa7 Reintroduce some error localization, fix some nagging parse issues 2019-01-03 18:16:28 -05:00
Bryan Housel 35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel 46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel 9e6497b549 Update or remove the error after POSTing changes to server 2019-01-03 01:39:40 -05:00
Bryan Housel 69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel 4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel 9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel 2ec02f369f Simplify regex matching - goal is to have fewer, simpler rules 2019-01-02 11:46:13 -05:00
Bryan Housel d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel 192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel 4f0a608439 Merge pull request #5637 from openstreetmap/5618
fix autocomplete combobox bug
2018-12-26 15:15:29 -05:00
Bryan Housel bc72c387e4 Merge pull request #5647 from nyurik/osm_wikibase
OSM Multilingual data directly from wiki (wikibase data items)
2018-12-26 14:48:39 -05:00
Yuri Astrakhan 9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Tobias 5009edee4b Move variable to the top of the file and reuse
As suggested in https://github.com/openstreetmap/iD/pull/5650#issuecomment-449589375
2018-12-23 07:38:00 +01:00
Yuri Astrakhan 8b931f3e6c Use new message to encourage editing and translation 2018-12-22 15:03:22 -05:00
Yuri Astrakhan aa78cd10a3 Data items - remove hardcoded locale IDs
Locale IDs are now fetched together with the other data
when the language code is provided.
2018-12-22 14:58:15 -05:00
Tobias Jordans c97b659a34 Allow locale and language being set via URL param
With the hash-url `locale=en-US` or `locale=de-DE` one can force a locale and language regardless of the given language from the osm-website-settings.
2018-12-22 19:10:50 +01:00
Bryan Housel 3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel 22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Quincy Morgan 70d5529a58 Added initial implementation of quick fix for connecting crossing features (still has some bugs) 2018-12-21 17:39:20 -05:00
Quincy Morgan 90bc7bf6a5 Changed crossing ways issue severity from error to warning 2018-12-21 17:21:29 -05:00
Andrew Wong 958d918bbe Merge pull request #5639 from wonga00/more_tests
Added more validation tests
2018-12-21 16:49:11 -05:00
Quincy Morgan 67e585e4c5 Crossing ways issues now use the relevant parent relation when the offending way itself does not have relevant tags 2018-12-21 16:10:48 -05:00
Quincy Morgan c593bb3475 The issue id now accounts for all entities 2018-12-21 14:51:18 -05:00
Quincy Morgan d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Xiaoming Gao 5f333267f4 Merge pull request #5645 from gaoxm/improveCrossWayCheck
Improve cross way check
2018-12-21 14:16:47 -05:00
Quincy Morgan dc3a42f33d Fixed validation-related linting errors 2018-12-21 14:08:35 -05:00
Xiaoming Gao dee005e9aa Improve cross way check
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
2018-12-21 14:00:31 -05:00
Quincy Morgan 627b4ee732 Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix 2018-12-21 14:00:08 -05:00
Quincy Morgan c9350c632e Add issue fixes UI
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Bryan Housel f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Andrew Wong 67bab7aecf don't import all of d3 2018-12-20 16:31:32 -05:00
Bryan Housel 4eb0e4b3a4 Remove more duplicate strings 2018-12-20 16:09:18 -05:00
Andrew Wong 5971bbebb7 Added more validation tests 2018-12-20 15:39:26 -05:00
Bryan Housel 177537f0ce Move coincident markers away from related geometry and from each other 2018-12-20 15:23:53 -05:00
Quincy Morgan 026597017a Update styling in the entity issues list 2018-12-20 14:49:35 -05:00
Bryan Housel 7f669d292f Simplify KeepRight tile fetching code 2018-12-20 14:40:14 -05:00
Quincy Morgan d58867df7c Add entity display label util function
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan 373be68294 Merge branch 'master' into validation 2018-12-20 13:58:09 -05:00
Quincy Morgan 7c192a2e36 Fixed bug where the entity ID could not be found for the field 2018-12-20 12:25:35 -05:00
Quincy Morgan d7ef2de073 Re-organizes issue messages and tooltips 2018-12-20 12:16:54 -05:00
Quincy Morgan f0fa59874f Merge branch 'master' into validation 2018-12-20 10:31:25 -05:00
Quincy Morgan 97c2361f43 Changed initial sidebar screen for highway intersection vertices from preset list to editor 2018-12-20 10:17:16 -05:00
Bryan Housel 62547e3459 Merge pull request #5638 from openstreetmap/5612
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman 9a5a77f96c remove unneccessary space
ref #5612
2018-12-20 09:24:46 -05:00