Commit Graph

2959 Commits

Author SHA1 Message Date
Quincy Morgan 3bf3ecf560 Populate the default preset list with the presets parameter values, if any (close #6703) 2019-07-31 16:18:10 -04:00
Quincy Morgan b0c7500e33 Fix deletion and update issues with localized name field (close #6491) 2019-07-30 13:05:19 -04:00
Quincy Morgan d5da5a601c Fix error upon revalidating after changing unsquare building threshold (close #6690) 2019-07-26 14:11:15 -04:00
Quincy Morgan b730e903a4 v2.15.4 2019-07-26 12:28:41 -04:00
Quincy Morgan eb49a367b4 Don't reuse changeset comment, sources, and hashtags from prior uploads (close #6642, re: #6279) 2019-07-22 16:12:20 -04:00
Quincy Morgan 1bce70e3f5 Update directional arrow styling when switching between directional presets (close #6032) 2019-07-17 13:55:56 -04:00
Quincy Morgan c0b79a614d Default speed limits to mph in Puerto Rico (close #6626) 2019-07-16 10:33:07 -04:00
Quincy Morgan 5984f6b118 Don't flag google books as an incompatible data source (close #6556) 2019-07-09 09:58:39 -04:00
Quincy Morgan 83c5fa3215 Fix issue where background panel wouldn't update (close #6627) 2019-07-08 16:48:10 -04:00
Quincy Morgan 8003e7b3d3 Allow the layer and level tag to differentiate very close points (close #6612) 2019-07-05 10:17:15 -04:00
Quincy Morgan 3d9bcc8234 Add directional arrows to waterway=weir rendered as lines (close #6615) 2019-07-03 15:46:23 -04:00
Bryan Housel 919f37a67c v2.15.3 2019-06-30 10:08:43 -04:00
Bryan Housel ca2c6b1098 Allow for some tags (takeaway) to be kept thru a NSI upgrade
(closes #6530, closes #6581)
2019-06-30 01:42:43 -04:00
Bryan Housel 2307125842 Remove existing NSI keys before upgrading to a NSI preset
(closes #6575)
2019-06-30 01:24:42 -04:00
Bryan Housel 618587aa48 Don't allow layer changes while drawing
(closes #6584)
2019-06-30 01:08:25 -04:00
Quincy Morgan 2ad2bac931 Limit addable presets via comma-separated IDs in the presets URL parameter (close #6553) 2019-06-24 12:38:32 -04:00
Bryan Housel 16d77a840c v2.15.2 2019-06-17 15:01:19 -04:00
Quincy Morgan 59c81d4fc2 Remove issue "autofix" buttons 2019-06-17 10:21:41 -04:00
Quincy Morgan b10ae96d62 Don't suggest adding nonsquare=yes to physically unsquare buildings (close #6332) 2019-06-16 18:47:32 -04:00
Quincy Morgan 67f7995559 Avoid stale "connect endpoints" fix for "tags imply area" that could cause invalid areas (close #6525)
Lower match score for man_made/bridge preset
2019-06-12 09:31:06 -04:00
Quincy Morgan aa7bf74a7f Fix issue with deleting a member from a relation with a duplicate entity but different roles (close #6504) 2019-06-11 09:08:44 -04:00
Quincy Morgan 2eff493d37 Add outdated tags validation issue subtype for noncanonical brands
Add specific warning message for noncanonical brands (close #6443)
Don't allow autofixing noncanonical brand issues
2019-06-10 11:39:42 -04:00
SilentSpike f402748706 Fix email validation for unicode characters
Also fix format validation for lists with excess whitespace (6494#issuecomment-499620002).
2019-06-10 11:02:56 -04:00
Quincy Morgan 1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
SilentSpike 0b8ddd9240 Fix email and website validation for empty values 2019-06-06 13:55:53 -04:00
SilentSpike f02238ce23 Fix varied validation messages and redeclaration
I've hijacked the data property for the purposes of changing the message
based on whether multiple values in a list are erroneous
2019-06-06 13:55:53 -04:00
SilentSpike 591e41f5ec Fix email and website validation for list values
Also improved the UI message to be more clear for websites and simplify
"is tagged with" to "has" which works in context.
2019-06-06 13:55:53 -04:00
SilentSpike 770cffe7de Add email and website format validation
Simple validation following the HTML5 standard for emails as we don't
expect POIs to have convoluted email addresses. Only checks the
`website` and `email` tags as these are what iD currently supports with
fields.
2019-06-06 13:55:53 -04:00
Quincy Morgan d42cb7b790 Fix issue where iD could crash upon save if user had edits stored before iD 2.15 (close #6496) 2019-06-06 09:20:57 -04:00
Quincy Morgan 14c0809426 Fix issue where cuisine -> diet upgrades could overwrite existing values (close #6462) 2019-05-31 08:25:29 -04:00
Bryan Housel 7074d48f2f v2.15.1 2019-05-24 22:10:21 -04:00
Bryan Housel 44349c8015 Swap wikidata/wikipedia for brand: tags if possible
(closes #6416)

This also ignores any features with an office tag, to avoid
changing a wikipedia/wikidata tag on a corporate office.
2019-05-24 14:24:10 -04:00
Bryan Housel b4ebaaa01e Fix raw tag editor styling for custom data editor
(closes #6427)
2019-05-24 11:32:14 -04:00
Quincy Morgan c95cead06d Fix bug where issues would not be properly centered if the map was not already at z19 (close #6384) 2019-05-24 10:28:59 -04:00
Bryan Housel 2a08868c14 Fix vector tile layers
(closes #6426)

After switching from XHR->fetch, we now parse the response separately,
so the `vtToGeoJSON` function already has an ArrayBuffer to work with.
2019-05-24 10:15:35 -04:00
Bryan Housel 0ded25885d Back off if the toLoad queue is filling up..
(re #6417)
2019-05-24 09:44:35 -04:00
Quincy Morgan 43cd46f046 Prevent Chrome autofill of recent values in the Allowed Access inputs (close #6414) 2019-05-24 09:30:06 -04:00
Bryan Housel a5a7e0aaf1 Switch Bing Imagery Key
(re: #5833)
2019-05-24 01:32:02 -04:00
Bryan Housel 77f89d4170 Merge branch 'validation_fix_issues' 2019-05-23 19:41:13 -04:00
Bryan Housel 149a0b43b3 Use latest entity at time of fix for private_data validation too
(re: #6407)
2019-05-23 19:40:10 -04:00
Bryan Housel 5440467db0 Undo 5b8db55b4 and instead get latest entity at time of fix
Per conversation w @quincylvania we need the issue ids to remain
stable so that users can ignore them.

So instead of forcing a refresh by changing the `id` we will grab current
versions of entities at fix time so that tags aren't replaced wrongly.
2019-05-23 18:52:32 -04:00
Quincy Morgan ca19d50558 Fix issue where duplicate expanded community entries could appear (close #6422) 2019-05-23 17:02:15 -04:00
Quincy Morgan 0dfd0612b1 For ice rinks, prefer the "sport" values "ice_hockey" and "ice_skating" instead of "hockey" and "skating" since that latter are ambiguous
Don't remove other values when upgrading a tag value within a semicolon-delimited list
2019-05-23 15:39:15 -04:00
Quincy Morgan 8e66b74bcc Make unsquare threshold field wider to account for stepper control in Firefox (close #6418) 2019-05-23 10:01:30 -04:00
Bryan Housel 5b8db55b47 Need issue id to actually change for d3 to replace it
(re: #6407)

What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.

Need to review all the validators to see if others have this problem too.
2019-05-22 23:47:53 -04:00
Quincy Morgan 28db4df86b Flag detached points that are very close together (close #6394)
Fix lint error
2019-05-22 15:50:20 -04:00
Quincy Morgan 030b4b3efa Flag almost junctions between highways and themselves (close #6373) 2019-05-22 14:12:23 -04:00
Quincy Morgan 35b3102006 Add Disable All and Enable All buttons for the Map Features list (close #5234) 2019-05-22 11:56:04 -04:00
Quincy Morgan 6260cdbb8f Fix several lint warnings 2019-05-22 10:48:39 -04:00
Quincy Morgan f5a8615f5c Fix bug where iD could add empty source tag to changeset (close #6405) 2019-05-22 10:47:23 -04:00