Commit Graph

1435 Commits

Author SHA1 Message Date
Quincy Morgan 3ca01d3690 Generalize wikidata field type
Add Species Wikidata field to tree, orchard, and animal enclosure presets (close #6652)
2019-07-31 16:59:44 -04:00
Quincy Morgan b0c7500e33 Fix deletion and update issues with localized name field (close #6491) 2019-07-30 13:05:19 -04:00
Quincy Morgan eb49a367b4 Don't reuse changeset comment, sources, and hashtags from prior uploads (close #6642, re: #6279) 2019-07-22 16:12:20 -04:00
Quincy Morgan c0b79a614d Default speed limits to mph in Puerto Rico (close #6626) 2019-07-16 10:33:07 -04:00
Bryan Housel 618587aa48 Don't allow layer changes while drawing
(closes #6584)
2019-06-30 01:08:25 -04:00
Quincy Morgan 2ad2bac931 Limit addable presets via comma-separated IDs in the presets URL parameter (close #6553) 2019-06-24 12:38:32 -04:00
Quincy Morgan 59c81d4fc2 Remove issue "autofix" buttons 2019-06-17 10:21:41 -04:00
Quincy Morgan 1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Bryan Housel 44349c8015 Swap wikidata/wikipedia for brand: tags if possible
(closes #6416)

This also ignores any features with an office tag, to avoid
changing a wikipedia/wikidata tag on a corporate office.
2019-05-24 14:24:10 -04:00
Bryan Housel b4ebaaa01e Fix raw tag editor styling for custom data editor
(closes #6427)
2019-05-24 11:32:14 -04:00
Quincy Morgan 43cd46f046 Prevent Chrome autofill of recent values in the Allowed Access inputs (close #6414) 2019-05-24 09:30:06 -04:00
Quincy Morgan ca19d50558 Fix issue where duplicate expanded community entries could appear (close #6422) 2019-05-23 17:02:15 -04:00
Quincy Morgan 8e66b74bcc Make unsquare threshold field wider to account for stepper control in Firefox (close #6418) 2019-05-23 10:01:30 -04:00
Quincy Morgan 35b3102006 Add Disable All and Enable All buttons for the Map Features list (close #5234) 2019-05-22 11:56:04 -04:00
Quincy Morgan 6260cdbb8f Fix several lint warnings 2019-05-22 10:48:39 -04:00
Quincy Morgan f5a8615f5c Fix bug where iD could add empty source tag to changeset (close #6405) 2019-05-22 10:47:23 -04:00
Bryan Housel e1331016d1 Merge pull request #6386 from openstreetmap/configurable-squareness
Allow user to adjust the threshold for the unsquare building warning
2019-05-20 21:04:30 -04:00
Bryan Housel 69a25fd6aa Move locking code from input and localized up to uiField
Also adjust styles some more for wikidata tagged items
2019-05-20 17:50:50 -04:00
Quincy Morgan 460f136819 Lower default threshold for unsquare building detection to 5 degrees
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
2019-05-20 15:48:01 -04:00
Bryan Housel 06bdfbfb8a Use gray stroke on marker and lock icon on field for locked item 2019-05-20 15:36:10 -04:00
Bryan Housel 511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Bryan Housel cc4991d111 Don't draw until we've set zoom/lat/long 2019-05-17 11:19:38 -04:00
Bryan Housel 94c5164fe2 Add ability to show the square threshold in the rule name 2019-05-17 02:15:20 -04:00
Bryan Housel bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel aa7820b699 Don't treat new raw_tag_editor rows the same as deleted rows
(closes #6369)
2019-05-16 15:36:47 -04:00
Quincy Morgan 961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00
Bryan Housel 7be09db9ef Don't try to change a key/value that's already about to be deleted
(closes #6366)
2019-05-15 14:02:23 -04:00
Quincy Morgan 8bc634beac Make the raw member display limit a single variable 2019-05-14 15:31:50 -04:00
Quincy Morgan 49bef3d277 Fix issue where entries in the raw member editor wouldn't update after downloading the member manually (close #6358) 2019-05-14 15:31:07 -04:00
Quincy Morgan a9c30e840c Revalidate immediately after running most fixes (close #6354)
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
2019-05-14 14:41:07 -04:00
Quincy Morgan 401c3a5005 Fix issue with the Label field by changing the class name of form-field-label (close #6344) 2019-05-13 10:36:21 -04:00
Quincy Morgan ea1773f953 Fix error upon starting the walkthrough from the Help pane 2019-05-10 12:34:24 -04:00
Quincy Morgan 7a6949aa2e Account for the width of open panes when centering the map on issues 2019-05-10 11:33:59 -04:00
Quincy Morgan 1bbd496dfe When selecting an issue in the Issues pane, highlight the issue after selecting the feature
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
2019-05-10 10:18:46 -04:00
Quincy Morgan f264cc47f0 Don't flag almost junctions when endpoint is building or parking entrance
Include issues for disabled rules in entity issues
2019-05-09 14:38:19 -04:00
Bryan Housel 289c75fee1 When showing tooltip, update disabled in case disabled states disagree
(closes #6296)
2019-05-07 17:53:22 -04:00
Bryan Housel 58cae43b9b Use parentNode instead of parentElement for IE 2019-05-07 17:48:56 -04:00
Quincy Morgan 3d9f7244f0 Update issue messages after merge instead of by invalidating issues 2019-05-07 16:38:08 -04:00
Quincy Morgan 97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan 5160754dcc Display issues for disabled rules in the commit UI
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
2019-05-07 13:07:31 -04:00
Bryan Housel 966f5c3586 Add explicit validation calls to each operation
This is cleaner than adding hooks to transitionable actions, or performing validation
on every history change.  We want validation to run after each operation, but not
while the user is drawing lines or typing in fields.
2019-05-06 14:49:46 -04:00
Bryan Housel 659240d9fa Disclosure should unhide before rendering content
(closes #6312)

In case something in the content can't cope with `display: none`
2019-05-05 15:56:56 -04:00
Bryan Housel ddc9d16b62 Merge pull request #6302 from openstreetmap/text-raw-tag-editor
Text raw tag editor / Copy-paste tags
2019-05-03 14:53:08 -04:00
Bryan Housel 16ec25753d Support escaping of tricky characters, support quoted strings
keys or values can be quoted or unquoted:
- leisure=park
- leisure="park"
- "leisure"=park
- "leisure"="park"
2019-05-03 14:42:35 -04:00
Quincy Morgan cc85897348 Fix map pane animation on RTL layout (close #6290) 2019-05-03 11:05:10 -07:00
Bryan Housel 22b7e03d3b Disable spellcheck in the tag textarea 2019-05-03 10:39:38 -04:00
Bryan Housel 8a4e822fd7 If All Fields section is hidden, focus textarea and put cursor at end 2019-05-03 10:33:50 -04:00
Bryan Housel fbe5389ecb Set textarea height to fit content 2019-05-03 10:14:53 -04:00
Bryan Housel c95860f36d Convert changes in the textarea back to tag changes 2019-05-02 23:01:33 -04:00
Bryan Housel 61819058d3 Avoid frequent reflow from setting scrollTop
(possibly re: #6289)
2019-05-02 14:21:57 -04:00