Martin Raifer
4d78e80ea1
fix scrolling glitch in Firefox on Windows and Linux/Xorg
...
For some elements, Firefox reports wheel deltas measured in lines (see https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent/deltaMode ), which we need to convert to pixels. The previous routine hugely overestimated the conversion factor if the deltaY as slightly bigger (not sure where the exp function came from originally, it does not make much sense IMO).
The lines-to-pixels factor does not seem to be quite consistent between different Firefox builds, but this compromise factor should be good enough, I hope.
PS: Firefox on Mac OS does not report deltas as lines anymore it seems.
closes #10825
2025-03-03 21:06:24 +01:00
Kyle Hensel
108893c624
enable --no-isolate to speed up unit tests
...
This required fixing deferred code that was running after the unit test had unmounted
2024-10-16 13:42:51 +02:00
Martin Raifer
342a03bcfe
allow type/id syntax in id hash param, and add support for notes
2024-05-28 20:18:53 +02:00
Bryan Housel
a962c6f96c
Can't redraw while transformed
2021-08-13 17:36:45 -04:00
Milos Brzakovic
2270b5dd9c
fixes mac os firefox scroll. closes #8595
2021-08-13 16:51:02 +02:00
Milos Brzakovic
c8aedcbb79
minor trailing spaces
2021-08-05 18:36:25 +02:00
Milos Brzakovic (E-Search)
92a9ef2061
Move CrossEditableZoom event firing.
...
It should happen after projection is transformed.
2021-04-27 14:10:13 +02:00
Quincy Morgan
611abf8ed0
Enable rotating selection even when mouse isn't over the map (re: #8187 )
2020-12-03 15:04:21 -05:00
Quincy Morgan
21a49bbec8
Initial support for D3 v6.2.0
2020-10-06 15:08:39 -04:00
Peter Newman
4205ca1d07
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
(cherry picked from commit 2c47a11008 )
2020-08-10 17:32:37 +01:00
Quincy Morgan
cf868464f4
Fix issue where hover sidebar wouldn't be closed when zooming out past editable extent ( close #7765 )
2020-07-13 15:47:12 -04:00
Quincy Morgan
cf362cdcac
Keep the edit menu open while panning the map but not zooming
2020-06-30 11:50:56 -04:00
Quincy Morgan
0473243930
Add workaround for broken rapid tapping on iOS 13.4+ ( close #7694 )
2020-06-15 12:27:53 -04:00
Quincy Morgan
572ce0a787
Make sure horizontal-only scroll events can be translated into map pans ( close #7659 )
2020-06-04 13:29:45 -04:00
Jacob Scherber
bfa1dbf8d4
remove trailing whitespace on line
2020-05-31 14:19:40 -07:00
Jacob Scherber
24ceda3d9c
header size didn't include padding above buttons
2020-05-31 13:50:26 -07:00
Quincy Morgan
7b09b6c0dc
Enable low-zoom display of focused feature when resolving conflicts ( close #7330 )
2020-05-18 17:14:50 -04:00
Quincy Morgan
a5091c3bd0
Account for pointerId and simplify position calculations in doubleUp (re: #7611 )
2020-05-18 09:58:15 -04:00
Quincy Morgan
dff4268256
Allow selection, deselection, and multiselection with the spacebar (re: #3843 )
...
Don't open the edit menu on single spacebar press
Open the edit menu for long spacebar press (re: #7577 )
2020-05-14 11:19:20 -04:00
Quincy Morgan
e6fc7e221a
Fix menu position when long-pressing features on touchscreens (re: #7577 )
...
Improve comment
2020-05-10 10:59:56 -07:00
Quincy Morgan
77552c4430
Fix map interaction on devices not supporting pointer events
2020-05-08 15:44:02 -07:00
Quincy Morgan
5a8f573889
Continue zoom/pan of map when a down pointer moves off the map (re: #5505 )
...
Fix possibly #6745
2020-05-08 15:30:38 -07:00
Quincy Morgan
8734b67821
Remove the context.intersects passthrough function
2020-04-01 15:36:53 -07:00
Quincy Morgan
a58abe3c6f
Move localStorage interface from a property of coreContext to a corePreferences function
2020-04-01 11:00:48 -07:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
9731b93cec
Move uiTooltipHtml functionality into uiTooltip
...
Refactor uiEditMenu to use standard UI patterns instead of SVG
2020-03-25 12:22:10 -07:00
Quincy Morgan
eed7944a1a
Replace various uses of d3_select and d3_selectAll with selection on the container
2020-03-22 12:34:06 -07:00
Quincy Morgan
5fd25601fe
Convert map surface and supersurface from ids to classes
2020-03-21 13:41:06 -07:00
Quincy Morgan
9eb694faec
Remove radial menu
2020-03-13 13:29:46 -07:00
Quincy Morgan
73d68b7a65
Fix issue where browsers could page back or forward when swiping horizontally over the map with a trackpad ( close #5552 )
2020-03-10 11:15:15 -07:00
Quincy Morgan
41e58dc32e
Fix issue where vertices wouldn't always disappear on deselection ( close #7419 )
2020-03-09 15:58:24 -07:00
Quincy Morgan
f8f69a777a
Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events
...
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128 )
Support adding nodes to ways with double-tap with on touch devices (close #2677 )
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
2020-03-06 12:46:26 -08:00
Quincy Morgan
83a51a4192
Use pointer events for node dragging and drawing (re: #5505 )
...
Enable dragging nodes with touches and styluses (close #7415 )
2020-03-05 15:18:39 -08:00
Quincy Morgan
1147438d12
Use pointer events for map zooming and panning where supported ( close #6598 , re: #5505 )
2020-03-05 10:38:30 -08:00
Quincy Morgan
f4c39cc434
Don't require translations or uiFlash in rendererMap
2020-03-02 14:59:11 -08:00
Quincy Morgan
3ae009ea49
Rename d3_zoom object to disambiguate from zoom level variables (re: #5505 )
2020-02-27 19:51:07 -08:00
Quincy Morgan
b921ca3cb4
Move map features and map style options to their own pane section objects (re: #7368 )
...
Handle area fill and change highlighting logic in the rendererMap object and issue change events
2020-02-19 11:23:02 -08:00
Quincy Morgan
827c8034d5
Enable zoom-to-center of multiple selected entities ( close #6696 )
2019-12-13 10:30:00 -05:00
Quincy Morgan
912151ff38
Allow viewing and editing the tags/relations of selected features at any zoom level in 2.x (re: #5001 )
2019-12-12 16:54:16 -05:00
Quincy Morgan
9d936b4aea
Rename rendererMap.editable function to more precise rendererMap.editableDataEnabled
...
Make coreContext.editable function also account for whether user is in modeSave
2019-12-12 16:06:28 -05:00
Quincy Morgan
c2a49f4e02
Disallow zooming past the min/max zoom bounds via scrolling or pinch-to-zoom ( close #6851 )
2019-09-19 16:27:51 -04:00
Quincy Morgan
a97f05c9dc
Disable zoom in/out buttons when at max or min zoom already ( close #6847 )
2019-09-18 15:56:32 -04:00
Quincy Morgan
dd7b2603af
Fix issue where a deleted feature might not disappear from the map ( close #6480 )
2019-08-13 15:25:07 -05:00
Quincy Morgan
c95cead06d
Fix bug where issues would not be properly centered if the map was not already at z19 ( close #6384 )
2019-05-24 10:28:59 -04:00
Quincy Morgan
7a6949aa2e
Account for the width of open panes when centering the map on issues
2019-05-10 11:33:59 -04:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
7dce4bb161
Avoid asking DOM if layers are classed disabled in map.editable
...
`map.editable` is hot code because it's called frequently by the `isHiddenX`
tests in `features.js`. It's much more efficient to just ask the osm layer
whether it is enabled, than to use D3 to find that layer in the DOM and check
whether it's classed `disabled`
2019-04-22 22:12:42 -04:00
Bryan Housel
51c1088c1b
Merge branch 'master' into validation_and_change_perf
2019-04-19 15:18:23 -04:00
Quincy Morgan
84b7e08bf8
Don't select the previously-edited node when undoing/redoing (re: #5831 )
2019-04-16 14:21:15 -07:00
Bryan Housel
0dd262d1dd
Don't dispatch 'change' on history.merged, dispatch 'merge' only
...
Change performs an expensive immediate redraw, and merge can schedule
a redraw for later.
2019-04-12 09:56:18 -04:00