Commit Graph

278 Commits

Author SHA1 Message Date
Quincy Morgan
60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a1a398650f Instantiate uiFlash only once as a property of the UI and remove global selection (re: #7445) 2020-03-29 10:22:58 -07:00
Quincy Morgan
4a67e8c5dc Remove delay in opening the edit menu
Don't show the edit menu for multiple selected relations
Streamline edit menu code, replacing the confusing "suppressMenu" system
2020-03-26 12:48:30 -07:00
Quincy Morgan
37b1f35ab4 Properly switch the edit menu tooltip side depending on space 2020-03-25 15:34:02 -07:00
Quincy Morgan
13c8753c11 Reuse the uiEditMenu instead of recreating it every time the operations change 2020-03-25 14:49:24 -07:00
Quincy Morgan
5c2a96dedb Fix issue where the edit menu would not disappear sometimes (close #7143)
Properly disable dragging the map under the edit menu for pointer events (re: #5505)
2020-03-25 14:33:42 -07:00
Quincy Morgan
9731b93cec Move uiTooltipHtml functionality into uiTooltip
Refactor uiEditMenu to use standard UI patterns instead of SVG
2020-03-25 12:22:10 -07:00
Quincy Morgan
0931459dba Reduce use of global selection (re: #7445) 2020-03-24 13:02:06 -07:00
Quincy Morgan
eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan
6087aae21f Remove map convenience functions of context 2020-03-22 10:57:17 -07:00
Quincy Morgan
3c0b926ec7 Replace coreContext.geometry function with a more explicit coreGraph.geometry function 2020-03-21 14:23:44 -07:00
Quincy Morgan
fac613e1dc Remove context.childNodes function 2020-03-21 13:56:11 -07:00
Quincy Morgan
f2a687f68b Convert container from id to class 2020-03-20 15:08:56 -07:00
Quincy Morgan
c893147e15 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:53:17 -07:00
Quincy Morgan
152d89fa22 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:10:39 -07:00
Quincy Morgan
9eb694faec Remove radial menu 2020-03-13 13:29:46 -07:00
Quincy Morgan
b5856e2415 Rewrite behaviorDrawWay to only always use one and only one temporary edit
Fix issues involving undoing while drawing ways
Prevent self-intersection when adding nodes to ways on touch devices (close #7423)
2020-03-11 17:48:09 -07:00
Quincy Morgan
ece7eb0850 Add self-intersection error message when dragging vertices 2020-03-09 14:52:17 -07:00
Quincy Morgan
10f7ef2704 Add error feedback text when attempting to draw self-intersecting ways 2020-03-06 15:36:48 -08:00
Quincy Morgan
f8f69a777a Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128)
Support adding nodes to ways with double-tap with on touch devices (close #2677)
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
2020-03-06 12:46:26 -08:00
Quincy Morgan
83a51a4192 Use pointer events for node dragging and drawing (re: #5505)
Enable dragging nodes with touches and styluses (close #7415)
2020-03-05 15:18:39 -08:00
Quincy Morgan
5e8d84ec33 Fix eslint warning 2020-03-02 15:58:30 -08:00
Quincy Morgan
abf536aa9b Make commit changes its own collapsible section 2020-02-24 14:03:06 -08:00
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Quincy Morgan
1720f7cb93 Organize some code in coreUploader (re: #7333)
Fix lint error
2020-02-05 17:53:28 -05:00
Quincy Morgan
237a382c51 Merge branch '2.x' into uploader
# Conflicts:
#	modules/modes/save.js
2020-02-05 16:23:09 -05:00
Quincy Morgan
3b19cc32fd Don't grey out the map during conflict resolution (close #6547) 2020-02-05 16:16:50 -05:00
Quincy Morgan
0e14241fcf Move some upload code from modeSave to new coreUploader object (re: #7247) 2020-02-05 15:28:23 -05:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Bryan Housel
b8a8927d33 Start preparing uiSuccess early when saving changeset
This gives us some time to fetch and prepare the community index
2020-01-29 15:23:37 -05:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
7ca9f55d43 2.x: Don't render multipolygon members in yellow when the multipolygon is selected (re: #6558, re: 4ab97128c4aae04b627cf8f19091c6c0fc1cf5bc) 2019-12-13 14:19:15 -05:00
Quincy Morgan
91b6844377 Implement cleaner solution for removing breathe styling from deselected features 2019-12-13 13:16:29 -05:00
Quincy Morgan
61f0a670db Correctly remove yellow member highlight when removing member from select relation (close #6772)
Don't exit select mode when panning selected feature out of view
Return false when checking selected IDs and switching between single and multiselect in modeSelect
2019-12-13 12:07:43 -05:00
Quincy Morgan
7473d32e31 2.x: Highlight relation members in yellow when a relation is selected, including in a multi-selection (re: #5766, re: cf2935576511a1b9f5aac47407ed2b0ce803902a) 2019-12-13 11:20:40 -05:00
Quincy Morgan
9920c7dd1d Fix typo in comment 2019-12-13 11:10:09 -05:00
Quincy Morgan
e352d425e9 Prevent opening edit menu in wide selection 2019-12-13 11:06:36 -05:00
Quincy Morgan
827c8034d5 Enable zoom-to-center of multiple selected entities (close #6696) 2019-12-13 10:30:00 -05:00
Quincy Morgan
ff506fc332 Prevent partial rendering of selection style when showing only selected features at low zooms 2019-12-12 17:50:48 -05:00
Quincy Morgan
912151ff38 Allow viewing and editing the tags/relations of selected features at any zoom level in 2.x (re: #5001) 2019-12-12 16:54:16 -05:00
Quincy Morgan
9aa27f68c3 Fix stale UI when undoing/redoing between single and multiselections (re: #7090) 2019-12-10 10:07:05 -05:00
hack.ily
b40d4ac893 Fix lint 2019-10-28 10:20:40 -04:00
hack.ily
b5fac6396e fix(mode/rotate): polygonHull sometimes returns array of length 2 which polygonCentroid cannot handle 2019-10-28 10:20:26 -04:00
Quincy Morgan
08530dd822 Prevent stale operations by reloading them after history changes 2019-10-03 16:57:12 +02:00
Quincy Morgan
16bc43b00e Clear hover-highlighting when exiting modeSelect 2019-08-22 15:49:28 -05:00
Quincy Morgan
c97ea095f5 Select standalone points after dragging them (close #5747) 2019-08-21 13:46:04 -05:00
Quincy Morgan
760134c2aa Add check for possible missing activeEntity in drag_node 2019-05-08 12:17:36 -04:00
Bryan Housel
8f9dc7afb4 Improve localization of "Thank you for editing the map around.."
(closes #6269)
2019-05-04 13:24:46 -04:00