Commit Graph

13008 Commits

Author SHA1 Message Date
Quincy Morgan 3a2757576b Add Monorail Route, Turnstile, and Transit Stop Area Group presets (close #5757) 2019-04-16 11:41:56 -07:00
Quincy Morgan 5a4283bba1 Add Water Turbine preset 2019-04-16 11:01:42 -07:00
Quincy Morgan fa1ec8f097 Lower tourism=attraction matchScore to avoid overriding defining presets 2019-04-16 10:44:51 -07:00
Quincy Morgan e89eee5ae4 Add natural=cape preset 2019-04-16 10:12:45 -07:00
Quincy Morgan 72266af1e5 Show case-sensitive taginfo results for Manufacturer field 2019-04-16 09:59:00 -07:00
Bryan Housel 8afd8887cf Restyle much of the issues and entity issues - avoid tooltips 2019-04-16 12:33:48 -04:00
Quincy Morgan 184f4a17e5 Update icon for Ticket Seller 2019-04-16 08:57:41 -07:00
Quincy Morgan 64eb437a8a Add Lighting Store preset for shop=lighting 2019-04-15 18:01:12 -07:00
Quincy Morgan d5845cf8fe Update icon for Travel Agency 2019-04-15 17:54:20 -07:00
Quincy Morgan 9cf3b1fc38 Add generic preset for the "playground" key with a corresponding field 2019-04-15 17:35:07 -07:00
Quincy Morgan 3ad2046063 Add Tabletop Game Store preset for shop=games 2019-04-15 17:21:18 -07:00
Quincy Morgan f9299f4f75 Add Manufacturer field for various man made feature types
Remove area geometry from power=switch, as per the wiki and usage
Tweak fields for some presets
2019-04-15 17:05:18 -07:00
Quincy Morgan 5335104521 Add seamark:type=light_major to addTags of man_made=lighthouse 2019-04-15 16:23:17 -07:00
Quincy Morgan 5d22a618c5 Add derived data for name-suggestion-index 2.0.1 2019-04-15 16:15:31 -07:00
Quincy Morgan b02bb74d31 Update rollup and mapillary (close #6166, close #6143) 2019-04-15 15:49:10 -07:00
Quincy Morgan e3e3fd1ad3 Fix Wikipedia field test 2019-04-15 15:32:57 -07:00
Bryan Housel 294ce00211 substitute 'info' for 'data' (so I can use 'info' for an info drawer) 2019-04-15 16:56:21 -04:00
Quincy Morgan 80a6e1806f Don't remove wikidata tag when clearing the wikipedia field value (close #4322) 2019-04-15 13:39:30 -07:00
Quincy Morgan f66836dd37 Prevent photo viewer from overlapping info panes or panels (close #5212) 2019-04-15 12:12:23 -07:00
Quincy Morgan 6bdf6c5127 Fix minimap position (close #6167)
Flexbox panes and info panels to prevent overlap (close #4733)
2019-04-15 11:50:54 -07:00
Bryan Housel f6708fd84c Hide feature if _all_ rules hidden (was: if _any_ rule hidden)
This matters as we start to match more rules for hybrid features like rail
platforms, which now match both path and rail.  We want to show them unless the
user has hidden all the rules that they match.

Also this changes the test code slightly to actually test rule matching.
Before it was really just testing hiding.
2019-04-15 10:20:58 -04:00
Bryan Housel 15e73d2836 Trying out simpler outdated_tags code, with tag diff 2019-04-14 17:25:51 -04:00
Bryan Housel 5a0f21fa7a Add ability for a fix to be auto, and add auto fix buttons
This also changes some of the list items that were previously buttons to divs,
since we can't nest buttons.
2019-04-13 10:50:47 -04:00
Bryan Housel ce89d7359b Sort issues list by dist from the map center, cutoff at 1000 items 2019-04-12 14:26:05 -04:00
Quincy Morgan 28db597e8f Fix an issue where pane tooltips could appear misplaced 2019-04-12 10:21:53 -07:00
Quincy Morgan 0c29054c36 Make keyboard shortcut modal responsive on small displays 2019-04-12 10:18:36 -07:00
Bryan Housel da1fe8343a Remove mode checking code from missing_tag, as these validate anytime
This was causing it to not immediately flag "area with no tags" as an error.
(until the user edited the area some other way)
2019-04-12 12:49:47 -04:00
Bryan Housel 0ec9cd91dc Warm up the feature matching cache upon merging fetched data
Also rename `_features` to `_rules`, since we use the word features too much
2019-04-12 12:25:37 -04:00
Bryan Housel 36d1f3701f Allow osm service tests to work with deferred parsing 2019-04-12 12:11:35 -04:00
Bryan Housel efcd6b6bc2 Consolidate idle functions into idle.js, defer validation after merge 2019-04-12 10:49:21 -04:00
Bryan Housel 0dd262d1dd Don't dispatch 'change' on history.merged, dispatch 'merge' only
Change performs an expensive immediate redraw, and merge can schedule
a redraw for later.
2019-04-12 09:56:18 -04:00
Bryan Housel dda810683e Adjust matchscore, feature filters to boost physical tags over boundary
(closes #6162)
2019-04-11 21:26:53 -04:00
Bryan Housel 2b050549eb Avoid reflow in minimap by hardcoding its dimensions 2019-04-11 21:05:04 -04:00
Bryan Housel 31b64f253c Rerun validation when assigning a preset 2019-04-11 15:11:29 -04:00
Bryan Housel 96c277f46d Simplify issue-options css 2019-04-11 14:59:32 -04:00
Bryan Housel 35049ab40a Replace getErrors/getWarnings with getIssues/getIssuesBySeverity
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
2019-04-11 14:48:23 -04:00
Bryan Housel 569cbd1a92 entity.v can be 0, so check for === undefined instead 2019-04-11 14:40:34 -04:00
Bryan Housel 4c563f4edf Add validation options
Check:  [] My Edits  [] Everything
Where:  [] In View   [] Everywhere
2019-04-11 11:55:17 -04:00
Quincy Morgan 891de117f4 Deprecate waterway=lock 2019-04-10 16:54:40 -07:00
Quincy Morgan 33f4ec2b35 Add Canal Lock and Lock Gate presets 2019-04-10 16:52:19 -07:00
Quincy Morgan c9a579bea6 Add Beehive and Street Cabinet presets 2019-04-10 15:20:37 -07:00
Bryan Housel 0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Bryan Housel 9100ce3ee4 Don't validate vertices which extend beyond the downloaded map
(closes #5938)
2019-04-10 13:40:06 -04:00
Bryan Housel f309e925d8 Memoize disabled for all the other operations too
see 81127d71f
2019-04-10 11:28:41 -04:00
Bryan Housel 81127d71f3 Cache disabled() results in straighten action for consistent response
What could happen was:
- user could right click on a line
- this would trigger `disabled()` checks for each operation buttons
- the line was not fully downloaded, so would return `disabled()` 'not_downloaded'
  (and also start download of the missing tiles)
- then the tooltip would pop into existence, calling `tooltip()`
- which calls `disabled()` again
- but this time it's fine and the `disabled()` is false
- so you'd see a greyed out button but the tooltip said everyting is ok and
  you can click the button anyway

I fixed this by just caching the disabled test.  This is probably ok anyway
because these tests can be expensive, and then the user will see a consistent
message like "The line is not yet fully downloaded".

If the user clicks off the line and back onto it, iD will reenter select mode,
rebuild the menu, redo the disabled test, and they will see the button enabled.
2019-04-10 10:19:23 -04:00
Bryan Housel e30090996b Add loadTileAtLoc to fetch data tile for a specific location
(closes #4890)

This lets iD request needed tiles outside of the viewport, for example to
properly straighten lines or validate features that may have unloaded
connections.
2019-04-09 23:49:31 -04:00
Quincy Morgan df7a2f978e Use highway tags for golf paths and cart paths (close #6165)
Offer to upgrade golf paths missing highway tags
2019-04-09 19:07:00 -07:00
Quincy Morgan 89d8f887be Allow disconnecting multiple selected vertices at once (close #6164) 2019-04-09 14:04:52 -07:00
Quincy Morgan 60ce58694c Add Screens field to Cinema preset 2019-04-09 09:53:31 -07:00
Quincy Morgan ae80c88f37 Render relation route icon lines dynamically (close #5926) 2019-04-08 19:58:50 -07:00