CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,135 Commits 2 Branches 0 Tags
433efd657ba44e088eaebfd9544be92c8679fbe4
Commit Graph

83 Commits

Author SHA1 Message Date
Quincy Morgan
949ec8afa0 Add issue count badges to the bottom info bar when validating Everything 2019-10-14 17:14:47 +02:00
Quincy Morgan
aba96f039f Add specific "no issues" message if the user has no edits 
Don't use "other features" language since "my edits" validation checks are no longer per-feature
 2019-10-11 13:22:53 +02:00
Quincy Morgan
cb95682674 Always show the reset ignored issues button when there are ignored issues 2019-10-11 12:29:59 +02:00
Albin Larsson
cd5cd81ba5 make additional buttons and links keyboard accessible 2019-07-31 08:24:26 +02:00
Quincy Morgan
59c81d4fc2 Remove issue "autofix" buttons 2019-06-17 10:21:41 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan
8e66b74bcc Make unsquare threshold field wider to account for stepper control in Firefox (close #6418) 2019-05-23 10:01:30 -04:00
Quincy Morgan
460f136819 Lower default threshold for unsquare building detection to 5 degrees 
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
 2019-05-20 15:48:01 -04:00
Bryan Housel
511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Bryan Housel
94c5164fe2 Add ability to show the square threshold in the rule name 2019-05-17 02:15:20 -04:00
Bryan Housel
bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback 
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
 2019-05-16 22:28:56 -04:00
Quincy Morgan
1bbd496dfe When selecting an issue in the Issues pane, highlight the issue after selecting the feature 
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
 2019-05-10 10:18:46 -04:00
Quincy Morgan
3d9f7244f0 Update issue messages after merge instead of by invalidating issues 2019-05-07 16:38:08 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
712f8bcb03 Avoid having hidden issues strings for both singular and multiple variations 2019-05-01 20:13:09 -07:00
Quincy Morgan
eeaad79cb1 Display info about hidden issues in the "no issues" UI 2019-05-01 14:50:56 -07:00
Quincy Morgan
1c15338bd5 Make reset ignored button consistent with enable/disable all rules buttons 2019-05-01 12:13:10 -07:00
Quincy Morgan
52d92f125c Add button to reset ignored issues 
Don't cache issue extent
 2019-04-30 16:32:36 -07:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
3fad3513c1 Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane 2019-04-26 16:05:10 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
a37ce90af7 Move "Fix All" from bottom of list to top 2019-04-23 17:42:14 -04:00
Quincy Morgan
4948474118 Set the default validation filters to be My Edits / Everywhere (re: #6223) 2019-04-23 10:34:10 -07:00
Bryan Housel
7e04175559 Add Enable All / Disable All validation rules links 
(closes #5986)
 2019-04-23 13:01:15 -04:00
Bryan Housel
bbf4495f5c pacify eslint 2019-04-19 23:44:49 -04:00
Bryan Housel
51c1088c1b Merge branch 'master' into validation_and_change_perf 2019-04-19 15:18:23 -04:00
Bryan Housel
2ebbb68604 Restore tooltips on rule checkboxes, separate 'tip' and 'reference' 
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
 2019-04-19 13:24:55 -04:00
Bryan Housel
a55b4387fe Make sure the notification badge starts out hidden 2019-04-18 19:06:23 -04:00
Bryan Housel
7c8a6eac9d Reintroduce disabled rules 
- They still run, but results are excluded from lists
- Also make sure to revalidate/dispatch/update when toggling rules
 2019-04-18 17:05:33 -04:00
Bryan Housel
9c4881cade Change autofix to accept arguments to perform, implement "fix all" 2019-04-17 17:51:29 -04:00
Bryan Housel
01d2e3eaf3 Replace validator tooltip with reference function, add tag diff 2019-04-16 17:07:53 -04:00
Bryan Housel
8afd8887cf Restyle much of the issues and entity issues - avoid tooltips 2019-04-16 12:33:48 -04:00
Quincy Morgan
6bdf6c5127 Fix minimap position (close #6167) 
Flexbox panes and info panels to prevent overlap (close #4733)
 2019-04-15 11:50:54 -07:00
Bryan Housel
5a0f21fa7a Add ability for a fix to be auto, and add auto fix buttons 
This also changes some of the list items that were previously buttons to divs,
since we can't nest buttons.
 2019-04-13 10:50:47 -04:00
Bryan Housel
ce89d7359b Sort issues list by dist from the map center, cutoff at 1000 items 2019-04-12 14:26:05 -04:00
Bryan Housel
96c277f46d Simplify issue-options css 2019-04-11 14:59:32 -04:00
Bryan Housel
35049ab40a Replace getErrors/getWarnings with getIssues/getIssuesBySeverity 
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
 2019-04-11 14:48:23 -04:00
Bryan Housel
4c563f4edf Add validation options 
Check:  [] My Edits  [] Everything
Where:  [] In View   [] Everywhere
 2019-04-11 11:55:17 -04:00
Bryan Housel
e377270372 WIP: introduce validatedGraph, try on mode change not history change 2019-04-06 13:39:19 -04:00
Bryan Housel
1bcc0f613c WIP: fix caches, replace id() function with plain id property 2019-04-05 17:41:04 -04:00
Bryan Housel
8b1c0551cc WIP: understand state held by the validator, avoid translations 
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
 2019-04-05 09:28:36 -04:00
Quincy Morgan
6aa1f86dfb Add warning for multipolygon members with no set role (close #5851) 2019-02-25 17:46:50 -05:00
Quincy Morgan
b8ac9a7de3 Add toggle-able list of rules to the Issues pane (close #5979) 
Toggling a rule off prevents the validation from running
 2019-02-25 15:31:05 -05:00
Quincy Morgan
aff86979a6 Better pane display at narrow window widths (close #5890) 2019-02-20 13:47:11 -05:00
Quincy Morgan
31eb837596 Fix issue where fixes would not expand when clicking an issue 
Rename issue label class to messages
Remove fix list animation
 2019-02-15 13:40:45 -05:00
Quincy Morgan
b57e5a75b8 Tweak issue pane icon badge 2019-02-15 12:19:48 -05:00
Bryan Housel
6a560861b2 Add notification badge to Issue pane icon 2019-02-13 16:56:17 -05:00
Bryan Housel
c292a32a66 Better message padding, remove double tooltip 2019-02-13 13:47:00 -05:00
Bryan Housel
448fe498bd Only recenter view if necessary, select after delay, fix maprules type 2019-02-12 17:25:54 -05:00
Bryan Housel
81bd734849 WIP uiEntityIssues cleanups, simplify 
fixes are still not being applied properly
 2019-02-11 20:44:02 -05:00