Martin Raifer
f990d5ac87
fix rendering of html of keepright issues
2022-02-02 18:55:33 +01:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
SilentSpike
3ee32776a7
Fix QA error icons
...
Pass service itself in to QAItem constructor for purpose of fetching
data. Store string as `title` property on the service.
2020-02-12 21:27:38 +00:00
Bryan Housel
fe00a40e9a
Move the keepRight data extrnal
2020-02-07 09:16:34 -05:00
SilentSpike
51efd5b714
Update and standardise QA implementations
...
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible
Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Quincy Morgan
271a4cbac7
Update rbush to 3.0.1 ( close #6359 )
2019-11-08 18:17:17 +01:00
Bryan Housel
b99be67169
When calling an errback from a Promise.catch, pass err.message
2019-04-25 21:58:36 -04:00
Bryan Housel
e6bc9d9e8f
Swap out d3-request, swap in d3-fetch
2019-04-24 16:25:25 -04:00
Bryan Housel
4a8c20c56e
Remove lodash forEach
...
(re: 6087)
2019-03-28 19:50:20 -04:00
Bryan Housel
7a6c63fcc5
Remove lodash extend (re: #6087 )
2019-03-23 00:38:39 -04:00
Bryan Housel
ff4f8f005f
Remove lodash find and findIndex
...
(re: #6087 )
2019-03-22 17:31:41 -04:00
Bryan Housel
bb0a47b255
Remove kr and keepRight for styles used generically
...
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
SilentSpike
3ed13e9a4a
Convert KeepRight to use generic error type
2019-02-04 16:54:07 +00:00
Bryan Housel
b3953e4a31
Don't mix up inflight tile requests with inflight keepright updates
...
(closes #5748 )
2019-01-22 23:20:17 -05:00
Bryan Housel
5ebe0976fe
Add closed:keepright changeset tag for closed issues
...
The issues are written as `schema:error_id` and semicolon delimited
e.g. `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
2019-01-10 23:27:55 -05:00
Bryan Housel
623f96449e
z-sort errors above warnings
2019-01-10 21:47:37 -05:00
Bryan Housel
ae8dffa43c
Improve URL error messages 411, 412, 413
2019-01-10 21:35:13 -05:00
Bryan Housel
7f321abbaf
Add links to the main error object in KeepRight error messages
...
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
2019-01-10 17:38:09 -05:00
Bryan Housel
d9015baa47
Improve links in KeepRight error messages
...
(re: #5679 )
Also move the localizeable string dictionary to data/keepRight.json
2019-01-07 16:10:44 -05:00
Bryan Housel
48cc06fdbb
Adjust distance from KeepRight marker and underlying geometry
...
Makes it easier to select the point/vertex that the error is about.
2019-01-04 21:28:35 -05:00
Bryan Housel
fadd8e2e8a
Switch KeepRight markers to use touch targets
...
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel
d0343c9fa7
Reintroduce some error localization, fix some nagging parse issues
2019-01-03 18:16:28 -05:00
Bryan Housel
35f8078f98
Reduce number of marker colors, increase contrast, tweak language
2019-01-03 15:30:36 -05:00
Bryan Housel
46ebce2d6f
Fix error reporting urls and make sure sidebar not showing stale data
2019-01-03 11:37:14 -05:00
Bryan Housel
9e6497b549
Update or remove the error after POSTing changes to server
2019-01-03 01:39:40 -05:00
Bryan Housel
69ce5ee964
Remove user details and auth and adjust button texts for commenting
...
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel
4494c3ab9c
Fix comment box style, remove unused vars for eslint
2019-01-02 15:46:25 -05:00
Bryan Housel
9557c0204a
Relax some more regex for tag parsing, (to support 'key=*')
...
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel
2ec02f369f
Simplify regex matching - goal is to have fewer, simpler rules
2019-01-02 11:46:13 -05:00
Bryan Housel
192b4da9e6
Fix the strings I broke in 3785ffb15
2018-12-29 17:30:35 -05:00
Bryan Housel
3785ffb154
Simplify translation strings
2018-12-22 12:12:28 -05:00
Bryan Housel
f7150004c0
Refactor things out of util with limited use, move more to service
2018-12-21 11:56:55 -05:00
Bryan Housel
4eb0e4b3a4
Remove more duplicate strings
2018-12-20 16:09:18 -05:00
Bryan Housel
177537f0ce
Move coincident markers away from related geometry and from each other
2018-12-20 15:23:53 -05:00
Bryan Housel
7f669d292f
Simplify KeepRight tile fetching code
2018-12-20 14:40:14 -05:00
Thomas Hervey
cedf6955b5
added: notes and todos for keepRight
2018-12-19 13:45:34 -05:00
Thomas Hervey
ee00635cc4
updated: some error colors; fixed: error 320, 220
2018-12-19 13:45:15 -05:00
Thomas Hervey
d125c62c78
updated: variable and function names, html regex
2018-12-19 13:43:48 -05:00
Thomas Hervey
d095de08fe
updated comment UI, added stub for POST; TODO: finish links & POST
2018-12-19 13:43:48 -05:00
Thomas Hervey
1335549ad3
cleaned map data UI; commented sub-layer filtering
2018-12-19 13:43:08 -05:00
Thomas Hervey
3e7146c63f
WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons
2018-12-19 13:40:56 -05:00
Thomas Hervey
18278371aa
WIP: identifying variables in errors
2018-12-19 13:38:40 -05:00
Thomas Hervey
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
Thomas Hervey
75cff00a2a
displaying keep right (currently as notes)
2018-12-19 13:18:37 -05:00
Thomas Hervey
b96965568f
WIP: added schemas for errors and warnings
2018-12-19 13:13:30 -05:00