Bryan Housel
b99be67169
When calling an errback from a Promise.catch, pass err.message
2019-04-25 21:58:36 -04:00
Bryan Housel
48b1ddc925
Rename fetch to fetchComboData to not conflict with fetch API
2019-04-24 16:24:36 -04:00
Bryan Housel
a37ce90af7
Move "Fix All" from bottom of list to top
2019-04-23 17:42:14 -04:00
Quincy Morgan
4948474118
Set the default validation filters to be My Edits / Everywhere (re: #6223 )
2019-04-23 10:34:10 -07:00
Bryan Housel
7e04175559
Add Enable All / Disable All validation rules links
...
(closes #5986 )
2019-04-23 13:01:15 -04:00
Bryan Housel
1d4770a3c6
Merge pull request #6211 from AndreasHae/feature/split-multiple-tags
...
Handle multiple tags when splitting up in tag editor
2019-04-23 11:05:03 -04:00
Bryan Housel
a3bc164c43
Redraw entity editor fields on addition, deletion too
...
This is important to make the turn restriction editor work
2019-04-23 01:07:38 -04:00
Bryan Housel
3fe9d75f35
Fix issues with issue cache for entities that no longer exist
2019-04-22 19:35:23 -04:00
Andreas Hässler
e49fdce215
Add missing semicolons
2019-04-22 23:43:55 +02:00
Andreas Hässler
2596b97dbc
Do not use ES6 features
2019-04-22 16:38:33 +02:00
Andreas Hässler
faa178797d
Handle multiple tags when splitting up
2019-04-22 16:22:59 +02:00
Bryan Housel
bbf4495f5c
pacify eslint
2019-04-19 23:44:49 -04:00
Bryan Housel
7c85cc997e
Merge branch 'master' into validation_and_change_perf
2019-04-19 22:44:04 -04:00
Quincy Morgan
b566ef05b5
Add Option+W shortcut to toggle the OSM data layer ( close #6104 )
2019-04-19 14:51:53 -07:00
Bryan Housel
51c1088c1b
Merge branch 'master' into validation_and_change_perf
2019-04-19 15:18:23 -04:00
Bryan Housel
b5c5a00abc
Get rid of the many_deletions validation 🔪
...
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
2019-04-19 13:33:29 -04:00
Bryan Housel
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
Bryan Housel
1092ddb125
Make sure to update the save count when restoring changes too
2019-04-19 10:56:00 -04:00
Bryan Housel
ae06e28f9b
Try to avoid style recalculation when typing on the comment box
...
I think this doesn't completely work.. It reduces the amount
of unnecessary DOM changes, but there are still some more.
2019-04-19 10:02:25 -04:00
Bryan Housel
a55b4387fe
Make sure the notification badge starts out hidden
2019-04-18 19:06:23 -04:00
Quincy Morgan
2f695a9747
Add link to the PeWu history viewer to the History panel ( close #6202 )
2019-04-18 14:06:48 -07:00
Bryan Housel
7c8a6eac9d
Reintroduce disabled rules
...
- They still run, but results are excluded from lists
- Also make sure to revalidate/dispatch/update when toggling rules
2019-04-18 17:05:33 -04:00
Quincy Morgan
a30051fd9c
Restore full screen ability
2019-04-18 10:37:22 -07:00
Bryan Housel
9c4881cade
Change autofix to accept arguments to perform, implement "fix all"
2019-04-17 17:51:29 -04:00
Bryan Housel
d6327aec56
Make reference function optional
...
Now it shows the "No documentation available" message if there is not one
2019-04-17 09:05:05 -04:00
Quincy Morgan
2967d2d020
Add support for icons from the noun project ( close #5691 )
2019-04-16 18:06:05 -07:00
Bryan Housel
01d2e3eaf3
Replace validator tooltip with reference function, add tag diff
2019-04-16 17:07:53 -04:00
Quincy Morgan
3a2757576b
Add Monorail Route, Turnstile, and Transit Stop Area Group presets ( close #5757 )
2019-04-16 11:41:56 -07:00
Bryan Housel
8afd8887cf
Restyle much of the issues and entity issues - avoid tooltips
2019-04-16 12:33:48 -04:00
Quincy Morgan
80a6e1806f
Don't remove wikidata tag when clearing the wikipedia field value ( close #4322 )
2019-04-15 13:39:30 -07:00
Quincy Morgan
6bdf6c5127
Fix minimap position ( close #6167 )
...
Flexbox panes and info panels to prevent overlap (close #4733 )
2019-04-15 11:50:54 -07:00
Bryan Housel
f6708fd84c
Hide feature if _all_ rules hidden (was: if _any_ rule hidden)
...
This matters as we start to match more rules for hybrid features like rail
platforms, which now match both path and rail. We want to show them unless the
user has hidden all the rules that they match.
Also this changes the test code slightly to actually test rule matching.
Before it was really just testing hiding.
2019-04-15 10:20:58 -04:00
Bryan Housel
5a0f21fa7a
Add ability for a fix to be auto, and add auto fix buttons
...
This also changes some of the list items that were previously buttons to divs,
since we can't nest buttons.
2019-04-13 10:50:47 -04:00
Bryan Housel
ce89d7359b
Sort issues list by dist from the map center, cutoff at 1000 items
2019-04-12 14:26:05 -04:00
Bryan Housel
2b050549eb
Avoid reflow in minimap by hardcoding its dimensions
2019-04-11 21:05:04 -04:00
Bryan Housel
31b64f253c
Rerun validation when assigning a preset
2019-04-11 15:11:29 -04:00
Bryan Housel
96c277f46d
Simplify issue-options css
2019-04-11 14:59:32 -04:00
Bryan Housel
35049ab40a
Replace getErrors/getWarnings with getIssues/getIssuesBySeverity
...
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
2019-04-11 14:48:23 -04:00
Bryan Housel
4c563f4edf
Add validation options
...
Check: [] My Edits [] Everything
Where: [] In View [] Everywhere
2019-04-11 11:55:17 -04:00
Bryan Housel
0a77a494aa
Merge branch 'master' into validation_and_change_perf
2019-04-10 14:22:20 -04:00
Bryan Housel
81127d71f3
Cache disabled() results in straighten action for consistent response
...
What could happen was:
- user could right click on a line
- this would trigger `disabled()` checks for each operation buttons
- the line was not fully downloaded, so would return `disabled()` 'not_downloaded'
(and also start download of the missing tiles)
- then the tooltip would pop into existence, calling `tooltip()`
- which calls `disabled()` again
- but this time it's fine and the `disabled()` is false
- so you'd see a greyed out button but the tooltip said everyting is ok and
you can click the button anyway
I fixed this by just caching the disabled test. This is probably ok anyway
because these tests can be expensive, and then the user will see a consistent
message like "The line is not yet fully downloaded".
If the user clicks off the line and back onto it, iD will reenter select mode,
rebuild the menu, redo the disabled test, and they will see the button enabled.
2019-04-10 10:19:23 -04:00
Quincy Morgan
ae80c88f37
Render relation route icon lines dynamically ( close #5926 )
2019-04-08 19:58:50 -07:00
Bryan Housel
8d66289cba
Run validation when switching fields, or when applying an issue fix
2019-04-07 23:10:20 -04:00
Quincy Morgan
c3653616e6
Make modals work better at small screen sizes
...
Flexbox the modal action buttons
Replace "col8" CSS class
2019-04-07 14:49:33 -07:00
Quincy Morgan
5e4e2ff7ee
Fix an issue where stale warning counts would still appear in changeset tags if they had all been resolved (re: #6123 )
2019-04-07 14:29:05 -07:00
Quincy Morgan
eafd2cec3e
Add a tooltip to the plus button in the "All relations" section (re: #3812 )
2019-04-07 14:05:31 -07:00
Bryan Housel
e377270372
WIP: introduce validatedGraph, try on mode change not history change
2019-04-06 13:39:19 -04:00
Bryan Housel
1bcc0f613c
WIP: fix caches, replace id() function with plain id property
2019-04-05 17:41:04 -04:00
Bryan Housel
78acd999c8
WIP: switch from validating everything to validating differences
2019-04-05 13:29:57 -04:00
Bryan Housel
8b1c0551cc
WIP: understand state held by the validator, avoid translations
...
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
(graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
