Commit Graph

2494 Commits

Author SHA1 Message Date
John Firebaugh 46f41fa4f4 Use undefined value to remove a key rather than empty string
Otherwise it is impossible to tab out of the key input of a
new tag row -- since the value is still empty, the tag is
removed before you have a chance to enter a value.
2013-05-26 13:36:22 -07:00
John Firebaugh 79737d2cd0 Work toward making inspector persistent 2013-05-26 13:36:21 -07:00
John Firebaugh da00413632 Fix zoom-to-feature annoyances
* Zoom to feature only if map parameter isn't also
  specified.
* Don't zoom too far in (>z20). Fixes #1511.
* Don't zoom too far out (<z16). Fixes #1522.
2013-05-24 21:47:49 -07:00
John Firebaugh d846e8e3f8 Use accessors
Not a mix of constructor arguments and bound datum.
2013-05-24 17:24:35 -07:00
John Firebaugh a61e0c9fd4 Fix preset search 2013-05-24 17:17:41 -07:00
John Firebaugh 16e5f5e2ce Extract Entity#isUsed 2013-05-24 15:46:05 -07:00
John Firebaugh 8f272f2508 Special case multipolygon preset icon
Multipolygons have geometry === "area", so normally
wouldn't trigger a 'preset-icon-relation' class.

This preset usually matches only in the case where
the tags are on the outer way and the multipolygon
itself is untagged. Otherwise, a more specific area
preset will match.
2013-05-24 11:26:12 -07:00
John Firebaugh 5868875833 Split "other" preset into geometry specific fallbacks
This way the name and icon can be geometry-specific.
2013-05-24 11:14:59 -07:00
John Firebaugh ab10f8ac38 Hook up relation icons 2013-05-23 22:20:14 -07:00
John Firebaugh 6b73f56f91 Remove accept behavior from preset forms
Doesn't really make sense with persistent sidebar.
2013-05-23 16:22:25 -07:00
John Firebaugh 27fa4aa1d6 Switch to a persistent sidebar 2013-05-23 16:06:34 -07:00
John Firebaugh bef4cd60a3 Convert constructor argument to accessor 2013-05-23 16:05:40 -07:00
John Firebaugh 19638acd14 Push close event handling down 2013-05-23 16:05:07 -07:00
John Firebaugh 69d548507d Simplify 2013-05-23 15:05:03 -07:00
John Firebaugh 4cda3830a2 Remove unused parameter 2013-05-23 15:02:22 -07:00
John Firebaugh 76eb0fca85 Extract iD.ui.ViewOnOSM 2013-05-23 14:59:38 -07:00
Saman Bemel-Benrud 975d538d23 relations styles for relation selection. 2013-05-23 17:15:38 -04:00
Saman Bemel-Benrud abeef29ed0 first pass at basic relations UI for members 2013-05-23 17:01:09 -04:00
John Firebaugh 49f864924a Show editor for tagless member entities 2013-05-22 17:42:02 -07:00
John Firebaugh 9c86e2a86c Display relation members and memberships in inspector
* Preset icon of relation/member
* Preset name of relation/member
* Name of relation/member
* Role
* Delete button

All currently unstyled.
2013-05-22 17:41:59 -07:00
John Firebaugh cac654e8ab Add iD.actions.ChangeMember 2013-05-22 17:41:06 -07:00
John Firebaugh 1276672783 Add iD.actions.DeleteMember 2013-05-22 17:37:26 -07:00
John Firebaugh affdc987e4 Rename removeMember -> removeMembersWithID 2013-05-22 17:28:51 -07:00
John Firebaugh 4ae4b33663 Extract iD.ui.Disclosure 2013-05-22 16:51:18 -07:00
John Firebaugh ebadc90ac7 Rename Taglist -> RawTagEditor 2013-05-22 16:51:18 -07:00
John Firebaugh abd6918140 Pass context 2013-05-22 16:46:39 -07:00
John Firebaugh b70b287dee Rename TagEditor -> EntityEditor
It's going to be used to edit relation memberships as well
as tags.
2013-05-22 12:16:57 -07:00
John Firebaugh 701910753c Simplify 2013-05-22 11:42:49 -07:00
John Firebaugh 0d7f38f6c1 Extract iD.util.localeName 2013-05-22 11:30:28 -07:00
John Firebaugh a77362c7b8 Remove extra wrapper 2013-05-22 11:20:32 -07:00
John Firebaugh 413b7abcb9 Improve tag reference loading feedback (#1262) 2013-05-22 11:13:54 -07:00
John Firebaugh 56a8407767 Tag reference doesn't need to be exclusive
This makes the implementation more complex and the
feature is of marginal benefit, possibly detrimental.
(What if I want to compare two tags and figure out
which one is more appropriate?)
2013-05-22 10:33:47 -07:00
John Firebaugh bbc45a4167 Remove unused 2013-05-22 10:29:07 -07:00
John Firebaugh 3fdbcfd09e Clean up class names 2013-05-22 10:29:07 -07:00
John Firebaugh fb01868a3c PresetGrid -> PresetList 2013-05-22 10:22:15 -07:00
John Firebaugh 9e4e794300 Rewrite PresetGrid 2013-05-22 10:22:15 -07:00
John Firebaugh 3249487632 Extract TagReferenceButton 2013-05-22 09:32:47 -07:00
John Firebaugh 663cb0fdbe Fix background hash param logic 2013-05-21 11:17:55 -07:00
Saman Bemel-Benrud ad629b2e11 Smoother transition for translate block/ 2013-05-21 14:04:14 -04:00
John Firebaugh bf21744077 Only draw intersections for {high,water,rail,aero}way lines
Fixes #1471
2013-05-20 17:16:36 -07:00
John Firebaugh bd2c7ba756 Render bridge casing for bridge=viaduct, etc.
Fixes #1500.
2013-05-20 16:49:55 -07:00
John Firebaugh 2631accdb3 Fix load event argument 2013-05-20 16:33:45 -07:00
John Firebaugh 67d95595ba Points always need full re-render (#569) 2013-05-20 12:05:31 -07:00
John Firebaugh 1db99586c4 Render only new features when a data tile is loaded 2013-05-20 12:05:31 -07:00
John Firebaugh d2e775ac65 Use correct changesets URL for dev 2013-05-19 20:11:41 -07:00
John Firebaugh 6c849baad6 Revert "Cache centroid"
Causes misplaced labels, suspect due to rounding artifacts.

This reverts commit 5344bdea26.
2013-05-18 09:20:58 -07:00
John Firebaugh 6045ffcfbe Comment why _childNodes needn't be updated 2013-05-18 09:20:58 -07:00
John Firebaugh 293bb23876 Graph#rebase must invalidate transients 2013-05-18 09:20:57 -07:00
John Firebaugh 5c9c865f12 Move flush to context 2013-05-18 09:20:57 -07:00
John Firebaugh 8e05ed271d Simplify 2013-05-17 16:43:40 -07:00