667a620a9f
fix the raw tag editor broken and strange cursor behaviour ( #9766 )
...
* fix the raw tag editor broken
* new approach
* fix typo to satisfy github checks
2023-07-13 02:04:33 -07:00
29b1197059
add code comment/documentation
2023-07-12 22:02:41 +02:00
396d142623
fix crash when rendering and email UI field, fixes #9752
2023-07-12 22:00:42 +02:00
fa35f0e78d
fix arguments of unsetTag call, fixes #9707
2023-07-07 18:39:44 +02:00
1c1086662e
fix crash when a multisel. contains empty&non-empty numeric vals, fixes #9739
...
this is a regression/bug in 559a4ba
2023-07-07 18:22:18 +02:00
53a510628c
fix crash when selecting some presets ( #9738 )
2023-07-07 15:15:15 +02:00
85affbadc8
lint
2023-07-07 13:34:08 +02:00
db886f5dd7
fix crash when using "exotic" locales which undefined languageNames
...
see also #9737
2023-07-07 13:31:36 +02:00
457a2101c6
fix crash in fr-FR locale ( #9737 )
2023-07-07 13:07:49 +02:00
ea054a00a5
fix bug in "lang=badvalue" handling for wikidata api
...
see https://github.com/openstreetmap/iD/pull/9638#issuecomment-1623497481
2023-07-07 12:49:55 +02:00
9595e997e9
Merge branch 'develop' into addr_place
2023-05-26 20:37:54 +02:00
f19a55fa13
Add support for icons on multiCombo/semiCombo fields ( #9433 )
2023-05-26 20:35:12 +02:00
140838f4b1
fix accidentally committed code, switch to different ford icon
2023-05-26 19:50:09 +02:00
5a3a2d876e
show inherited fields from global parents
...
fixes regression from 43784e2ef
2023-05-26 19:44:27 +02:00
53f77fb852
accept raw number input also for roadspeed/roadheight fields
2023-05-26 19:34:32 +02:00
2b64d70352
generalize implementation to skip input value update
...
when contents are "equivalent" in a given context, e.g. for numeric values with potentially different formatting in number fields
2023-05-26 19:24:10 +02:00
ee89f6ae66
lint
2023-05-26 18:46:57 +02:00
e0f11af2b2
also allow "raw" numbers to be input in numeric fields
...
when a user enters a decimal number using the "international"/English/OSM-raw-data formatting (e.g. as in `0.5`), it is parsed using the basic, non-localized, number parser. In such cases, the content of the input field should not be overwritten with the localized formatting, as that would cause unexpected glitches and make editing harder (e.g. when thousands-grouping characters seemingly "magically" disappear or appear while typing).
see https://github.com/openstreetmap/iD/pull/8769/#pullrequestreview-1324246437 ff.
2023-05-26 18:38:16 +02:00
7f4242864f
Merge branch '1ec5-number-field-format-3615' into develop
2023-05-26 18:03:31 +02:00
14c752548d
keep cursor at edit position while typing in the middle
2023-05-26 17:59:04 +02:00
b266ec57ad
treat "empty" numbers in semicolon separated "list" as invalid
2023-05-26 15:00:10 +02:00
6d01c05f76
allow numbers to be input in "raw" format
2023-05-26 13:44:50 +02:00
249771d747
fix variable declarations
2023-05-26 13:25:59 +02:00
6c362b6517
Merge branch 'develop' into 1ec5-number-field-format-3615
2023-05-26 13:06:09 +02:00
43784e2eff
take entity loc into account when resolving fields via parent preset, fixes #9524
...
this necessary when a regional preset (e.g. from NSI) is supposed to inherit fields from a parent preset, but the direct parent does NOT apply at the location of the entity to be added/edited. In that case we need to search for a potential regional variant of the parent preset.
2023-05-25 19:19:09 +02:00
28630ae9fc
don't repeat values from multi-selection in dropdown
...
as their state can now been toggled using the checkbox in the chip
2023-05-25 18:47:30 +02:00
805becfe3b
support no and "other" states of options of multiCombo/manyCombo fields
...
closes https://github.com/openstreetmap/id-tagging-schema/issues/895 and #7427
2023-05-25 18:17:00 +02:00
f517b867de
add tests for #9650
2023-05-25 15:24:52 +02:00
9517d06d11
use lodash for object comparison
2023-05-25 13:22:39 +02:00
e4641b581f
Offer to connect sidewalk to service road without tagging crossing ( #9650 )
2023-05-25 13:17:34 +02:00
077d9a5105
fix tag values with whitespace causing css bugs ( #9637 )
2023-05-23 23:21:41 +02:00
96c2670727
we can still use the full language for output (uselang)
2023-05-23 16:15:11 +02:00
862ca6522a
retry wikidata api without lng's region subtag if an error is returned
...
closes #9638
2023-05-23 16:13:40 +02:00
559a4ba728
support input fields with multiple tag keys
...
requires upstream changes from tagging-schema v6.3, see https://github.com/openstreetmap/id-tagging-schema/issues/905
2023-05-23 15:22:58 +02:00
bd98ff904b
restrict taginfo suggestions in raw tag editor to ones which match the input string
...
this additinoal filtering is needed because of the caching performed by the services/taginfo.js module.
2023-05-16 17:10:30 +02:00
9779f320a8
Properly handle case sensitive tags in taginfo suggestion in raw tag editor, fixes #9640
2023-05-16 17:06:39 +02:00
a35653d35d
use all available option strings when setting value
...
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.
important for openstreetmap/id-tagging-schema#891
2023-05-11 15:06:37 +02:00
25cf4366d1
Fix wrongly flagged "incorrect geometry type" for features with lifecycle-prefixed tags ( #9483 )
2023-05-10 12:02:37 +02:00
140e56768e
fix hiding of "Add" input on comboboxes with fixed options
...
the check for this needs to be done after the available options are actually refreshed
2023-05-02 14:10:48 +02:00
24e514fa99
defer loading of static combo options
...
fixes a bug where `multi/many/semiCombo` options are not selectable immediately after they were removed from a field, when the field does not use taginfo to fetch options
2023-05-02 13:01:32 +02:00
9aa28faf4a
only offer admin_level>8 for addr:place
...
as admin_level=8 is for `addr:city`
2023-04-30 21:07:15 +02:00
6f9bb116f3
fix logic bug, make condition more readable
2023-04-30 20:56:51 +02:00
aca88bf702
fix bug in getting nearby postcodes
2023-04-28 19:55:43 +02:00
caac22fe16
show addr:street when both it and addr:place is present
...
as in this case it is likely a mapping mistake where the "place" should actually be addr:city (or addr:suburb, etc.)
2023-04-28 17:52:55 +02:00
026737909f
implement special address field for addr:street/addr:place
2023-04-28 16:36:05 +02:00
a0b5cf5334
filter address combo field while typing
2023-04-27 17:25:58 +02:00
5cd5c10d92
consolidate similar methods
2023-04-27 17:25:58 +02:00
406c1a0690
bump streetview generation id to work around #9230
...
this is not a permanent fix; as explained in https://github.com/openstreetmap/iD/issues/8747#issuecomment-945669204 we should upgrade to Bing streetview's v8 API calls. Unfortunately, our API key is not enabled for that API, though.
closes #9230
2023-04-04 12:59:58 +02:00
e466ad4bf8
Update dependencies country-coder and location-conflation ( #9546 )
2023-03-30 12:53:38 +02:00
0334533aee
render sidedness markers for man_made=quay
...
see https://github.com/openstreetmap/id-tagging-schema/pull/810#issuecomment-1464181204
2023-03-13 15:14:27 +01:00
Kyℓe Hensel