Commit Graph

671 Commits

Author SHA1 Message Date
Bryan Housel 1df54a700a Disable circularize and orthogonalize operations when way is <80% contained in the viewport 2014-03-27 22:47:34 -04:00
John Firebaugh 2ab9239a9f More accurate modification tests 2014-02-25 10:12:34 -08:00
tyr efd3223e0c extend history loading fix to deletions
Deleted objects need to be kept in the base of the history stack, too.

This also improves the respective unit tests.
2014-02-22 14:09:17 +01:00
tyr 86c4bc9105 add tests for "restoring from v3 JSON" (core/history.js) 2014-02-21 10:19:36 +01:00
tyr fc0a15e6c4 fix duplicate objects after restoring data from localStorage
This makes sure that the originals of changed entities get merged
into the base of the stack after restoring the data from JSON.
This is necessary, because the stack will only have elements for
the current viewport after a restart and previously *modified*
objects will now be falsely detected as *created* ones.

Also removed some ineffective code.
2014-02-21 10:01:26 +01:00
John Firebaugh 44e260a429 Fix tests 2014-02-19 09:46:54 -08:00
John Firebaugh 3733b02a37 Expand tests 2014-02-09 18:45:47 -08:00
tyr 422f76be77 merge-polygons: do not merge tags from all possible members
previously when merging polygons, all tags from all involved
members were merged into the resulting multipolygon. This includes
existing inner members with different tags or outer members that
are not directly involved in the merge operations.

Example: A forest (landuse=forest) containing some clearings
(landuse=meadow), whose outline is in part a river (waterway=river)
is merged with a new untagged area. The resulting multipolygon
would have falsely been tagged: landuse=forest;meadow + waterway=river
2014-02-09 17:53:55 +01:00
tyr b71c98cfca protect against relation loops, part 2. fixes #2096 2014-01-10 11:12:10 +01:00
John Firebaugh 1561c366be Update OSM.org links 2014-01-08 16:29:00 -08:00
John Firebaugh ab8a4ffd7b Update GitHub links 2014-01-08 16:14:28 -08:00
John Firebaugh 4bf21cbc8a Restore deleted nodes that are discovered to have extant parents
This bug has existed since 1.0!

Fixes #2085
2014-01-06 16:23:15 -08:00
John Firebaugh 3e2968310b Ensure "New Relation..." is always available (fixes #2066) 2014-01-03 13:00:36 -08:00
John Firebaugh d381812f96 Add area=yes when necessary
Example: highway=pedestrian areas.

Fixes #2069
2014-01-03 12:46:50 -08:00
John Firebaugh 7bbca76a20 Protect against relation loops (fixes #2072) 2014-01-02 17:42:57 -08:00
Aaron Lidman 383023f4c1 Don't upload tags with empty values 2014-01-02 15:03:21 -05:00
Adam Solove 2213b072dd Clean up and test relation sorting code. 2013-12-10 22:39:37 -05:00
John Firebaugh cdd9f8ba5f Fix SVG parse errors in specs (fixes #2012) 2013-11-22 11:16:08 -08:00
Vladimir Agafonkin 831f4964aa fix build and tests, add missing methods to lodash build 2013-11-22 01:19:09 +02:00
John Firebaugh 15590525d3 Fix build 2013-11-21 14:51:52 -08:00
John Firebaugh 8ec53185df Build iD.Way.areaKeys from presets
This eliminates the possibility that a feature will
flip from area to line when you apply a preset.

Fixes #1996
2013-11-21 13:53:06 -08:00
Martijn van Exel c43d915625 Reverse cardinal directions for relation member roles 2013-11-21 10:08:16 -08:00
John Firebaugh 7d8a258be8 Fix spec 2013-11-19 12:33:21 -08:00
tyr 2cf4c20a47 don't load parent multiple times into tree when multiple childs are changed
when an action (e.g. moving a way) caused multiple child elements
of the same parent to be changed, their parent was also loaded into
the tree multiple times during `tree.intersects()`.

this fixes #1978
2013-11-19 11:27:29 +01:00
John Firebaugh 3f99e2fd4b Fix Disconnect of way with multiple intersections (fixes #1955) 2013-11-14 15:48:07 -08:00
John Firebaugh b383bfec1f Fix unclosed area rendering (fixes #1958) 2013-11-13 17:41:57 -08:00
John Firebaugh 2e754c8d6b Merge pull request #1950 from systemed/name-suggest
Autocomplete on name=*
2013-11-04 13:26:35 -08:00
Aaron Lidman ff97d44395 Add tests for suggestNames 2013-11-01 16:57:33 -07:00
John Firebaugh 492fc88aa4 Make the Graph#rebase argument an array 2013-10-31 16:24:31 -07:00
John Firebaugh 14bfc52e33 Remove repetition of entity IDs in tests
There were several places where the key and entity id
didn't match up.
2013-10-31 15:57:47 -07:00
John Firebaugh 5525702909 Lower match score of generic presets (fixes #1933) 2013-10-29 10:46:41 -07:00
John Firebaugh 38c208f821 Remove unused 2013-10-29 10:30:56 -07:00
John Firebaugh 191f52d634 Use assumed values for access placeholders (fixes #1924) 2013-10-28 17:39:34 -07:00
John Firebaugh ffdeef398d Rewrite tree logic
The main problem with the existing logic was that it
did not update the extents of relations when previously incomplete members were loaded.

It was also overly stateful; the various queues and flags
are no longer required.

Fixes #1928.
Fixes #1540.
2013-10-28 16:57:18 -07:00
John Firebaugh 95e667d6b7 More tests 2013-10-28 16:34:08 -07:00
John Firebaugh e0e08115e5 Pass entity array to Tree#rebase 2013-10-28 16:34:08 -07:00
John Firebaugh e6d3cb242c Clean up tests 2013-10-28 14:07:28 -07:00
John Firebaugh fbf2118c76 Fix change summary calculation after restoring
We can't rely on identity equality here due to how
restoring works, and don't want to anyway -- the summary
should ignore net-no-op tag changes.

Fixes #1915.
2013-10-23 17:35:35 -07:00
John Firebaugh 28aec51d20 Merge branch 'save-browse' 2013-10-23 13:37:57 -07:00
John Firebaugh 2de500a90a Add a few more vertex cases to summary 2013-10-23 13:36:58 -07:00
John Firebaugh 697faf0265 Use summary to calculate # in Save button 2013-10-23 13:36:58 -07:00
John Firebaugh b8e88a7aaf Convert relevantChanges to a method on Difference 2013-10-23 13:36:58 -07:00
John Firebaugh a05b9b1be5 Report an existing tagged vertex that is moved as modified 2013-10-23 12:00:07 -07:00
John Firebaugh d6c7c1d81d Fix tests 2013-10-21 16:24:06 -07:00
Aaron Lidman 594baa18b3 Update save commit dialog to use a feature list 2013-10-18 17:11:52 -04:00
John Firebaugh f1deed2712 Fix area sorting corner case (fixes #1903) 2013-10-18 10:28:01 -04:00
Aaron Lidman 1ae060e35f Excluding verticies where appropriate on save sidebar 2013-10-16 15:23:20 -04:00
John Firebaugh 26e38d7f8f Return geometries rather than features in asGeoJSON
No code needs the tags, and it eliminates one level
of function calls in the d3 stream pipeline.
2013-10-16 09:40:01 -04:00
Aaron Lidman 38489cbf17 Add selection_list to test index 2013-10-15 23:40:51 -04:00
John Firebaugh b51cfd5d84 Fix adding localized value before name (#1797) 2013-10-11 16:31:54 -07:00