Commit Graph

1309 Commits

Author SHA1 Message Date
Bryan Housel
492bb5b37e Eliminate magic scale numbers from tests, add loadNotes test xml 2019-02-07 11:31:32 -05:00
Bryan Housel
6be72709d5 Adjust tag_classes perimeter overrides to style barriers as lines
(closes #5761)
2019-02-02 11:52:23 -05:00
SilentSpike
5030346257 Update data layers test 2019-02-01 22:51:00 +00:00
Bryan Housel
09f7f9189f Fix field tests to run with minimal set of presets 2019-01-30 16:29:27 -05:00
Bryan Housel
71b2d2c6b7 Upgrade legacy symbols in tests
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
Bryan Housel
7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
Bryan Housel
15c0b82eb2 First attempt to run tests with minimal preset config 2019-01-30 10:25:40 -05:00
Bryan Housel
7aea67fcfe Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
Bryan Housel
b9444ab991 Restore hand cursor on dropdown carat
(closes #5769)

This change allows pointer events to flow to the caret, and forwards
them back to the combo input.  Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
Bryan Housel
55715a4827 Try to dispatch an accept event on blur
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
Bryan Housel
0c7b9a631e Improve combobox event handling and avoid overwriting typed data
(closes #5722, re: #5637, re: #5618)

dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)

Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
J Guthrie
631ace27d5 Add check to stop joining ways if resulting way intersects itself
- Includes new test case
2019-01-22 03:07:38 +00:00
Minh Nguyễn
9e3d49efb7 Replace wkid/w/s/n/e in WMS URL templates 2019-01-19 15:42:22 -08:00
Bryan Housel
19a8f5c47c Remove test that only works if we can reliably simulate clicks
Previously the combo showed immediately on mousedown, now it
shows on mouseup after some slight delay.
2019-01-18 23:34:59 -05:00
Bryan Housel
1ec5b708fc Restore default click behaviors on mousedown of a combobox
(closes #5732)
2019-01-18 23:23:35 -05:00
Yuri Astrakhan
d724677c9f Support extracting wiki info from tag and key 2019-01-15 21:50:57 -05:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
495793929f Skip wikidata field test, too time sensitive to work reliably 2018-12-27 12:06:53 -05:00
Yuri Astrakhan
9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Yuri Astrakhan
aa78cd10a3 Data items - remove hardcoded locale IDs
Locale IDs are now fetched together with the other data
when the language code is provided.
2018-12-22 14:58:15 -05:00
Yuri Astrakhan
b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel
22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Bryan Housel
e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman
e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Quincy Morgan
cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Bryan Housel
ca2d4e2c34 Fix layer test 2018-12-19 17:31:55 -05:00
Bryan Housel
2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey
75cff00a2a displaying keep right (currently as notes) 2018-12-19 13:18:37 -05:00
Bryan Housel
81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel
e1f26b5692 Merge pull request #5624 from ockendenjo/hat-route
Add more tests for splitting ways in relations containing loops
2018-12-19 12:10:12 -05:00
Max Grossman
399e7781c1 remove dispatched changes and re-order layers
ref #5587
2018-12-19 11:54:39 -05:00
Max Grossman
b010f42125 update layers test for new geolocate svg layer
ref #5587
2018-12-19 11:14:03 -05:00
ockendenjo
cec442012a Add test for route going round loop in other direction 2018-12-18 22:09:20 +00:00
ockendenjo
8aaa387d4e Add tests for hat route splitting #4876 2018-12-18 21:39:35 +00:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Max Grossman
64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman
4475964401 hey, do not comment out tests! 2018-12-17 12:56:34 -05:00
Max Grossman
1b51b8bc57 adding tests and updating/fixing external presets logic 2018-12-14 13:23:58 -05:00
Max Grossman
c897331cd1 presets test w/build 2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191 working on preset visibility 2018-12-13 11:16:24 -05:00
Bryan Housel
222b3f1b04 Don't render contents of collapsed sections
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
247900f727 Change several of the event things, remove numeric index
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
2018-12-07 16:54:32 -05:00
Huon Wilson
dd0be84da4 Add one-sided triangular markers to ways with sides (e.g. natural=cliff).
This generalizes the oneway arrow logic for adding SVG markers along a
line. Using that functionality, certain tags get arrows on their
right-hand side, indicating which side is "inside", e.g. the
right-side of a cliff is the lower side.

The list of tags considered to be sided (unless there's a
two_sided=yes tag) is:

- natural=cliff
- natural=coastline
- barrier=retaining_wall
- barrier=kerb
- barrier=guard_rail
- barrier=city_wall
- man_made=embankment

The triangles attempt to be reminiscent of the triangles used for
rendering cliffs on OSM (and elsewhere). The different tags get
different renderings (e.g. colors that match the main way, and
different spacings). In addition, natural=coastline is special-cased
to have blue markers (despite having a green way), to emphasise that
the "inside" of a coastline is the water.

Fixes https://github.com/openstreetmap/iD/issues/1475.
2018-11-28 01:45:50 +11:00
Huon Wilson
f356c6ac49 test: add tests for adding oneway arrows to lines 2018-11-28 01:25:04 +11:00