Commit Graph

15 Commits

Author SHA1 Message Date
Bryan Housel
99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Bryan Housel
b6c2645409 Add history urls to osm service and more URL tests 2017-06-30 00:52:05 -04:00
Bryan Housel
1a8cfcc8b1 Changeset refactor
(closes #2633)

* move osmChangeJXON from osm service to osmChangeset
* cleanup putChangeset for code clarity
* adjust params for callbacks (pass changeset around instead of changeset_id)
* add commit.reset() to reset changeset object after successful save
* improve checks for changeset tags (trim whitespace, etc)
2017-03-15 11:03:43 -04:00
Bryan Housel
d1aac857a4 Ignore server changesets with missing comment tag or empty comment 2017-03-11 14:28:30 -05:00
mstn
05e5cf9030 add type information to references 2017-03-02 11:26:14 +01:00
mstn
3205650798 order to-be-created relations by dependencies in a changeset 2017-03-02 09:17:08 +01:00
Bryan Housel
a7ac44f6e8 Refactor imageryBlacklists so it can be called without triggering a GET
Previous code was problematic because we need the function to
to properly blacklist custom imagery passed in through the url hash,
before iD is completely initialized.  Triggering GET causes tests to
break because osm service testing has side effects :-/
2016-12-04 21:35:55 -05:00
Bryan Housel
b9888e45e4 Add imageryBlacklists function to get blacklists from OSM API
(for #3623)
2016-12-03 19:25:07 -05:00
Bryan Housel
f800e5afbc Remove unnecessary window parameter to Context 2016-11-10 15:19:03 -05:00
Bryan Housel
b8be480267 Tests for loadFromAPI, esp to cover retry and dispatch behaviors 2016-11-09 17:59:07 -05:00
Bryan Housel
9845f0594e Don't rely on test side effects to init() osm service 2016-11-09 11:41:19 -05:00
Bryan Housel
16ada1f29a Better error handling for common osm api error conditions
* if 509 Bandwidth Exceeded / 429 Too Many Requests, prompt for login
(closes #2262)
* if 400 Bad Request / 401 Unauthorized / 403 Forbidden - logout and retry
(closes #3546)
2016-11-08 21:43:27 -05:00
Bryan Housel
73d7fca095 Test should logout after authenticating with test credentials 2016-10-31 15:04:46 -04:00
Bryan Housel
0066204cfa Fix tests for iD.Connection -> iD.services.osm 2016-10-25 21:33:13 -04:00
Bryan Housel
b5c95af3b7 Refactor from coreConnection to serviceOsm
(closes #3497)
2016-10-19 09:25:34 -04:00