Commit Graph

97 Commits

Author SHA1 Message Date
Martin Raifer 4c222fde0a make sure editing multi selection doesn't corrupt tags
because the common tag vs. left/right tag situation can be different for different entities in the multiselection, the approach to merge/split/update the tags needs to be made on a per entity basis

this introduces a new way to specify tag changes: a callback function which is called for each to be modified entity
2022-12-09 19:01:44 +01:00
Martin Raifer 78d37fd7a8 fix tooltip of "back/forward" buttons in preset list and entity editor 2022-11-01 18:32:47 +01:00
Martin Raifer 7d546a8f60 refactor further modules to not rely on html injection 2022-06-24 19:31:41 +02:00
Martin Raifer cc6f16d480 Merge branch 'develop' into accessible_ui 2021-12-07 16:22:01 +01:00
Martin Raifer b4bc7f49bb allow to change the key of a multi-valued tag
fixes #8836
2021-12-03 15:19:07 +01:00
Milos Brzakovic (E-Search) 30ef0b80e1 headings - more appropriate h2's and disclosure h3 2021-12-01 18:17:19 +01:00
Milos Brzakovic (E-Search) 7f1558624a forward, backward (expand, collapse) 2021-11-26 12:49:58 +01:00
Milos Brzakovic (E-Search) 4db3e720c0 close icon button 2021-11-26 12:25:12 +01:00
Quincy Morgan 4bb24b8f9e Fix issue with dragging node in between editing its tags (close #7606) 2020-11-09 09:49:01 -05:00
Quincy Morgan a0d4d01804 Minor styling fixes 2020-09-24 13:11:38 -04:00
Quincy Morgan 5435082d9c Revert t function to returning the plain string by default
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan 32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963)
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan bde604921b Fix lint warning 2020-09-13 16:00:21 -04:00
Quincy Morgan e0b81708b5 Remove sidebar key trap (close #7770) 2020-09-11 14:39:29 -04:00
Quincy Morgan 293971da34 Fix issue where inspector may not update correctly when switching between weak and fallback presets (close #7827) 2020-07-22 11:18:05 -04:00
Quincy Morgan 3d4703b60c Fix various CSS issues 2020-07-06 15:28:25 -04:00
Quincy Morgan 60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan 83d2656bbc Fix responsiveness issue when selecting features on iPad
Implement an alternative solution for #6028 that doesn't rely on timeouts
2020-03-04 13:10:15 -08:00
Quincy Morgan 2e238b8218 Fix JS error on clicking review request
Give different instances of the raw tag editor distinct classes and disclosure states
Correctly expand raw tags section by default when selecting a feature with a fallback preset
Fix raw tag editor tests
2020-02-26 14:51:32 -08:00
Quincy Morgan 6782947f5b Make inspector sections inherit from uiSection (re: #7368) 2020-02-21 15:22:54 -08:00
Quincy Morgan 13d8c078b4 Fix weak preset check 2020-02-03 13:58:34 -05:00
Quincy Morgan b4bc5305a1 Enable the issues section for multiple selected features (close #7324) 2020-02-03 12:17:14 -05:00
Quincy Morgan 1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Quincy Morgan c477950556 Re-add "zoom to this" button 2020-01-22 10:44:40 -05:00
Quincy Morgan fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan 6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan 14dba080b0 Fix inspector keytrap behavior 2020-01-20 13:55:06 -05:00
Quincy Morgan 48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan 232375cfc0 Fix sidebar state issues with adding and removing features from multiselection 2020-01-18 14:30:14 -05:00
Quincy Morgan eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan f6769238ed Revert references to the v3 UI in the Keyboard Shortcuts menu
Remove unused preset favoriting functionality
2019-12-20 12:05:04 -05:00
Quincy Morgan 3b671bf4e4 Flash the "change feature type" button in the inspector whenever the preset changes (close #6764) 2019-10-03 18:50:33 +02:00
Bryan Housel bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel 61819058d3 Avoid frequent reflow from setting scrollTop
(possibly re: #6289)
2019-05-02 14:21:57 -04:00
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel a3bc164c43 Redraw entity editor fields on addition, deletion too
This is important to make the turn restriction editor work
2019-04-23 01:07:38 -04:00
Bryan Housel 0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Quincy Morgan ae80c88f37 Render relation route icon lines dynamically (close #5926) 2019-04-08 19:58:50 -07:00
Bryan Housel 8d66289cba Run validation when switching fields, or when applying an issue fix 2019-04-07 23:10:20 -04:00
Bryan Housel 78acd999c8 WIP: switch from validating everything to validating differences 2019-04-05 13:29:57 -04:00
Bryan Housel 87e3b928d0 Reduce drawing during history changes
(closes #6086)
2019-04-03 23:26:26 -04:00
Bryan Housel cda8f657ac Swap fast-deep-equal for lodash isEqual
(re: #6087)
2019-03-29 22:17:29 -04:00
Bryan Housel 0edd10001e Removing more lodash: isEmpty, isNumber, some map/reduce/forEach
(re: #6087)
2019-03-27 13:32:35 -04:00
Bryan Housel 0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Quincy Morgan e6bc7efb7f Disallow favoriting of unsearchable presets
Rename preset favorite button class and file
2019-03-22 09:20:18 -04:00
Quincy Morgan b302d853ac Fix issue where the favorite preset button could be stale
Use first in, first out favoriting order
2019-02-27 13:13:15 -05:00
Brian Hatchl 1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Bryan Housel 81bd734849 WIP uiEntityIssues cleanups, simplify
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00