Commit Graph

209 Commits

Author SHA1 Message Date
Quincy Morgan d7e5aa6735 Keep track of the initial hash parameters through multiple loads of the UI (close #7504) 2020-04-14 14:03:18 -07:00
Quincy Morgan 417caba3be Fix issue where hashtags set in URL parameter would not be honored 2020-04-14 12:25:18 -07:00
Quincy Morgan 977d41ca14 Update lasso function names to use pointer instead of mouse 2020-04-05 17:33:22 -07:00
Quincy Morgan 8734b67821 Remove the context.intersects passthrough function 2020-04-01 15:36:53 -07:00
Quincy Morgan 0120b009fa Take a graph parameter in utilDisplayLabel instead of the context 2020-04-01 13:29:17 -07:00
Quincy Morgan 60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan a58abe3c6f Move localStorage interface from a property of coreContext to a corePreferences function 2020-04-01 11:00:48 -07:00
Quincy Morgan a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan a1a398650f Instantiate uiFlash only once as a property of the UI and remove global selection (re: #7445) 2020-03-29 10:22:58 -07:00
Quincy Morgan 5195d8d95b Don't use d3_mouse and cache client rect values as needed (close #7489) 2020-03-28 16:32:38 -07:00
Quincy Morgan 4a67e8c5dc Remove delay in opening the edit menu
Don't show the edit menu for multiple selected relations
Streamline edit menu code, replacing the confusing "suppressMenu" system
2020-03-26 12:48:30 -07:00
Quincy Morgan 62607e1e1d Fix issue where edit menu could not be opened by right-clicking on already selected feature 2020-03-25 16:10:24 -07:00
Quincy Morgan 21f8404deb Show change count in document title (close #6209)
Make title format translatable
Don't show lat/lon location in title
Select corresponding features upon hash change
2020-03-24 10:17:46 -07:00
Quincy Morgan f0cb8ffb25 Merge branch 'develop' into fix-history 2020-03-23 14:12:14 -07:00
Quincy Morgan eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan 6087aae21f Remove map convenience functions of context 2020-03-22 10:57:17 -07:00
Quincy Morgan 3c0b926ec7 Replace coreContext.geometry function with a more explicit coreGraph.geometry function 2020-03-21 14:23:44 -07:00
Quincy Morgan fac613e1dc Remove context.childNodes function 2020-03-21 13:56:11 -07:00
Quincy Morgan 5fd25601fe Convert map surface and supersurface from ids to classes 2020-03-21 13:41:06 -07:00
Quincy Morgan dd9c30beb1 Use pointer events instead of mouse events for lasso selection (re: #5505) 2020-03-13 13:23:06 -07:00
Quincy Morgan b5856e2415 Rewrite behaviorDrawWay to only always use one and only one temporary edit
Fix issues involving undoing while drawing ways
Prevent self-intersection when adding nodes to ways on touch devices (close #7423)
2020-03-11 17:48:09 -07:00
Quincy Morgan b86486c69f Flash error when cannot finish drawing self-intersecting area 2020-03-10 15:36:13 -07:00
Quincy Morgan 10f7ef2704 Add error feedback text when attempting to draw self-intersecting ways 2020-03-06 15:36:48 -08:00
Quincy Morgan 6ed66fb3ce Make drawing modes usable on touch devices 2020-03-06 15:17:11 -08:00
Quincy Morgan f8f69a777a Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128)
Support adding nodes to ways with double-tap with on touch devices (close #2677)
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
2020-03-06 12:46:26 -08:00
Quincy Morgan 83a51a4192 Use pointer events for node dragging and drawing (re: #5505)
Enable dragging nodes with touches and styluses (close #7415)
2020-03-05 15:18:39 -08:00
Quincy Morgan 83d2656bbc Fix responsiveness issue when selecting features on iPad
Implement an alternative solution for #6028 that doesn't rely on timeouts
2020-03-04 13:10:15 -08:00
Quincy Morgan c41e0b9937 Use pointer events for hovering and selecting data on supported platforms (re: #5505)
Fix issue where Apple Pencil stylus could not select map data (close #7396)
Fix issue where features could not be selected in a single tap on iPad (close #7380)
2020-03-04 12:18:43 -08:00
Bryan Housel dc7fba4bf8 Have utilStringQs advance past any leading '?' or '#' characters
This lets us remove a bunch of substring(1) and +1 from the code.
2020-02-20 17:09:54 -05:00
SilentSpike 51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Katarzyna Król 316872ef59 map location in title 2020-01-15 02:42:50 +01:00
Katarzyna Król 6286d1430f fix titles - single quotes 2020-01-15 01:50:07 +01:00
Katarzyna Król 91b67277bd update document title 2020-01-14 18:47:19 +01:00
Quincy Morgan ba59bdf23b Disable operations, copy, and paste during low-zoom selection 2019-12-23 10:33:16 -05:00
Quincy Morgan 523a467836 2.x: Make toolbar horizontally scrollable when it overflows (re: #6755, re: 7545f67063b5e7007ef2d8367e3181e59c04a487)
Generalize tooltip into popover control
Use the same popover control for tooltip as the preset browser and tools list popovers
Smartly position the preset browser popover and menu bar tooltips to stay fully onscreen
Position most tooltips closer to their controls
Fix small gap that could appear between a tooltip and its arrow
Allow wider toolbar tooltips
2019-12-16 13:30:07 -05:00
Quincy Morgan 91b6844377 Implement cleaner solution for removing breathe styling from deselected features 2019-12-13 13:16:29 -05:00
Quincy Morgan ff506fc332 Prevent partial rendering of selection style when showing only selected features at low zooms 2019-12-12 17:50:48 -05:00
Quincy Morgan 4b4ea122ad Fix performance issue where breathe behavior would be called for each selected element instead of just for the surface (close #3571) 2019-12-10 13:42:11 -05:00
Quincy Morgan eb49a367b4 Don't reuse changeset comment, sources, and hashtags from prior uploads (close #6642, re: #6279) 2019-07-22 16:12:20 -04:00
Bryan Housel 37557a7c98 Defer processing clicks in behaviorSelect
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
2019-05-01 14:47:29 -04:00
Bryan Housel d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel af45dbce10 Trying to avoid one-off validations when history changes will trigger it 2019-04-05 11:37:02 -04:00
Bryan Housel cda8f657ac Swap fast-deep-equal for lodash isEqual
(re: #6087)
2019-03-29 22:17:29 -04:00
Bryan Housel d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Bryan Housel 3896b2282f Remove lodash isNaN, isNumber, isString, bind, uniqBy
(re: 6087)
2019-03-27 23:11:45 -04:00
Bryan Housel 3d80e6505f Remove lodash chunk, groupBy
(re: #6087)
2019-03-27 16:18:41 -04:00
Quincy Morgan 67fc051632 Tweak newFeature in select mode 2019-03-26 16:34:23 -04:00
Bryan Housel 4821bf0a68 Remove lodash omit
(re: #6087)
2019-03-26 14:12:45 -04:00
Bryan Housel 1ce4f0ad6a Remove lodash without
(re: #6087)
2019-03-25 21:56:54 -04:00