Commit Graph

943 Commits

Author SHA1 Message Date
Bryan Housel d9015baa47 Improve links in KeepRight error messages
(re: #5679)

Also move the localizeable string dictionary to data/keepRight.json
2019-01-07 16:10:44 -05:00
Bryan Housel 4ed2858cc5 Explicitly include '?' as a fallback key for keyboard shortcuts
(closes #5675)

This allows for a localized version of the key,
but iD will still respond to the '?'
2019-01-07 11:39:12 -05:00
Bryan Housel 826f66a91b Unique values for key codes moved to utilKeybinding, uiShortcuts
This lets us supply lists of keys which might contain duplicates, but will be
made unique.  For example: [t('sidebar.key'), '`', '²']
'sidebar.key' may be one of the other choices, but will be deduplicated.
2019-01-07 11:12:24 -05:00
Bryan Housel 55d2dddb70 Keybind all of _uniq([t(sidebar.key), '`', '²']) to toggle sidebar
(closes #5663)
2019-01-06 00:33:35 -05:00
Minh Nguyễn 3c82174f03 Capitalize first letter of KeepRight error detail 2019-01-05 00:32:45 -08:00
Bryan Housel 7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel 35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel 46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel 9e6497b549 Update or remove the error after POSTing changes to server 2019-01-03 01:39:40 -05:00
Bryan Housel 69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel 4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel 9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel 192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel 4f0a608439 Merge pull request #5637 from openstreetmap/5618
fix autocomplete combobox bug
2018-12-26 15:15:29 -05:00
Yuri Astrakhan 9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Yuri Astrakhan 8b931f3e6c Use new message to encourage editing and translation 2018-12-22 15:03:22 -05:00
Bryan Housel 3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel 22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Bryan Housel f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel 7f669d292f Simplify KeepRight tile fetching code 2018-12-20 14:40:14 -05:00
Quincy Morgan 7c192a2e36 Fixed bug where the entity ID could not be found for the field 2018-12-20 12:25:35 -05:00
Quincy Morgan 97c2361f43 Changed initial sidebar screen for highway intersection vertices from preset list to editor 2018-12-20 10:17:16 -05:00
Bryan Housel 62547e3459 Merge pull request #5638 from openstreetmap/5612
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman 9a5a77f96c remove unneccessary space
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman 18c32511a2 remove member's highlight when removed from relation
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman 2dab19e9ae default to value() if neither d and choice are null in the accept function
ref #5618
2018-12-20 08:52:16 -05:00
Max Grossman 5a1dfeec72 open combobox if anywhere on box clicked...
ref #5596
2018-12-20 08:47:37 -05:00
Quincy Morgan cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Bryan Housel 2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey f4e71812ca added: help documentation 2018-12-19 13:45:35 -05:00
Thomas Hervey cedf6955b5 added: notes and todos for keepRight 2018-12-19 13:45:34 -05:00
Thomas Hervey fbe3c94b01 updated: punctuation, some specialized QA error parsing 2018-12-19 13:45:14 -05:00
Thomas Hervey d125c62c78 updated: variable and function names, html regex 2018-12-19 13:43:48 -05:00
Thomas Hervey e0d5391f1b added: entity links within descriptions 2018-12-19 13:43:48 -05:00
Thomas Hervey d095de08fe updated comment UI, added stub for POST; TODO: finish links & POST 2018-12-19 13:43:48 -05:00
Thomas Hervey b5a316df48 fixed: svg icon placement 2018-12-19 13:43:08 -05:00
Thomas Hervey 1335549ad3 cleaned map data UI; commented sub-layer filtering 2018-12-19 13:43:08 -05:00
Thomas Hervey 805dd394c9 added link for object in header 2018-12-19 13:40:56 -05:00
Thomas Hervey cbcdfc075c small UI change to header 2018-12-19 13:40:56 -05:00
Thomas Hervey 3e7146c63f WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons 2018-12-19 13:40:56 -05:00
Thomas Hervey 18278371aa WIP: identifying variables in errors 2018-12-19 13:38:40 -05:00
Thomas Hervey 31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Thomas Hervey b3cffd7833 added simple keepRight button under photoItems 2018-12-19 13:12:49 -05:00
Bryan Housel 81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel 7db6133666 Merge pull request #5583 from quincylvania/field-prerequisite-tags
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00