Quincy Morgan
60f7dc7c0b
Replace presets property of context with singleton
...
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
eed7944a1a
Replace various uses of d3_select and d3_selectAll with selection on the container
2020-03-22 12:34:06 -07:00
Quincy Morgan
83d2656bbc
Fix responsiveness issue when selecting features on iPad
...
Implement an alternative solution for #6028 that doesn't rely on timeouts
2020-03-04 13:10:15 -08:00
Quincy Morgan
2e238b8218
Fix JS error on clicking review request
...
Give different instances of the raw tag editor distinct classes and disclosure states
Correctly expand raw tags section by default when selecting a feature with a fallback preset
Fix raw tag editor tests
2020-02-26 14:51:32 -08:00
Quincy Morgan
6782947f5b
Make inspector sections inherit from uiSection (re: #7368 )
2020-02-21 15:22:54 -08:00
Quincy Morgan
13d8c078b4
Fix weak preset check
2020-02-03 13:58:34 -05:00
Quincy Morgan
b4bc5305a1
Enable the issues section for multiple selected features ( close #7324 )
2020-02-03 12:17:14 -05:00
Quincy Morgan
1b331bb678
Add mechanism for fields to support editing during multiselection (re: #7276 )
...
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Quincy Morgan
c477950556
Re-add "zoom to this" button
2020-01-22 10:44:40 -05:00
Quincy Morgan
fd2b97331c
Add label to "change feature type" button in inspector and make it a collapsible section ( close #6811 )
2020-01-22 09:19:54 -05:00
Quincy Morgan
6bb2997306
Enable changing the preset of multiple selected features (re: #7276 )
...
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan
14dba080b0
Fix inspector keytrap behavior
2020-01-20 13:55:06 -05:00
Quincy Morgan
48bda8ba67
Move selected feature list to a collapsible inspector section ( close #7273 )
2020-01-20 11:34:51 -05:00
Quincy Morgan
232375cfc0
Fix sidebar state issues with adding and removing features from multiselection
2020-01-18 14:30:14 -05:00
Quincy Morgan
eda51f6835
Add initial multiselection raw tag editing in 2.x
2020-01-17 17:49:26 -05:00
Quincy Morgan
f6769238ed
Revert references to the v3 UI in the Keyboard Shortcuts menu
...
Remove unused preset favoriting functionality
2019-12-20 12:05:04 -05:00
Quincy Morgan
3b671bf4e4
Flash the "change feature type" button in the inspector whenever the preset changes ( close #6764 )
2019-10-03 18:50:33 +02:00
Bryan Housel
bdb454e1b3
Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
...
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
61819058d3
Avoid frequent reflow from setting scrollTop
...
(possibly re: #6289 )
2019-05-02 14:21:57 -04:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
a3bc164c43
Redraw entity editor fields on addition, deletion too
...
This is important to make the turn restriction editor work
2019-04-23 01:07:38 -04:00
Bryan Housel
0a77a494aa
Merge branch 'master' into validation_and_change_perf
2019-04-10 14:22:20 -04:00
Quincy Morgan
ae80c88f37
Render relation route icon lines dynamically ( close #5926 )
2019-04-08 19:58:50 -07:00
Bryan Housel
8d66289cba
Run validation when switching fields, or when applying an issue fix
2019-04-07 23:10:20 -04:00
Bryan Housel
78acd999c8
WIP: switch from validating everything to validating differences
2019-04-05 13:29:57 -04:00
Bryan Housel
87e3b928d0
Reduce drawing during history changes
...
(closes #6086 )
2019-04-03 23:26:26 -04:00
Bryan Housel
cda8f657ac
Swap fast-deep-equal for lodash isEqual
...
(re: #6087 )
2019-03-29 22:17:29 -04:00
Bryan Housel
0edd10001e
Removing more lodash: isEmpty, isNumber, some map/reduce/forEach
...
(re: #6087 )
2019-03-27 13:32:35 -04:00
Bryan Housel
0e90167513
Remove lodash clone
...
(re: #6087 )
2019-03-22 23:18:25 -04:00
Quincy Morgan
e6bc7efb7f
Disallow favoriting of unsearchable presets
...
Rename preset favorite button class and file
2019-03-22 09:20:18 -04:00
Quincy Morgan
b302d853ac
Fix issue where the favorite preset button could be stale
...
Use first in, first out favoriting order
2019-02-27 13:13:15 -05:00
Brian Hatchl
1faa6ad839
Favorite preset
2019-02-20 15:23:58 -05:00
Bryan Housel
81bd734849
WIP uiEntityIssues cleanups, simplify
...
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Bryan Housel
20bcfc5730
Delimit name-suggestion-preset names on en-dash, not hyphen
...
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Quincy Morgan
4f1cb0dc46
Made the entity issues UI update when the issues reload
2019-01-14 12:33:32 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
6efbbb8aa3
Add "zoom to this" quicklink and keybind for note editor
...
(closes #5169 )
2019-01-09 22:24:52 -05:00
Bryan Housel
9c190e83e9
Add quickLinks to preset editor, zoom to selected feature
2019-01-09 21:56:08 -05:00
Bryan Housel
5c6406ea63
Remove section borders from inspector
...
There is enough separation with the disclosure headings that we
don't need to break the sidebar up with lines
2019-01-08 14:04:07 -05:00
Quincy Morgan
490143d1a8
Added Issues section to the entity sidebar
...
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Max Grossman
d8de9e785e
do not add found presets to recent
2018-12-17 14:56:33 -05:00
Max Grossman
74a19a6d7f
remove a comment
2018-12-17 12:55:00 -05:00
Max Grossman
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
Max Grossman
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
Bryan Housel
39b3f1df68
Avoid creating comboboxes
...
(closes #5568 )
Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
c7fc3ea062
Reset the scroll to the top of the inspector when redrawing it
2018-11-30 14:21:14 -05:00
Bryan Housel
822917466c
Display name suggestion presets on 2 lines
...
(closes #5514 )
2018-11-26 21:55:13 -05:00
Max Grossman
2bf5eaf6e7
initial plumbing for iD validation errors
...
ref #remote-presets
2018-07-31 14:22:34 -04:00