Commit Graph

304 Commits

Author SHA1 Message Date
Peter Newman
4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan
40e46aced1 Fix issue where following a node and then selecting another feature would auto-center the feature (close #7820) 2020-07-22 09:58:14 -04:00
Quincy Morgan
60a0856d12 Fix issue where preset list search would get autofocus unexpectedly 2020-07-06 16:07:51 -04:00
Quincy Morgan
875a45e884 Move copy feature menu item to be right before delete/downgrade (re: #2508) 2020-06-26 13:43:42 -04:00
Quincy Morgan
9010fb9535 Revert "Only update selection styling for full redraws (re: #7706)"
This reverts commit f53cce783a.
2020-06-17 15:15:41 -04:00
Quincy Morgan
e790525903 Remove unneeded full redraw upon entering modeSelect 2020-06-16 13:41:45 -04:00
Quincy Morgan
f53cce783a Only update selection styling for full redraws (re: #7706) 2020-06-16 13:14:06 -04:00
Quincy Morgan
61b3aaafd2 Autofocus new note descriptions in the UI code instead of the mode code (re: #7680) 2020-06-08 11:42:29 -04:00
Quincy Morgan
c85fbf34f9 Underscore function scope variables in modeSelectNote 2020-06-08 10:30:04 -04:00
Quincy Morgan
def3a373a7 Autofocus the comment field when adding a new OSM note (close #7680) 2020-06-08 10:26:16 -04:00
Quincy Morgan
38db23fab5 Extend behaviorHover to support multiple pointers 2020-05-27 15:07:23 -04:00
Quincy Morgan
cb5365f743 Persist down pointer multiselection between browse/select mode transitions 2020-05-27 12:33:53 -04:00
Quincy Morgan
5b399623e9 Enable multiselection on touch devices when tapping on features with a pointer already down on a selected feature (close #7590)
Reuse modeSelect when changing entity selection if possible
2020-05-26 17:21:48 -04:00
Jacob Scherber
e8233247d3 add highlight to multi-select hover 2020-05-23 15:06:58 -07:00
Quincy Morgan
869a0c6b89 Make the draw modes reuse their behaviorDraw when re-entering
Move click-end-node-to-finish functionality from draw modes to behaviorDraw
Fix issue where the head node would get hover-highlighted when continuing from the end of a line
2020-05-22 15:05:35 -04:00
Quincy Morgan
a0ae1bf1de Prevent nudging the selection during low-zoom editing 2020-05-19 12:11:03 -04:00
Quincy Morgan
311566328e Enable nudging the selection via shift+arrow keys and shift+command+arrow keys to nudge more (close #7186)
No longer nudge the viewport with shift+arrow keys
2020-05-19 12:08:14 -04:00
Quincy Morgan
7b09b6c0dc Enable low-zoom display of focused feature when resolving conflicts (close #7330) 2020-05-18 17:14:50 -04:00
Quincy Morgan
db9eed2434 Move the edit menu logic to uiInit
Make context the first argument of operation objects
Add Paste operation to edit menu when opening the context menu on a blank area of the map (close #2508)
2020-05-14 15:49:35 -04:00
Quincy Morgan
a0ad92e6e0 Always show the edit menu at the location of the triggering event 2020-05-14 12:32:43 -04:00
Quincy Morgan
dff4268256 Allow selection, deselection, and multiselection with the spacebar (re: #3843)
Don't open the edit menu on single spacebar press
Open the edit menu for long spacebar press (re: #7577)
2020-05-14 11:19:20 -04:00
Quincy Morgan
0278e700a0 Convert feature copying functionality from a standalone behavior to an operation and add to edit menu (re: #2508)
Show flash feedback message when copying features with keyboard shortcut
Disallow copying of untagged vertices
2020-05-13 15:42:28 -04:00
Quincy Morgan
23714ba822 Position the edit menu above the anchor point if triggered via touch or stylus (re: #7577)
Add additional code safety to behaivorSelect
2020-05-12 18:42:36 -04:00
Quincy Morgan
95dc16b7a6 Update more mouse events to use pointer events if available (re: #5505) 2020-05-08 16:10:15 -07:00
Quincy Morgan
77061e9c6c Fix lint warnings 2020-05-08 09:42:02 -07:00
Quincy Morgan
7a3a84b7b2 Remove broken "tail" functionality (close #7560) 2020-05-07 10:26:50 -07:00
Quincy Morgan
60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a1a398650f Instantiate uiFlash only once as a property of the UI and remove global selection (re: #7445) 2020-03-29 10:22:58 -07:00
Quincy Morgan
4a67e8c5dc Remove delay in opening the edit menu
Don't show the edit menu for multiple selected relations
Streamline edit menu code, replacing the confusing "suppressMenu" system
2020-03-26 12:48:30 -07:00
Quincy Morgan
37b1f35ab4 Properly switch the edit menu tooltip side depending on space 2020-03-25 15:34:02 -07:00
Quincy Morgan
13c8753c11 Reuse the uiEditMenu instead of recreating it every time the operations change 2020-03-25 14:49:24 -07:00
Quincy Morgan
5c2a96dedb Fix issue where the edit menu would not disappear sometimes (close #7143)
Properly disable dragging the map under the edit menu for pointer events (re: #5505)
2020-03-25 14:33:42 -07:00
Quincy Morgan
9731b93cec Move uiTooltipHtml functionality into uiTooltip
Refactor uiEditMenu to use standard UI patterns instead of SVG
2020-03-25 12:22:10 -07:00
Quincy Morgan
0931459dba Reduce use of global selection (re: #7445) 2020-03-24 13:02:06 -07:00
Quincy Morgan
eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan
6087aae21f Remove map convenience functions of context 2020-03-22 10:57:17 -07:00
Quincy Morgan
3c0b926ec7 Replace coreContext.geometry function with a more explicit coreGraph.geometry function 2020-03-21 14:23:44 -07:00
Quincy Morgan
fac613e1dc Remove context.childNodes function 2020-03-21 13:56:11 -07:00
Quincy Morgan
f2a687f68b Convert container from id to class 2020-03-20 15:08:56 -07:00
Quincy Morgan
c893147e15 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:53:17 -07:00
Quincy Morgan
152d89fa22 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:10:39 -07:00
Quincy Morgan
9eb694faec Remove radial menu 2020-03-13 13:29:46 -07:00
Quincy Morgan
b5856e2415 Rewrite behaviorDrawWay to only always use one and only one temporary edit
Fix issues involving undoing while drawing ways
Prevent self-intersection when adding nodes to ways on touch devices (close #7423)
2020-03-11 17:48:09 -07:00
Quincy Morgan
ece7eb0850 Add self-intersection error message when dragging vertices 2020-03-09 14:52:17 -07:00
Quincy Morgan
10f7ef2704 Add error feedback text when attempting to draw self-intersecting ways 2020-03-06 15:36:48 -08:00
Quincy Morgan
f8f69a777a Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128)
Support adding nodes to ways with double-tap with on touch devices (close #2677)
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
2020-03-06 12:46:26 -08:00
Quincy Morgan
83a51a4192 Use pointer events for node dragging and drawing (re: #5505)
Enable dragging nodes with touches and styluses (close #7415)
2020-03-05 15:18:39 -08:00
Quincy Morgan
5e8d84ec33 Fix eslint warning 2020-03-02 15:58:30 -08:00
Quincy Morgan
abf536aa9b Make commit changes its own collapsible section 2020-02-24 14:03:06 -08:00