CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
13,657 Commits 2 Branches 0 Tags
57263e07604fb6e6700a59f4e2474efdf32a5b5e
Commit Graph

113 Commits

Author SHA1 Message Date
Peter Newman
4205ca1d07 Fix the seemingly safe spellings found by codespell 
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
 2020-08-10 17:32:37 +01:00
Quincy Morgan
40e46aced1 Fix issue where following a node and then selecting another feature would auto-center the feature (close #7820) 2020-07-22 09:58:14 -04:00
Quincy Morgan
60a0856d12 Fix issue where preset list search would get autofocus unexpectedly 2020-07-06 16:07:51 -04:00
Quincy Morgan
875a45e884 Move copy feature menu item to be right before delete/downgrade (re: #2508) 2020-06-26 13:43:42 -04:00
Quincy Morgan
9010fb9535 Revert "Only update selection styling for full redraws (re: #7706)" 
This reverts commit f53cce783a.
 2020-06-17 15:15:41 -04:00
Quincy Morgan
e790525903 Remove unneeded full redraw upon entering modeSelect 2020-06-16 13:41:45 -04:00
Quincy Morgan
f53cce783a Only update selection styling for full redraws (re: #7706) 2020-06-16 13:14:06 -04:00
Quincy Morgan
cb5365f743 Persist down pointer multiselection between browse/select mode transitions 2020-05-27 12:33:53 -04:00
Quincy Morgan
5b399623e9 Enable multiselection on touch devices when tapping on features with a pointer already down on a selected feature (close #7590) 
Reuse modeSelect when changing entity selection if possible
 2020-05-26 17:21:48 -04:00
Jacob Scherber
e8233247d3 add highlight to multi-select hover 2020-05-23 15:06:58 -07:00
Quincy Morgan
a0ae1bf1de Prevent nudging the selection during low-zoom editing 2020-05-19 12:11:03 -04:00
Quincy Morgan
311566328e Enable nudging the selection via shift+arrow keys and shift+command+arrow keys to nudge more (close #7186) 
No longer nudge the viewport with shift+arrow keys
 2020-05-19 12:08:14 -04:00
Quincy Morgan
db9eed2434 Move the edit menu logic to uiInit 
Make context the first argument of operation objects
Add Paste operation to edit menu when opening the context menu on a blank area of the map (close #2508)
 2020-05-14 15:49:35 -04:00
Quincy Morgan
a0ad92e6e0 Always show the edit menu at the location of the triggering event 2020-05-14 12:32:43 -04:00
Quincy Morgan
dff4268256 Allow selection, deselection, and multiselection with the spacebar (re: #3843) 
Don't open the edit menu on single spacebar press
Open the edit menu for long spacebar press (re: #7577)
 2020-05-14 11:19:20 -04:00
Quincy Morgan
0278e700a0 Convert feature copying functionality from a standalone behavior to an operation and add to edit menu (re: #2508) 
Show flash feedback message when copying features with keyboard shortcut
Disallow copying of untagged vertices
 2020-05-13 15:42:28 -04:00
Quincy Morgan
23714ba822 Position the edit menu above the anchor point if triggered via touch or stylus (re: #7577) 
Add additional code safety to behaivorSelect
 2020-05-12 18:42:36 -04:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406) 
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
 2020-03-31 12:23:31 -07:00
Quincy Morgan
4a67e8c5dc Remove delay in opening the edit menu 
Don't show the edit menu for multiple selected relations
Streamline edit menu code, replacing the confusing "suppressMenu" system
 2020-03-26 12:48:30 -07:00
Quincy Morgan
37b1f35ab4 Properly switch the edit menu tooltip side depending on space 2020-03-25 15:34:02 -07:00
Quincy Morgan
13c8753c11 Reuse the uiEditMenu instead of recreating it every time the operations change 2020-03-25 14:49:24 -07:00
Quincy Morgan
5c2a96dedb Fix issue where the edit menu would not disappear sometimes (close #7143) 
Properly disable dragging the map under the edit menu for pointer events (re: #5505)
 2020-03-25 14:33:42 -07:00
Quincy Morgan
9731b93cec Move uiTooltipHtml functionality into uiTooltip 
Refactor uiEditMenu to use standard UI patterns instead of SVG
 2020-03-25 12:22:10 -07:00
Quincy Morgan
0931459dba Reduce use of global selection (re: #7445) 2020-03-24 13:02:06 -07:00
Quincy Morgan
6087aae21f Remove map convenience functions of context 2020-03-22 10:57:17 -07:00
Quincy Morgan
3c0b926ec7 Replace coreContext.geometry function with a more explicit coreGraph.geometry function 2020-03-21 14:23:44 -07:00
Quincy Morgan
fac613e1dc Remove context.childNodes function 2020-03-21 13:56:11 -07:00
Quincy Morgan
9eb694faec Remove radial menu 2020-03-13 13:29:46 -07:00
Quincy Morgan
f8f69a777a Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events 
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128)
Support adding nodes to ways with double-tap with on touch devices (close #2677)
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
 2020-03-06 12:46:26 -08:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
7ca9f55d43 2.x: Don't render multipolygon members in yellow when the multipolygon is selected (re: #6558, re: 4ab97128c4aae04b627cf8f19091c6c0fc1cf5bc) 2019-12-13 14:19:15 -05:00
Quincy Morgan
91b6844377 Implement cleaner solution for removing breathe styling from deselected features 2019-12-13 13:16:29 -05:00
Quincy Morgan
61f0a670db Correctly remove yellow member highlight when removing member from select relation (close #6772) 
Don't exit select mode when panning selected feature out of view
Return false when checking selected IDs and switching between single and multiselect in modeSelect
 2019-12-13 12:07:43 -05:00
Quincy Morgan
7473d32e31 2.x: Highlight relation members in yellow when a relation is selected, including in a multi-selection (re: #5766, re: cf2935576511a1b9f5aac47407ed2b0ce803902a) 2019-12-13 11:20:40 -05:00
Quincy Morgan
9920c7dd1d Fix typo in comment 2019-12-13 11:10:09 -05:00
Quincy Morgan
e352d425e9 Prevent opening edit menu in wide selection 2019-12-13 11:06:36 -05:00
Quincy Morgan
827c8034d5 Enable zoom-to-center of multiple selected entities (close #6696) 2019-12-13 10:30:00 -05:00
Quincy Morgan
ff506fc332 Prevent partial rendering of selection style when showing only selected features at low zooms 2019-12-12 17:50:48 -05:00
Quincy Morgan
912151ff38 Allow viewing and editing the tags/relations of selected features at any zoom level in 2.x (re: #5001) 2019-12-12 16:54:16 -05:00
Quincy Morgan
9aa27f68c3 Fix stale UI when undoing/redoing between single and multiselections (re: #7090) 2019-12-10 10:07:05 -05:00
Quincy Morgan
08530dd822 Prevent stale operations by reloading them after history changes 2019-10-03 16:57:12 +02:00
Quincy Morgan
16bc43b00e Clear hover-highlighting when exiting modeSelect 2019-08-22 15:49:28 -05:00
Bryan Housel
d7a569c425 Merge branch 'defer-select-for-6028' 2019-05-01 14:49:31 -04:00
Quincy Morgan
907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel
d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan
6eeaf94076 Show members of selected relations even when their feature layer is otherwise hidden (close #6220) 2019-04-24 17:28:56 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Bryan Housel
81127d71f3 Cache disabled() results in straighten action for consistent response 
What could happen was:
- user could right click on a line
- this would trigger `disabled()` checks for each operation buttons
- the line was not fully downloaded, so would return `disabled()` 'not_downloaded'
  (and also start download of the missing tiles)
- then the tooltip would pop into existence, calling `tooltip()`
- which calls `disabled()` again
- but this time it's fine and the `disabled()` is false
- so you'd see a greyed out button but the tooltip said everyting is ok and
  you can click the button anyway

I fixed this by just caching the disabled test.  This is probably ok anyway
because these tests can be expensive, and then the user will see a consistent
message like "The line is not yet fully downloaded".

If the user clicks off the line and back onto it, iD will reenter select mode,
rebuild the menu, redo the disabled test, and they will see the button enabled.
 2019-04-10 10:19:23 -04:00
Quincy Morgan
9d029a37a8 Delete newly-created untagged relations when deselecting them (close #3812) 2019-04-07 13:39:51 -07:00