Commit Graph

185 Commits

Author SHA1 Message Date
Bryan Housel
c635389c1a Fix handling of semicolon delimited values in numeric field
(closes #5438)
2018-12-12 01:11:34 -05:00
Bryan Housel
39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
ff646fa2c8 Dispatch a 'cancel' event if the user hits escape 2018-12-11 00:09:55 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
d574bfcd77 Disable autocomplete on the localized field
(closes #5558)
2018-12-07 17:19:02 -05:00
Bryan Housel
247900f727 Change several of the event things, remove numeric index
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
2018-12-07 16:54:32 -05:00
Bryan Housel
8b2e5c98bd Fix tests - test for _entity before using it 2018-12-02 01:46:35 -05:00
Bryan Housel
0a286bbd9d Lock name field when there is a wikidata tag
(re: #5515)
2018-12-02 00:14:51 -05:00
Bryan Housel
f559fc57bb Silly code formatting stuff, remove unused .entity() accessor
- prefix state variables with a _
- var on each line
2018-12-01 21:51:08 -05:00
Quincy Morgan
55c47021fa Fixes Wikidata field lint errors 2018-12-01 18:14:51 -08:00
Quincy Morgan
afcc474d3c Wikidata entity labels and descriptions are now fetched and displayed in the field, if present 2018-12-01 17:39:16 -08:00
Quincy Morgan
a28147aea2 Updates Wikidata field for the latest field flexbox changes
Adds an Identifier label to the Wikidata QID input
2018-12-01 13:16:41 -08:00
Quincy Morgan
3643877be6 Merge branch 'master' into wikidata-field 2018-12-01 11:57:09 -08:00
Quincy Morgan
b0dccc81de Condenses CSS for access, cycleway, and structure field lists 2018-12-01 11:55:21 -08:00
Bryan Housel
8b0e729b9c Merge pull request #5502 from jguthrie100/redraw_restrictions_on_sidebar_drag
Redraw restrictions panel when dragging sidebar
2018-11-30 01:30:03 -05:00
Bryan Housel
50d204866b Flexbox the raw member, membership controls, finish tag editor 2018-11-29 22:31:58 -05:00
Bryan Housel
d0612ba519 Fix css for address and wikipedia fields, fix hover styles 2018-11-28 23:20:52 -05:00
Bryan Housel
958d7fac4f wip changing all fields to use flexbox everywhere 2018-11-28 18:15:38 -05:00
Bryan Housel
0b98811377 Avoid multiline variable declaration 2018-11-27 11:22:13 -05:00
Bryan Housel
4533603a88 preset-input-wrap -> form-field-input-wrap
This better describes what it does.
Also, took this opportunity to update a bunch of the uifield code
(no multi line variable declarations, prefix state variables with _,
eliminate unnecessray lodash, etc)
2018-11-27 10:54:03 -05:00
Bryan Housel
986b663c9e Get rid of extra form-label-button-wrap div
Buttons can now be directly appended to the form-field-label flex container
2018-11-27 09:14:11 -05:00
Bryan Housel
7170e93b39 Adjust tooltip 2018-11-26 17:35:38 -05:00
Bryan Housel
df91eb2959 Cleanup style, make sure multilingual fields always render 2018-11-26 17:13:55 -05:00
Bryan Housel
9341e477a6 Merge remote-tracking branch 'origin/master' into brand-name-protection 2018-11-26 15:27:56 -05:00
Bryan Housel
f6f146f79b Lock down some fields when a brand preset has been chosen 2018-11-26 15:13:40 -05:00
J Guthrie
82bc803bb0 Lower redraw threshold to 1px 2018-11-26 01:43:51 +00:00
Bryan Housel
ae063e9616 Make name and brand fields readonly on suggestion presets
(re #5515)
2018-11-23 23:44:52 -05:00
Quincy Morgan
e2b2649976 Merge pull request #5498 from quincylvania/form-field-flexbox
Flexbox preset field, member, and membership UI
2018-11-21 20:14:36 -05:00
Bryan Housel
ea9e3008a5 addTags() -> setTags() / removeTags() -> unsetTags()
This avoids overriding the `addTags` and `removeTags` objects with functions
2018-11-21 12:59:43 -05:00
Bryan Housel
2699418c3e Disable the name field when matching a suggestion preset
(re: #5515)
2018-11-21 12:40:12 -05:00
Bryan Housel
622621ca89 Improve suggestion combo behavior in the name field
- adds minItems(1) so it will match
- displays up to 10 suggestions
- correctly removes old tags by setting the `undefined`
- adjust the name distance scoring
- only shows name suggestions if the preset can benefit from them
  (i.e. a generic/fallback or a preset that has some suggestions in the index)
2018-11-21 11:15:03 -05:00
J Guthrie
7bf4c462e8 Lowered redraw threshold to 2px 2018-11-21 09:25:30 +00:00
J Guthrie
c002ab8b1d Only redraw restrictions panel every 10px sidebar is dragged 2018-11-21 09:05:33 +00:00
Bryan Housel
e3f5aecda9 Remove dataSuggestions and utilSuggestNames
- dataSuggestions was just a reexport of the name-suggestion-index
- utilSuggestNames was a combobox fetcher function used only once by uiFieldLocalized
    Doesn't need to be a util if it's only used once in the code
    and the tests for it were not really that interesting
2018-11-20 21:27:32 -05:00
J Guthrie
5fc312620f Converted to using custom Event 2018-11-20 18:39:00 +00:00
J Guthrie
6137941efd Redraw restrictions panel when dragging sidebar 2018-11-19 15:23:30 +00:00
Quincy Morgan
82263aea7c Adds a Wikidata field 2018-11-18 19:38:19 -05:00
Quincy Morgan
7bad67ff76 Flexbox preset field, member, and membership UI 2018-11-18 11:28:48 -05:00
Bryan Housel
4a3d5e2316 Avoid reflow caused by restriction editor checking its dimensions 2018-11-10 00:40:45 -05:00
Bryan Housel
3bc841e95b Adjust layer ordering to draw touch targets above data layers 2018-11-09 21:48:45 -05:00
Quincy Morgan
cd8be8b5b4 Adds presets for Traffic Sign, Speed Limit Sign, and City Limit Sign, each with point/vertex variants to account for different direction fields
Makes the maxspeed field compatible with node entities
2018-09-26 19:35:44 -07:00
Bryan Housel
71592f3c72 Treat multicombo values other than 'no' and '' as if they are set
And don't set a multicombo value to 'yes' if it already has a non-'no' value
(closes #5291)
2018-09-04 17:31:46 -04:00
Bryan Housel
91872d72f8 Code formatting, replace regex match with test
(minor point, but `test` is much faster when you just want a boolean result)
2018-09-04 16:16:34 -04:00
Bryan Housel
121287fe97 Support access=permit in access and access_simple fields
(closes #5223)
2018-08-13 15:03:57 -04:00
J Guthrie
c1bdcf24aa Changed parseInt to parseFloat 2018-08-03 01:33:29 +01:00
Bryan Housel
5555b61e87 Fix bug causing 0 to be written into a numeric field when tabbing
(closes #5087)
2018-06-17 11:51:51 -04:00
Bryan Housel
470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
7ae8c9f6a7 Make min/max field values work for inputted values also
(previous commit only worked for the up/down buttons)
2018-06-02 12:19:43 -04:00
Bryan Housel
861299bb1c Support minValue/maxValue on numeric fields
Configure most numeric fields to avoid negative values
(closes #5043)
2018-06-02 11:11:15 -04:00