Commit Graph

4745 Commits

Author SHA1 Message Date
Martin Raifer ee56b9c8ae render closed amenity=bicycle_parking ways as areas by default
fixes https://github.com/openstreetmap/id-tagging-schema/issues/1114#issuecomment-2018057194
2024-03-26 15:19:35 +01:00
Hirako 85278c35e4 Field: fix wikiURL by URL encoding it - and slight refactors (#10165)
* Field: fix wikiURL by URL encoding it - and slight refactors

* Field: fix wikiURL only encodeURIComponent instead of redundant full URL

* Field: refactors function to generate wikiURL, ensures anchor part is also URI encoded, ensures the anchor ref is not encoded, adds unit tests

* Field: refactors wikipedia URI encoding of the anchor logic, removes legacy anchorencode effort via try-catch that replaced percentage character with dots, adds unit further  tests, reduces exessive inlining
2024-03-21 00:42:08 -07:00
Martin Raifer 12b0528175 Upgrade closed ways with traffic_calming=island to area:highway=traffic_calming
addresses missing pieces for https://github.com/openstreetmap/id-tagging-schema/issues/1162
2024-03-15 21:12:31 +01:00
Asif Sheriff 1683313621 preserve rows with empty tag values in raw tag editor (#10151) 2024-03-15 01:13:07 +01:00
Martin Raifer 444c5835c9 hide forward/back button if there is no matching image
e.g. for the first/last photo in a sequence, or when there are gaps
2024-03-08 10:59:34 +01:00
Mattia Pezzotti a75eace135 Fix for Point Tutorial (#10129) 2024-03-07 23:38:51 +01:00
Martin Raifer 5d06d3b83e Merge pull request #10149 from openstreetmap/split-relation-members
Robust local splitting of ways which are part of (route) relations
2024-03-06 13:54:14 +01:00
Martin Raifer 20f53e5748 document algorithm inline, handle "junction=circular" like roundabouts 2024-03-06 13:46:22 +01:00
Martin Raifer d7aca27f41 minor code readibility refactoring 2024-03-05 17:20:04 +01:00
Martin Raifer d7111e20f5 add button to load a feature's relations fully (if incomplete), fixes #5420 2024-03-05 14:25:16 +01:00
Martin Raifer 296ce859cf allow splitting of closed roundabout for certain rel types 2024-03-05 14:23:02 +01:00
Martin Raifer 13d46b0578 typo 2024-03-04 23:37:29 +01:00
Tobias b72a089f35 Field: Fix html tag type of wikidata label (#10144)
The `span` need to be a `div` after https://github.com/openstreetmap/iD/pull/10127/files
2024-03-04 19:25:53 +01:00
Martin Raifer 82af60115d disalow splitting of closed roundabouts when they are part of a route
these cases are not covered by the splitting algorithm at the moment:
* typicall, only a part of the roundabout should be part of the resulting route
* when multiple routes meet at a roundabout coming from different angles, the roundabout must be split at any of those entry/exit point simutaneously, such that all routes remain correct

as a workaround, a mapper can remove the route relation(s) from the roundabout, split it accordingly and then re-add the respective parts to the relation(s) again.
2024-03-04 19:02:33 +01:00
Martin Raifer 7268a8538c handle closed roundabout ways like a single junction "point" 2024-03-04 19:02:32 +01:00
Martin Raifer 088db7ccc1 simplify boolean conditions 2024-03-04 19:02:32 +01:00
Martin Raifer 11dfbe804c fix splitting of (route) relation member ways
instead of fully re-sorting the whole relation every time a member is split, perform a local operation: This works under the assumption that the relation is already sorted properly. The new way is inserted into the relation before or after the existing member, depending on how the old/new way connect to their neighboring members.

for cases where two ways form a loop, a additional look-ahead is implemented to disambiguate the order
2024-03-04 19:02:31 +01:00
Martin Raifer cc920d3fba drop unused var 2024-03-02 15:43:56 +01:00
Martin Raifer 97442403cf drop validator which checks for old style multipolygons
these have long been [fixed](https://blog.jochentopf.com/2017-08-28-polygon-fixing-effort-concluded.html) in OSM

see wiki: https://wiki.openstreetmap.org/wiki/Old_style_multipolygons
2024-02-29 13:28:22 +01:00
Martin Raifer 8274384311 Fix validator suggesting to add empty *:wikipedia tags to NSI presets (fixes #10140) 2024-02-29 10:30:18 +01:00
Martin Raifer 075b881978 Merge remote-tracking branch 'mtmail/mutually-exclusive-tags-validator' into develop 2024-02-26 14:11:14 +01:00
Tobias ce51b33cf2 Improve combobox dropdown styling to give labels more room and readability (#10127)
* Fields: Break long lines in combo dropdown instead of ellipsis

Longer translations keys are not readable with ellipsis and the tooltip only shows the description (or fallback), not the title.

This change makes long use line breaks with small line height to make the whole text visible.

* Fields: Use table styles for rows to maximize available space

The flex box solution gave a lot of space to the label. This solution minimizes that space to give more space to the values dropdown.
2024-02-26 14:02:22 +01:00
marc tobias 277b5d4f45 new validator: mutually exclusive tags 2024-02-25 18:40:10 +01:00
Martin Raifer 85f4cc0316 don't reverse side tag of highway=cyclist_waiting_aid features, fixes #10128 2024-02-25 15:36:17 +01:00
Martin Raifer 96e6dc124f Show message about how to support OSM after a successful save, closes #10054
for example in form of a donation

this can be disabled by setting an env variable (`ID_SHOW_DONATION_MESSAGE=false`)

the icon is from https://uxwing.com/charity-donation-hand-love-icon/
2024-02-24 12:48:35 +01:00
Martin Raifer 17d1c27bec use https for Bing Maps API 2024-02-16 23:19:30 +01:00
Martin Raifer 83754e4a4a switch to Bing Maps API for Bing Streetside layer, fixes #10074
replaces the use of undocumented APIs for Microsoft's street level imagery service and gets rid of hardcoded values, e.g. for the `g` ("generation") parameter

see https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#get-streetside-metadata-centered-at-a-point for API docs

see also #10100
2024-02-16 18:29:23 +01:00
Martin Raifer 4829f8a1da drop *:wikipedia tags when selecting a NSI-based, fixes #9103 2024-02-16 14:32:58 +01:00
NaVis0mple 01d650d450 Expand DMS format and fix sec rounding logic (#10066)
Most DMS format parsed by @mapbox/sexagesimal, 
add a expandable matcher and two new formats for coordinates in DMS format in search bar

example: `35 11 10.1 , 136 49 53.8` (D M SS format), or `35 11.168 , 136 49.896` (D MM format)
2024-02-02 15:26:47 +01:00
Martin Raifer aaf89d7755 don't duplicate notes which have already been seen 2024-01-24 15:16:12 +01:00
Martin Raifer b00a7e31ec don't consider traffic_calming features as areas
prerequisite for https://github.com/openstreetmap/id-tagging-schema/pull/1076
2024-01-24 13:48:29 +01:00
NaVis0mple 59668638ac Search OSM notes by ID (#10062) 2024-01-24 13:32:35 +01:00
Max Langer 5c7432b345 Add rendering for roller_coaster=track and roller_coaster=support (#9891) 2023-12-15 16:14:20 +01:00
Martin Raifer bb17d5c24e Merge pull request #10002 from k-yle/9876-multiple-values-empty
show empty tag values in multi-selections
2023-12-06 14:18:31 +01:00
Martin Raifer f65ca4c342 use tag value as display text in raw tag editor 2023-12-06 14:03:47 +01:00
Martin Raifer 0d69c3c9e8 style "(empty)" option differently to distinguish from regular tag values 2023-12-06 13:56:45 +01:00
Ramith Kulal 179fa71cdf Fix cursor on foreign link field links, fixes #9992 2023-12-06 13:03:26 +01:00
Martin Raifer edb176f513 Rerender local photos when last local photo is removed from list 2023-12-06 12:51:46 +01:00
Excitable Snowball 4bf79e9f1a Sanitize Amazon CloudFront signature in imagery_used (#10007) 2023-12-06 12:40:15 +01:00
Kyℓe Hensel c976b9f7f4 show date/time for georeferenced photos (#9990) 2023-12-06 12:08:13 +01:00
Kyle Hensel a876aa010c show empty tag values in multi-selections 2023-11-25 21:54:08 +13:00
Martin Raifer ea47581bae show turn restriction editor also when there is only one _to_ way, fixes #9983
as there might exist turn restrictions with that way as _via_.
2023-11-22 16:39:47 +01:00
Martin Raifer ac172a2b0e Don't autocomplete tags like name_1 in raw tag editor, closes #9422 2023-11-17 14:04:24 +01:00
Martin Raifer d4bfbaaf4a Merge branch 'relation-colours' into develop 2023-11-17 13:53:19 +01:00
Martin Raifer 20b72a2b68 only render route colours if the value is a valid color
addresses https://github.com/openstreetmap/iD/pull/9424#discussion_r1046495633
2023-11-17 13:47:16 +01:00
Martin Raifer 9cc04d3f0b fix spelling mistakes 2023-11-14 11:26:36 +01:00
Martin Raifer beea585251 Merge branch 'develop' into relation-colours 2023-11-14 10:02:55 +01:00
Kyℓe Hensel 3b24932bda fix highway=busway not supported in the turn restriction editor (#9633) 2023-11-14 09:53:23 +01:00
mxxcon 87819ed53f Adds nycdoitt:bin tag to list of tags to keep on building
When extracting a POI from a building or downgrading a building, this update keeps nycdoitt:bin= tag with the building, not extracts it to the node or deletes it.

resolves #8539
2023-11-14 09:42:32 +01:00
Martin Raifer 87a05f5815 migrate to osm-auth 2.3 2023-11-14 08:13:44 +01:00