Quincy Morgan
5e4e2ff7ee
Fix an issue where stale warning counts would still appear in changeset tags if they had all been resolved (re: #6123 )
2019-04-07 14:29:05 -07:00
Bryan Housel
cda8f657ac
Swap fast-deep-equal for lodash isEqual
...
(re: #6087 )
2019-03-29 22:17:29 -04:00
Quincy Morgan
f4367f96c0
Add ignored warning counts to the changeset tags ( close #6123 )
2019-03-28 09:46:59 -04:00
Bryan Housel
31ae7fc800
Make sure hashtag checkers work with arrays and not nulls
...
(closes #6116 )
This is breakage related to #6087 in replacing _.uniqBy with a Set
The lodash functions are much more tolerant of nulls and dodgy inputs.
2019-03-27 09:20:19 -04:00
Bryan Housel
5e1ff74199
Replace lodash difference, intersects, union
...
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
0e90167513
Remove lodash clone
...
(re: #6087 )
2019-03-22 23:18:25 -04:00
Quincy Morgan
7329d1301a
Fix issues where save button would not enable and save blocker tooltip would not disappear
2019-02-04 19:08:43 -05:00
Quincy Morgan
8c51411ad6
Merge branch 'master' into validation
2019-02-04 08:58:10 -05:00
SilentSpike
9403f71140
Track closed ImproveOSM errors via coordinates
2019-02-01 23:31:08 +00:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
19a2a60bf4
Add tooltip to disabled upload button to specify what is blocking the upload
2019-01-30 13:20:56 -05:00
Bryan Housel
55a92ca79d
Add closed:note changeset tag for closed OSM notes
2019-01-11 10:14:55 -05:00
Bryan Housel
5ebe0976fe
Add closed:keepright changeset tag for closed issues
...
The issues are written as `schema:error_id` and semicolon delimited
e.g. `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
2019-01-10 23:27:55 -05:00
Max Grossman
1471b55122
lint!
...
ref #5614
2018-12-18 12:02:26 -05:00
Max Grossman
ae9d43b0ac
remove double class
...
ref #5614
2018-12-18 11:16:37 -05:00
Max Grossman
18c021b5d5
add css
...
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da
add close button w/out css
...
ref #5614
2018-12-18 11:00:40 -05:00
Bryan Housel
577e0c6503
Don't add "None" to imagery_used tag when other imagery was used
...
(closes #5565 )
2018-12-11 16:37:52 -05:00
Bryan Housel
fa6e195c2d
Add user info, require authentication to edit a note
2018-07-17 00:55:43 -04:00
Thomas Hervey
61ae541cfc
updated: notes save buttons
2018-07-03 10:57:53 -04:00
Bryan Housel
644985c8e3
Don't write 'undefined' to storage when deleting the changeset source
...
(closes #5012 )
Also includes some code to ignore/remove any 'undefined' source values which
happen to be stored in localStorage. Because the saved source/comment/hashtags
expire after 2 days, this code can go away in iD v2.9
2018-05-13 12:57:49 -04:00
Bryan Housel
d8f6fafe74
Don't add empty source tag on a changeset
...
(closes #4993 )
2018-04-18 17:33:56 -04:00
Bryan Housel
61c7f64077
Remember changeset source, make it settable via url param
...
(closes #4899 )
2018-03-16 09:20:32 -04:00
Bryan Housel
a63c4a72fe
Improvements to save flow
...
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056 )
- Block reentry of save, and dont keep focus on save button (closes #4641 )
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
2018-01-05 15:11:44 -05:00
Bryan Housel
8914d1ce36
Variable cleanups and formatting
2018-01-04 16:13:13 -05:00
Bryan Housel
34cdab9197
uiDisclosure now handles expanded state in localStorage
...
Now all the places that use a uiDisclosure won't have to do that
2017-11-27 17:13:57 -05:00
Bryan Housel
35a9f77a63
Preserve selected entity when cancelling save mode
...
(closes #4407 )
2017-11-12 12:34:04 -05:00
Colin Kennedy
c81cf703f2
Fix #4443 Imagery only updated on first save
2017-10-15 15:45:53 -04:00
Seth Fitzsimmons
0b770450cd
Allow -,_,+,& as hashtag characters
2017-10-09 14:56:49 -04:00
Bryan Housel
8f82caf554
Adjust hashtagRegex: allow '_', change * (0 or more) to + (1 or more)
2017-10-09 14:39:02 -04:00
Seth Fitzsimmons
37cf22e1a2
Treat punctuation as hashtag delimiters
...
Unicode ranges for punctuation are simpler than creating a Unicode-aware
word class, so delimit on non-words.
Fixes #4398
2017-10-09 10:14:25 -04:00
Bryan Housel
3d13620705
Convert lodah-es and d3 to named imports for ui
2017-09-26 11:22:43 -04:00
Bryan Housel
595053621b
Wrap request review UI in div and label
...
(closes #4354 )
2017-09-18 14:10:14 -04:00
Bryan Housel
0f153d7d55
Ignore URLish fragments when detecting hashtags in changeset comment
...
(closes #4289 )
2017-09-11 12:11:22 -04:00
Bryan Housel
ba8a1e6bc6
Several changes to avoid storing stale hashtags
...
(closes #4304 )
- remove context.storage hashtags whenever hashtags are detected in comment.
- when changing the comment, override hashtags with any found in comment.
2017-09-11 11:50:59 -04:00
Bryan Housel
9719a31c79
Match less punctuation in hashtags
...
(closes #4303 )
2017-09-11 09:55:29 -04:00
Bryan Housel
f034092b44
Write post-save count, not pre-save count to the changesets_count tag
...
(closes #4283 )
2017-08-26 15:46:56 -04:00
Bryan Housel
121a1fa629
Avoid making an empty hashtags tag
2017-08-17 12:06:16 -04:00
Bryan Housel
2bf7a5e08b
Write changeset tags for new mappers to indicate walkthrough progress
...
These tags all start with `ideditor:`
(closes #3968 )
```
ideditor:walkthrough_completed=yes
ideditor:walkthrough_progress=welcome;navigation;point;area;line;building;startEditing
ideditor:walkthrough_started=yes
```
2017-08-16 20:10:01 -04:00
Bryan Housel
ea298b0b18
Change raw tag editor readOnlyTags to accept array of regex
2017-08-16 19:54:53 -04:00
Bryan Housel
25d8a8aa08
Store changesets_count in a changeset tag
...
(it will say "0" for someone making their first edit)
2017-08-16 16:31:21 -04:00
Bryan Housel
a42aa789e9
Add hashtags API parameter and localStorage
...
(closes #2834 )
2017-08-16 10:47:17 -04:00
Bryan Housel
4cf357f61a
Add code to extract hashtags from changeset comment
2017-08-16 00:30:34 -04:00
Bryan Housel
ba3f823141
Split out commitWarnings and commitChanges sections into smaller modules
2017-08-15 01:50:52 -04:00
Bryan Housel
d7a07208e1
Restore saving comment to localstorage
2017-08-14 23:14:05 -04:00
Bryan Housel
194b56c0f0
Restore the comment google warning
2017-08-14 22:59:15 -04:00
Bryan Housel
9b37ac7b6c
Fix errors with changeset fields and warnings, improve styles
2017-08-13 23:25:37 -04:00
Bryan Housel
fba6871e5c
WIP: persist uiRawTagEditor, uiChangesetEditor between renders
2017-08-13 12:08:49 -04:00
Bryan Housel
e0266da083
WIP: add changeset fields and refactor
2017-08-12 14:26:34 -04:00
Bryan Housel
439eed4b39
WIP: refactor uiCommit into sections, introduce uiChangesetEditor
...
uiCommit is getting kind of big as we add more to the commit pane.
I'm going to split it up and put the field rendering code into a separate
module, similar to how uiEntityEditor embeds uiPresetEditor for the fields.
This allows us to add a few more fields that users can set on their changesets
(like hashtags, source), and even hide them under a "Add field" dropdown.
2017-08-11 17:17:46 -04:00