CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,101 Commits 2 Branches 0 Tags
5eda112bfae00a693200c3faa413c2f0d22ef98d
Commit Graph

985 Commits

Author SHA1 Message Date
Bryan Housel
fa1edc86a1 Another place where we should delimit name suggestion on en-dash 
see 20bcfc573
 2019-01-23 09:57:43 -05:00
Bryan Housel
20bcfc5730 Delimit name-suggestion-preset names on en-dash, not hyphen 
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
 2019-01-23 09:44:24 -05:00
Bryan Housel
4583e2d4d7 Make sure all combo event listeners can handle accept/cancel w/o datum 
(re: #5637, re: #5618)

This can happen if the user enters a value that is not matched to
one of the combo suggestions.

Also make sure to set `this` to the input field.  It might not be
already if the event was triggered from a keypress instead of a click.
 2019-01-22 23:14:34 -05:00
Bryan Housel
0c7b9a631e Improve combobox event handling and avoid overwriting typed data 
(closes #5722, re: #5637, re: #5618)

dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)

Fix for this coming in next commit.
 2019-01-22 22:26:27 -05:00
Quincy Morgan
1323ec3d5a Map Data and Background panes no longer reload hidden sections 2019-01-21 15:52:58 -05:00
Quincy Morgan
35ac247ff0 Fixes an issue where panel sections wouldn't render when toggled if hidden on page load (closes #5743) 2019-01-21 15:22:50 -05:00
Quincy Morgan
a7e713da15 Fixed an issue in the Areas walkthrough chapter where the user could not proceed after adding the Description field 2019-01-21 11:51:25 -05:00
Bryan Housel
2df39c1dc7 Escape all .s in imagery identifiers, not just the first one 
(closes #5737)
 2019-01-19 10:53:09 -05:00
Bryan Housel
1ec5b708fc Restore default click behaviors on mousedown of a combobox 
(closes #5732)
 2019-01-18 23:23:35 -05:00
Bryan Housel
087c38e8fd Avoid calling changeRole recursively 
(closes #5731)
 2019-01-18 18:20:47 -05:00
Bryan Housel
4e3def9ce8 Fix the width of the add-tag and add-relation buttons 
(closes #5729)
 2019-01-18 13:48:17 -05:00
Quincy Morgan
46beb31e74 Removed extra padding in comboboxes when the caret is hidden 2019-01-18 11:59:40 -05:00
Quincy Morgan
bf2574f4e3 Hide the dropdown arrow in combo fields if there are no suggestions from tagInfo (closes #5730) 2019-01-18 11:21:31 -05:00
Quincy Morgan
bc81a62a58 Made the value chips in the Destinations semiCombo field full-width to mimic the layout of highway signs (re: #4178) 
The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
 2019-01-18 10:41:51 -05:00
Quincy Morgan
77cfde7913 combo, multiCombo, and semiCombo fields now correctly submit the typed value upon pressing enter/return without deselecting the feature (closes #5725) 2019-01-17 15:42:35 -05:00
Bryan Housel
e37dbbd3e1 Style preset icon fill with building if it has a building_area field 
These are presets that default to `building=yes` so they should look like
buildings.
 2019-01-17 14:28:57 -05:00
Quincy Morgan
90637bdcfa Fixed an issue where the cycleway field would throw an error when added from the "Add field:" dropdown 2019-01-17 12:32:14 -05:00
Quincy Morgan
9f7ef21e5c The additional fields dropdown now mixes universal and moreFields and is sorted alphabetically 2019-01-17 11:37:05 -05:00
Bryan Housel
3e12a85fa1 Merge pull request #5717 from nyurik/wikilink 
Add wiki links from tag description
 2019-01-17 00:10:45 -05:00
Bryan Housel
a9ac1bda97 Fix issues causing mode/undo/save buttons to be missing disabled style 2019-01-17 00:06:57 -05:00
Yuri Astrakhan
3caf6eabed remove non local non en wiki links 2019-01-16 15:00:20 -05:00
Yuri Astrakhan
54b4a798b1 Localize language name 2019-01-16 14:35:47 -05:00
Bryan Housel
3fe6c0dbe7 Support more eased transitions, cleanup code 
(re: #3967, #5169, #5407)
 2019-01-16 13:42:32 -05:00
Bryan Housel
460d144c66 Use centerZoomEase for smoother walkthrough transitions 2019-01-16 01:32:15 -05:00
Yuri Astrakhan
d724677c9f Support extracting wiki info from tag and key 2019-01-15 21:50:57 -05:00
Yuri Astrakhan
1127a34f94 Add wiki links from tag description 
This feature requires P31 property to be present
in the data item. For an example, see
https://wiki.openstreetmap.org/wiki/Item:Q104#P31

Once the bot populates them in the data items,
it will automatically work for all existing keys/tags.
 2019-01-15 20:07:45 -05:00
Quincy Morgan
92e514f891 Make the preset browser appear upon adding a new relation. 
Closes #5656
 2019-01-14 16:25:43 -05:00
Bryan Housel
3090b5c875 Merge pull request #5708 from iriman/context-menu-rtl 
[RTL] place tooltip under #id-container to inherit rtl
 2019-01-14 09:07:12 -05:00
iriman
bc9a64058f [RTL] place edit menu under #id-container to inherit rtl 2019-01-14 15:50:31 +03:30
iriman
7b53d0aa5a [RTL] pick appropriate class for .field-help-title > h2 2019-01-13 19:44:49 +03:30
Bryan Housel
09e574983f Don't call formFields.tagsChanged() when presetEditor.tags change 
(closes #5690)

This change also makes sure to use the latest copy of the entity in
field.isAllowed() to ensure the prerequisite field check works
and fieldsArr is filtered properly for #5583
 2019-01-11 17:42:34 -05:00
Bryan Housel
b575ee8500 Move formFields klass from an argument to a state variable 
(maybe needed in case render can get called different ways)
 2019-01-11 13:56:16 -05:00
Bryan Housel
55a92ca79d Add closed:note changeset tag for closed OSM notes 2019-01-11 10:14:55 -05:00
Bryan Housel
5ebe0976fe Add closed:keepright changeset tag for closed issues 
The issues are written as `schema:error_id` and semicolon delimited
e.g.  `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
 2019-01-10 23:27:55 -05:00
Bryan Housel
7f321abbaf Add links to the main error object in KeepRight error messages 
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
 2019-01-10 17:38:09 -05:00
Bryan Housel
98c08a02ef Add "zoom to this" quicklink and keybind for keepright editor 
(re #5169)
 2019-01-09 22:59:44 -05:00
Bryan Housel
9282a51795 Add "zoom to this" quicklink and keybind for data editor 
(re #5169)
 2019-01-09 22:49:51 -05:00
Bryan Housel
6efbbb8aa3 Add "zoom to this" quicklink and keybind for note editor 
(closes #5169)
 2019-01-09 22:24:52 -05:00
Bryan Housel
9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Bryan Housel
5c6406ea63 Remove section borders from inspector 
There is enough separation with the disclosure headings that we
don't need to break the sidebar up with lines
 2019-01-08 14:04:07 -05:00
Bryan Housel
5f2d80c7a6 pacify eslint 2019-01-08 10:58:47 -05:00
Bryan Housel
5f20218f1f Add validation warning for generic names 
(closes #5590)
 2019-01-08 02:15:28 -05:00
Bryan Housel
d9015baa47 Improve links in KeepRight error messages 
(re: #5679)

Also move the localizeable string dictionary to data/keepRight.json
 2019-01-07 16:10:44 -05:00
Bryan Housel
4ed2858cc5 Explicitly include '?' as a fallback key for keyboard shortcuts 
(closes #5675)

This allows for a localized version of the key,
but iD will still respond to the '?'
 2019-01-07 11:39:12 -05:00
Bryan Housel
826f66a91b Unique values for key codes moved to utilKeybinding, uiShortcuts 
This lets us supply lists of keys which might contain duplicates, but will be
made unique.  For example: [t('sidebar.key'), '`', '²']
'sidebar.key' may be one of the other choices, but will be deduplicated.
 2019-01-07 11:12:24 -05:00
Bryan Housel
55d2dddb70 Keybind all of _uniq([t(sidebar.key), '`', '²']) to toggle sidebar 
(closes #5663)
 2019-01-06 00:33:35 -05:00
Minh Nguyễn
3c82174f03 Capitalize first letter of KeepRight error detail 2019-01-05 00:32:45 -08:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel
46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00