Commit Graph

131 Commits

Author SHA1 Message Date
Martin Raifer 5c721808c6 change variables for better readability, closes #11022 2025-05-06 11:25:32 +02:00
Martin Raifer d5118b0fd6 make sure photos is properly highlighted when switching providers
previously, when the photo was already loaded in the mapillary viewer, then another photo from a different provider was displayed and the previous mapillary photo selected again, the "highlighted photo" marker was not drawn correctly, and the "set mapillary id from photo" button not properly updated
2025-04-29 17:19:55 +02:00
Martin Raifer 81d94a138b fix mapillary's panorama viewer from loading properly
this was a regression from the previous commit (19957d0e3)

also, harmonize code slightly between different services
2025-04-29 11:50:37 +02:00
Martin Raifer 19957d0e39 keep photo viewer state on reset, properly clean up active marker
when switching between photos from different providers

fixes #10987
2025-04-29 09:38:18 +02:00
Martin Raifer fa91fe7c0d fix zoom resetting wrongly when switching background mid-transition
see https://github.com/openstreetmap/iD/issues/10700#issuecomment-2832010049
2025-04-26 21:10:16 +02:00
Martin Raifer f5eb4d2a51 don't de-select map feature when clicking on a street level photo 2025-04-15 18:14:59 +02:00
laigyu 2325de4662 update butotn logic 2024-04-12 18:37:26 +08:00
laigyu d448b586ed revert error handler 2024-04-07 23:19:41 +08:00
NaVis0mple 0ad46e0b72 Add error message in photoviewer when invalid id
and update input.js
2024-01-27 15:14:27 +08:00
Nikola Pleša 87a823f093 Fix traffic sign rendering and geometry conversion 2021-06-15 10:56:08 +02:00
Nikola Pleša 7a0d8adb7b Switch to Mapillary API v4 2021-06-15 10:13:07 +02:00
Nikola Pleša 6cd17713fa Use Mapillary vector tiles for images, sequences and map features 2021-03-01 10:19:41 +01:00
Quincy Morgan 4ae7bc9bd5 Update Mapillary.Viewer call for mapillary-js v3 (re: #8245) 2021-02-23 12:27:32 -05:00
Quincy Morgan 981cdc6736 Apply photo date and username filters to Mapillary sign and object detections (close #8133)
Don't update disabled SVG layers upon photo changes
2020-10-29 11:59:12 -04:00
Quincy Morgan 792a4e8594 Fix background tile issues caused by the cache not properly updating upon load/error with D3 v6 2020-10-26 14:52:58 -04:00
Quincy Morgan 081db7c7a6 Support filtering by multiple photo usernames 2020-10-19 16:27:07 -04:00
Quincy Morgan a33ab44e81 Merge branch 'develop' into photo-filter-temp
# Conflicts:
#	css/80_app.css
#	modules/services/mapillary.js
2020-10-12 16:16:32 -04:00
Quincy Morgan 2fa64e7445 Switch from hyphen to slash for photo parameter separator (re: #6398) 2020-10-04 20:17:44 -04:00
Quincy Morgan ad54a6e140 Support opening iD with a Streetside or OpenStreetCam photo specified as a URL parameter (close #6398)
Bring the APIs for the three street level services closer in sync
2020-10-02 13:30:36 -04:00
Quincy Morgan 21c86c6d6d Re-add reading of mapillary image from URL (re: #7885, #6398) 2020-09-13 17:09:35 -04:00
Quincy Morgan 9510578107 Merge branch 'mapillary-update' into develop
# Conflicts:
#	modules/services/mapillary.js
#	modules/svg/mapillary_map_features.js
#	modules/svg/mapillary_signs.js
2020-09-13 16:34:25 -04:00
Quincy Morgan 4050940268 Lazy load photo overlay resources (close #7982) 2020-09-13 11:52:37 -04:00
Peter Newman 4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Nikola Plesa 6cda7fc77f fix: remove detections from image when features are turned off 2020-08-06 16:33:40 +02:00
Nikola Plesa f002df5493 feat: traffic sign highlighting 2020-08-03 14:30:51 +02:00
Nikola Plesa 6d5222ceb4 fix: fix warnings and update detection tags 2020-07-31 16:37:05 +02:00
Nikola Plesa e87b0b9432 feat: updates for mapillary map features and traffic signs 2020-07-31 14:55:17 +02:00
Nikola Plesa 22bc5121a4 feat: date and username filtering for photo overlay layers 2020-07-27 09:42:59 +02:00
Nikola Plesa 944953dbf2 Update Mapillary map_features URL and remove request_data button 2020-07-01 16:50:30 +02:00
Quincy Morgan a7ce956e1f Don't use global selectors in street-level photo services (re: #7445) 2020-03-29 11:04:38 -07:00
Quincy Morgan 7e1cf64d0e Namespace DOM ids used in photo viewer (re: #7445) 2020-03-24 13:43:54 -07:00
Quincy Morgan eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan 371bac0aa2 Convert photoviewer from id to class 2020-03-20 14:07:09 -07:00
Quincy Morgan 4d8d27f3c4 Rely more on mapillary selected photo key than photoviewer datum
Remove mapillary map feature selection outline when closing photoviewer
2019-12-11 17:53:03 -05:00
Quincy Morgan 0d5bd8b277 Store selected mapillary image by its key rather than its object
Properly sort selected mapillary signs and features above unselected ones
2019-12-11 17:15:36 -05:00
Quincy Morgan db300d1071 Add tooltips to mapillary map features layer icons (close #7079) 2019-12-05 11:52:12 -05:00
Quincy Morgan 271a4cbac7 Update rbush to 3.0.1 (close #6359) 2019-11-08 18:17:17 +01:00
cbeddow 819ea05e6f fix: mapillary pagination and minimum detection count 2019-10-07 14:13:21 +02:00
Matias Volpe 8e616d7384 feat: add Mapillary Map Features layer 2019-08-22 15:16:31 -03:00
Quincy Morgan 7d9f732753 Fix issue where Mapillary and Streetside viewers would not receive resize events (close #6286) 2019-08-22 10:19:46 -05:00
Quincy Morgan 4fb4f88e5a Fix issue where only the first page of mapillary results would be shown (close #6382) 2019-05-20 12:36:12 -04:00
Bryan Housel fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Bryan Housel e981cd5dd5 Switch mapillary and openstreetcam tests to work async
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
2019-04-29 15:31:08 -04:00
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel e6bc9d9e8f Swap out d3-request, swap in d3-fetch 2019-04-24 16:25:25 -04:00
Bryan Housel 4a8c20c56e Remove lodash forEach
(re: 6087)
2019-03-28 19:50:20 -04:00
Bryan Housel 5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel 7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Quincy Morgan 7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00