Quincy Morgan
63caa02cea
Allow presets to inherit multiCombo and semiCombo fields even if they define the preset
2019-02-19 15:48:50 -05:00
Quincy Morgan
6d397e89c6
Account for waterway bridges and implicit layers in crossing ways validation
2019-02-19 15:28:27 -05:00
Quincy Morgan
f536706763
Refactor crossing ways validation for performance
2019-02-19 14:40:54 -05:00
Quincy Morgan
b766f82cbd
Improve crossing ways performance slightly by avoiding clone
2019-02-19 13:25:02 -05:00
Quincy Morgan
708c5e8155
Fix crash when undoing an added line past the first node
2019-02-19 12:10:05 -05:00
Quincy Morgan
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan
95f8ed9416
Fix issue where clicking the combobox caret would not open the dropdown
2019-02-19 09:46:39 -05:00
Quincy Morgan
b43796a4c7
Don't flag almost junctions for points endpoints that also occur earlier in the way
2019-02-19 09:16:32 -05:00
Quincy Morgan
794e953d43
Don't suggest continuing a disconnected highway from endpoints that have noexit=yes
2019-02-19 08:40:49 -05:00
Quincy Morgan
b483832a80
Remove unused parameter
2019-02-18 14:14:36 -05:00
Quincy Morgan
7307beff21
Don't make connect endpoints fix for tag suggest area actionable if there aren't more than two nodes
2019-02-18 12:51:50 -05:00
Quincy Morgan
10d9f05739
Show the actual deprecated tag value in the issue message rather than the * placeholder
2019-02-18 12:17:52 -05:00
Quincy Morgan
66db6f3f2c
Make building crossing validation only create one issue per feature pair (re: #5891 )
2019-02-18 10:43:19 -05:00
Quincy Morgan
94cb9faaa2
Don't check for self-intersection in the crossing ways validation
2019-02-18 10:16:22 -05:00
Quincy Morgan
7021985aec
Don't suggest connection fix for highway-building crossings (re: #5891 )
2019-02-18 10:12:47 -05:00
Quincy Morgan
e48f8cfc48
Fix generic name issue message
2019-02-18 10:11:01 -05:00
Quincy Morgan
2c1955d630
Improve performance and scope of the generic name validation
2019-02-18 10:02:49 -05:00
Quincy Morgan
397097ac1f
Tweak issue and fix strings
...
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
Quincy Morgan
31eb837596
Fix issue where fixes would not expand when clicking an issue
...
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan
6cb4359d13
Fix issue where entity issues UI could show stale issues
2019-02-15 12:52:09 -05:00
Quincy Morgan
b57e5a75b8
Tweak issue pane icon badge
2019-02-15 12:19:48 -05:00
Quincy Morgan
058a8ee8ff
Merge branch 'master' into validation
2019-02-15 12:03:57 -05:00
Quincy Morgan
0b86be7bcb
Fix bug where highlight would not appear on the first target node when continuing drawing a way
2019-02-15 11:56:31 -05:00
Quincy Morgan
96a1ec92c7
Fix prior commit
...
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan
55c10d2183
Only check to suppress vertex-snap highlighting for nodes (re: #5875 )
2019-02-15 09:09:35 -05:00
Bryan Housel
08d4c3268e
pacify eslint
2019-02-14 17:26:57 -05:00
Bryan Housel
078b19c828
Better handle undo/interruption during behaviorDrawWay
2019-02-14 17:24:09 -05:00
Quincy Morgan
75c7fd770d
Fix entity not found error
2019-02-14 16:21:29 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c86f11c359
Don't suggest extending disconnected line if it is closed
...
Extend at start/end doesn't make sense in this situation
2019-02-14 14:09:44 -05:00
Quincy Morgan
4c9ec3e9e8
Merge branch 'master' into validation
2019-02-14 13:35:14 -05:00
Quincy Morgan
ea3a85e88e
Merge pull request #5888 from openstreetmap/dynamic-line-icon-lines
...
Dynamic line previews in line preset icons
2019-02-14 12:27:02 -05:00
Quincy Morgan
c7e861c0ca
Merge branch 'master' into validation
2019-02-14 12:16:23 -05:00
Quincy Morgan
d0c29f8554
Tweak line icon display
2019-02-14 10:06:50 -05:00
Quincy Morgan
d63430e66a
Line preset icons:
...
- Render vertices with SVG
- Add viewBox to SVG
- Don't reload static parts of the SVG on every update
- Use dimensions that are friendly for low-res displays
- Use nicer-looking stroke dash patterns for ferry routes and railways
2019-02-14 09:40:17 -05:00
Bryan Housel
6525bbf154
Exclude current entity's value from address nearby values lookup
...
re: https://github.com/openstreetmap/iD/issues/5887#issuecomment-463385328
2019-02-14 00:27:32 -05:00
Bryan Housel
9e2acd836c
Use case sensitive combos in address fields
...
(closes #5887 )
This allows users to correct mistyped address parts
2019-02-14 00:20:38 -05:00
Bryan Housel
6a560861b2
Add notification badge to Issue pane icon
2019-02-13 16:56:17 -05:00
Quincy Morgan
ed95fafac9
Add endpoint vertices to the preset icon line
2019-02-13 16:12:29 -05:00
Bryan Housel
5bca360f50
Don't show the entity_issues section if there are no issues
...
(I think it worked this way before)
2019-02-13 13:57:46 -05:00
Bryan Housel
c292a32a66
Better message padding, remove double tooltip
2019-02-13 13:47:00 -05:00
Quincy Morgan
09ec7ea802
Remove redundant line preset icons
...
Fix lint errors
2019-02-13 13:28:34 -05:00
Quincy Morgan
f443144fc6
Update preset icons to use same tag classes as map SVG
2019-02-13 13:11:27 -05:00
Quincy Morgan
041e05ec90
Make the line component of the line preset icons dynamic and match the line styling in the map
2019-02-13 12:01:40 -05:00
Bryan Housel
46ab561724
Merge pull request #5885 from SilentSpike/forced
...
Persist forced visible entities on move/rotate
2019-02-12 21:21:12 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd
Only recenter view if necessary, select after delay, fix maprules type
2019-02-12 17:25:54 -05:00
SilentSpike
a7e0c779b3
Persist forced visible entities on move/rotate
2019-02-12 22:25:47 +00:00
Quincy Morgan
393bb7f5e3
Fix several bugs with arrow key navigation in preset list
2019-02-12 17:17:13 -05:00
Quincy Morgan
5e586419fa
Remove unnecessary float styles and cleanup CSS in the preset list
2019-02-12 16:29:52 -05:00
