Commit Graph

299 Commits

Author SHA1 Message Date
Martin Raifer
607f953465 add alternative formats for coordinate search: (#10805)
* zoom/x/y – copy/paste from an osm.org URL or web map with map-hash param (this also sets map zoom to the respective value)
* x/y – like the above, but does not set zoom level
* x y – where x and y are numbers in the user's locale's number format
2025-03-11 21:20:21 +01:00
Kyℓe Hensel
a41e8c48d2 separate tag-upgrade warnings from NSI suggestions (#10801) 2025-03-05 12:42:40 +01:00
Kyℓe Hensel
f513ccd03d enable intellisense for the main classes (#10618) 2025-02-17 11:35:50 +01:00
Kyℓe Hensel
4747ae253c refactor isOneWay to properly support bidirectional ways (#10730) 2025-02-12 14:22:09 +01:00
Kyℓe Hensel
6328776df1 Fix + symbol appearing in changeset comments from external tools (#10766) 2025-02-12 14:13:15 +01:00
Martin Raifer
28183c71bb Merge remote-tracking branch 'michaelabon/stop-password-managers-address-fields' into develop 2024-12-18 15:40:22 +01:00
Minh Nguyễn
6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Michael Abon
6ffba9f7ff Stop password managers from autofilling address fields
I am a 1Password user (and employee).
Whenever I am editing a local business's details in iD,
I am frustrated that the 1Password browser extension offers
to fill out my personal address
instead of the business's address.

I don't work on our browser extension,
I could not tell you why every password manager
has their own custom data attribute
when autocomplete=off exists.
But, for fairness,
I am including other major password managers'
custom data attributes to stop them as well
from autofilling address fields.

I was very pleased to find out that
there was already
a well-used utility function
to disable autocomplete/autocorrect/autocapitalize.

Fixes #10507
2024-10-18 12:38:01 -05:00
Kyle Hensel
108893c624 enable --no-isolate to speed up unit tests
This required fixing deferred code that was running after the unit test had unmounted
2024-10-16 13:42:51 +02:00
Kyle Hensel
90c4241723 fix dependency cycle caused by utilDisplayLabel importing presetManager 2024-08-24 11:34:46 +10:00
Mateusz Konieczny
70b96b1758 preserve whitespace in inscription tag after semicolons, fixes #10188 (#10189) 2024-04-24 13:26:56 +02:00
Martin Raifer
83754e4a4a switch to Bing Maps API for Bing Streetside layer, fixes #10074
replaces the use of undocumented APIs for Microsoft's street level imagery service and gets rid of hardcoded values, e.g. for the `g` ("generation") parameter

see https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#get-streetside-metadata-centered-at-a-point for API docs

see also #10100
2024-02-16 18:29:23 +01:00
NaVis0mple
01d650d450 Expand DMS format and fix sec rounding logic (#10066)
Most DMS format parsed by @mapbox/sexagesimal, 
add a expandable matcher and two new formats for coordinates in DMS format in search bar

example: `35 11 10.1 , 136 49 53.8` (D M SS format), or `35 11.168 , 136 49.896` (D MM format)
2024-02-02 15:26:47 +01:00
Martin Raifer
9cc04d3f0b fix spelling mistakes 2023-11-14 11:26:36 +01:00
Martin Raifer
13a0f2c180 Fix stuck cursor in input fields on Safari, fixes #9848 2023-08-17 23:34:11 +02:00
Martin Raifer
77f31cad07 fix tests 2023-08-09 18:39:24 +02:00
Martin Raifer
a2d3cf8f9a fix jumping cursor while editing in some input fields
fixes #9233
2023-08-03 16:49:37 +02:00
Kyℓe Hensel
667a620a9f fix the raw tag editor broken and strange cursor behaviour (#9766)
* fix the raw tag editor broken

* new approach

* fix typo to satisfy github checks
2023-07-13 02:04:33 -07:00
Martin Raifer
29b1197059 add code comment/documentation 2023-07-12 22:02:41 +02:00
Martin Raifer
396d142623 fix crash when rendering and email UI field, fixes #9752 2023-07-12 22:00:42 +02:00
Martin Raifer
2b64d70352 generalize implementation to skip input value update
when contents are "equivalent" in a given context, e.g. for numeric values with potentially different formatting in number fields
2023-05-26 19:24:10 +02:00
Martin Raifer
ee89f6ae66 lint 2023-05-26 18:46:57 +02:00
Martin Raifer
14c752548d keep cursor at edit position while typing in the middle 2023-05-26 17:59:04 +02:00
Martin Raifer
5091966056 [WIP] add string length indicator and max-length message 2022-11-25 17:48:33 +01:00
Martin Raifer
41aa127d23 reduce use of parseFloat
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
2022-11-24 19:39:15 +01:00
CommanderRoot
76738daff8 Replace deprecated String.prototype.substr() (#8988)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated.
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-06-06 16:16:38 +02:00
Milos Brzakovic
66c5007fc2 Update bing imagery key and api urls. Interval limiting for tiles vintage (#9133)
update bing imagery key, template, api url
BasicMetadata for vintage
handled 429 in getMetadata
2022-05-25 18:49:35 +02:00
Martin Raifer
22bd62836d try key codes for all non-ascii input characters 2022-02-11 16:18:53 +01:00
Martin Raifer
bb3ab9257a Fix broken ⌥+w keyboard shortcut on MacOS in some keyboard layouts (#8905) 2022-02-11 16:00:52 +01:00
Martin Raifer
632e24137a drop legacy builds, unneeded polyfills, document drop of IE11 support 2022-02-03 13:07:28 +01:00
Thomas Petillon
fab6dfa3dd Add the utilCompareIDs() function 2021-12-06 21:23:38 +01:00
Thomas Petillon
e1898e5c56 Add the utilOldestID() function 2021-12-06 21:23:38 +01:00
Kyle Hensel
3a3d977f7e add preview for colour input 2021-11-04 15:05:23 +13:00
Nick Doiron
2d97f8414d turn off svg text path patch on Chromium >=96 2021-10-08 00:36:18 -04:00
Bryan Housel
1282d3b059 Don't use a util function for a thing that exists 1x in the code 2021-08-16 14:23:24 -04:00
Bryan Housel
9f58f1fb5c Improve code for focusing a validation issue on a relation
The "center" of the issue might be a spot of map that doesn't contain the relation.
This code chooses a piece of the relation that has been downloaded and focuses on that.
2021-08-05 12:47:40 -04:00
Milos Brzakovic (E-Search)
d2036996e3 Merge conflicts resolved 2021-07-05 10:26:44 +02:00
Bryan Housel
9f30ebf551 Adjust verbose utilDisplayLabel call, use for more validation messages
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-794527259)
2021-03-10 10:30:57 -05:00
Bryan Housel
c3e9e8c8ff Support a more verbose format for listing issues
Includes the feature type in the label
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-791919134)
2021-03-08 12:15:17 -05:00
Quincy Morgan
13ddeecfa7 Fix code tests for #8276 for real this time
Add utilFetchJson to get around some quirks of d3.json and use it for coreFileFetcher
Load real general English locale strings at the beginning of code tests
2021-02-23 11:50:00 -05:00
Quincy Morgan
483ea41f46 Merge pull request #8276 from openstreetmap/1ec5-display-name-direction
Label route relations with directions and waypoints
2021-01-08 10:13:41 -05:00
Quincy Morgan
ddf868221a Use vertical bar for selecting parent ways instead of command+up arrow (re: #8264)
Support pressing vertical bar again to return to node selection
2021-01-06 14:26:24 -05:00
Minh Nguyễn
6e30e61ade Label route relations with directions and waypoints 2020-12-31 16:50:47 -08:00
Quincy Morgan
611abf8ed0 Enable rotating selection even when mouse isn't over the map (re: #8187) 2020-12-03 15:04:21 -05:00
Quincy Morgan
ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00
Quincy Morgan
d247ec3aed Enable brace-style eslint rule 2020-11-10 13:49:48 -05:00
Quincy Morgan
4059ee5118 Enable block-scoped-var eslint rule 2020-10-23 13:38:36 -04:00
Quincy Morgan
04b3a788f9 Add lint:fix script
Enable no-trailing-space eslint rule
2020-10-23 13:24:44 -04:00
Quincy Morgan
6549bcc197 Enable no-eq-null eslint rule 2020-10-23 11:27:32 -04:00
Quincy Morgan
21a49bbec8 Initial support for D3 v6.2.0 2020-10-06 15:08:39 -04:00