Quincy Morgan
cee4b0a4da
Give several functions more descriptive names
2020-06-08 09:50:13 -04:00
Quincy Morgan
97cb90b562
Make issue messages dynamic ( close #6331 )
2019-05-07 14:48:30 -04:00
Quincy Morgan
375779882d
Add ability to ignore warnings
...
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan
228af9a000
Move areaKeys and setAreaKeys to modules/osm/tags
2019-04-26 12:53:05 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
05f0e9f76f
Remove lodash isMatch
...
(re: #6087 )
2019-03-30 09:36:24 -04:00
Bryan Housel
0edd10001e
Removing more lodash: isEmpty, isNumber, some map/reduce/forEach
...
(re: #6087 )
2019-03-27 13:32:35 -04:00
Bryan Housel
5e1ff74199
Replace lodash difference, intersects, union
...
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
76e0d13729
Remove lodash every and filter
...
(re: #6087 )
2019-03-23 01:22:56 -04:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
Bryan Housel
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
Andrew Wong
6ae25eada7
fixing tests around issues
2018-12-19 13:34:16 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Bryan Housel
5a2049b421
Drop extra whitespace, make sure service exists before using it
2018-12-18 15:38:53 -05:00
Max Grossman
64f2d913e8
remove unused entities from test
2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12
make collection.index function to handle failing tests
2018-12-17 17:16:10 -05:00
Max Grossman
622b7b9e0c
move validations to its own class
...
ref #remote-presets
2018-10-01 21:45:21 -04:00
Max Grossman
0a31137c78
move maprules/mapcss to a service class
...
ref #remote-presets
2018-09-23 18:38:01 -04:00
