Commit Graph

686 Commits

Author SHA1 Message Date
Bryan Housel
70f87632c7 Cleaner note icon rendering
Before: We drew 2 fontawesome comment icons, on on top of the other
After: Moved icon into iD spritesheet and gave it an actual `stroke` property that can be styled
2018-07-16 13:18:38 -04:00
Thomas Hervey
7fb42ac9d6 added note reporting and margin to save buttons 2018-07-13 17:09:51 -04:00
Bryan Housel
1a106f5253 Make uiViewOnOSM work for notes too, add it to note_editor footer 2018-07-13 15:55:58 -04:00
Bryan Housel
8a1079c3c6 Update notes on status change 2018-07-13 00:15:30 -04:00
Bryan Housel
57da729837 Implement note save button code 2018-07-12 23:50:29 -04:00
Bryan Housel
645cc790a3 Add docs about OSM API, finish implementing postNoteUpdate
`postNoteUpdate` can hangle status changes and comment additions
(I named it that to be like `putChangeset`)

Also renamed `user` to `loadUser` to be consistent with other calls
2018-07-12 23:46:07 -04:00
Bryan Housel
19560ebc90 Properly save and restore caches when entering/leaving the walkthrough 2018-07-12 15:39:04 -04:00
Bryan Housel
fe7086f753 Add header close 'X' button, add grey hover styling 2018-07-12 02:51:49 -04:00
Bryan Housel
5e5601f555 Store the unsaved comment in the note itself 2018-07-12 02:09:24 -04:00
Bryan Housel
91add0c33e WIP on buttons, simplify, remove some event dispatch
- I made the buttons work like GitHub comment-on-issue buttons
before typing:  "Close Note" / "Comment" (disabled)
after typing:   "Close and Comment" / "Comment" (enabled)

- I removed a bunch of the event dispatches.  These are useful for sending
events to listeners/observers outside of the module.  In this case I think
we can handle most of the things from within the uiNoteEditor.  We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.

TODO - make the buttons work / check the OSM API stuff.
2018-07-11 23:10:01 -04:00
Bryan Housel
3454753bf6 Drop more/less toggle and just use a scrollbar for long comments 2018-07-11 16:00:54 -04:00
Bryan Housel
e9e2f9ba8f Style note header 2018-07-11 15:41:43 -04:00
Bryan Housel
0d7c292c23 Refactor out uiNoteHeader and uiNoteComments into separate modules
uiNoteEditor was getting big!
2018-07-10 21:45:02 -04:00
Thomas Hervey
eafae6c58c WIP: update service calls; todo: note update event handling 2018-07-10 13:50:36 -04:00
Thomas Hervey
c460c03da5 fixed typo 2018-07-09 10:11:50 -04:00
Thomas Hervey
14356cefe2 WIP: toggle note status 2018-07-08 12:50:02 -05:00
Bryan Housel
7b42743513 pacify some eslint warnings 2018-07-07 23:00:48 -04:00
Bryan Housel
3eb3eefabd Combine Osm and Notes layers into the same ul 2018-07-07 22:54:27 -04:00
Bryan Housel
d137aa0046 Add "More/Less" toggle for too long comments (curr limit 600 chars) 2018-07-07 00:25:42 -04:00
Bryan Housel
01b33e3fb7 Linkify the usernames 2018-07-06 11:28:01 -04:00
Bryan Housel
263ec9e36a Add code to swap in avatar images for users that have them 2018-07-05 18:42:42 -04:00
Bryan Housel
6f1dc12f99 Add user method to osm service, _userCache, user parser 2018-07-04 03:20:16 -04:00
Thomas Hervey
73ee5c2fc9 fixed select_note mode, cleaned note_editor, TODO: enable note save 2018-07-03 22:45:51 -04:00
Thomas Hervey
8121f585d5 added checks for multiclick and click on notes 2018-07-03 15:39:22 -04:00
Thomas Hervey
61ae541cfc updated: notes save buttons 2018-07-03 10:57:53 -04:00
Bryan Housel
ab8e793a72 Playing with note styling, add avatars and more metadata 2018-07-03 02:41:47 -04:00
Thomas Hervey
bd8705bf85 updated: reintroduced hovering on notes 2018-07-02 16:32:17 -04:00
Thomas Hervey
86dc0c9012 updated: new comments in notes sidebar ui 2018-07-02 15:51:55 -04:00
Bryan Housel
94eae89fc3 Merge, continue to tweak note_editor 2018-07-02 12:50:53 -04:00
Bryan Housel
a474e3bb9f Working on note editor style and ui, simplify d3 code 2018-07-02 12:35:07 -04:00
Thomas Hervey
2c22fe00a2 updated: hacky note hovering; todo: complete note click handling 2018-07-02 10:44:47 -04:00
Thomas Hervey
737ccfcfba updated: siebar displays note details on hover (via svg) 2018-06-29 14:43:01 -04:00
Thomas Hervey
db0fe7e539 merged from master 2018-06-21 11:06:57 -04:00
Bryan Housel
b238d442a6 Adjust default zoom for points to z19
(closes #5099)
2018-06-21 01:33:18 -04:00
Thomas Hervey
1ed915e69c added: map data notes toggle 2018-06-19 10:31:26 -04:00
Bryan Housel
5555b61e87 Fix bug causing 0 to be written into a numeric field when tabbing
(closes #5087)
2018-06-17 11:51:51 -04:00
Bryan Housel
9b6e405448 Use Esri World Imagery (clarity) in the intro walkthrough 2018-06-15 10:09:15 -04:00
Bryan Housel
d24790f17a Merge branch 'master' into jharpster-streetside 2018-06-11 23:51:23 -04:00
Andreas Hässler
f62a3a6b00 Handle key-value pairs pasted as tags 2018-06-09 23:24:20 +02:00
Bryan Housel
470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
cbfe23c9e1 Support FontAwesome solid, regular, and brands
(might as well.. only the used ones get bundled into the fa-sprite anyway)
2018-06-06 17:59:28 -04:00
Bryan Housel
2dd7bfc849 Add support for FontAwesome icons as preset icons
(closes #3025)
2018-06-06 02:19:38 -04:00
Bryan Housel
da10b6b254 Add maki- prefix to all maki icons
(re: #3924)
2018-06-05 22:12:33 -04:00
Bryan Housel
5901be1027 Replace poi- icons with temaki- icons
(re: #3924)
2018-06-05 13:08:43 -04:00
Bryan Housel
7ae8c9f6a7 Make min/max field values work for inputted values also
(previous commit only worked for the up/down buttons)
2018-06-02 12:19:43 -04:00
Bryan Housel
861299bb1c Support minValue/maxValue on numeric fields
Configure most numeric fields to avoid negative values
(closes #5043)
2018-06-02 11:11:15 -04:00
Bryan Housel
91dbd6c9c4 Merge branch 'streetside' of https://github.com/jharpster/iD into jharpster-streetside
(also cleanup whitespace and lint)
2018-05-25 16:52:28 -04:00
Thomas Hervey
2d45f79d90 Fixed tooltip location for data layers button 2018-05-16 16:30:10 -07:00
Bryan Housel
19dfcc0162 Exclude non-administrative boundary from address city suggestions
(closes #5034)
2018-05-14 14:00:12 -04:00
Bryan Housel
644985c8e3 Don't write 'undefined' to storage when deleting the changeset source
(closes #5012)

Also includes some code to ignore/remove any 'undefined' source values which
happen to be stored in localStorage. Because the saved source/comment/hashtags
expire after 2 days, this code can go away in iD v2.9
2018-05-13 12:57:49 -04:00