Commit Graph

22 Commits

Author SHA1 Message Date
Bryan Housel
99d037e97f Better logic for adding area=yes (closes #2578)
This fixes a few issues:

1. before: checked first key in applyTags and break loop, now: check all of them
(this was what caused `area=yes` to be added to 'branded' presets:
the first key is for these is `name` which isn't in areaKeys.)

2. add `area=yes` if user is drawing an area but the preset can be an
area or a line (e.g. `barrier=city_wall`)

3. remove `area=yes` when switching to another preset
2015-04-22 17:04:18 -04:00
John Firebaugh
d381812f96 Add area=yes when necessary
Example: highway=pedestrian areas.

Fixes #2069
2014-01-03 12:46:50 -08:00
John Firebaugh
d1b4e04ee4 Don't add addr:housenumber=yes when applying Address preset (#1874) 2013-10-09 16:35:12 -07:00
John Firebaugh
6cdd928ea3 Default wildcard tags to "yes"
Fixes #1715
2013-08-22 14:30:27 -07:00
John Firebaugh
4bdd49b5fc Adjustments to multipolygon preset
* It shouldn't appear as a search result for simple areas.
* Changing to another area preset shouldn't remove the
  type=multipolygon tag.
* It shouldn't be preferred to the Building preset, which
  matches with score 0.5.

Fixes #1546.
2013-05-29 16:00:34 -07:00
John Firebaugh
a61e0c9fd4 Fix preset search 2013-05-24 17:17:41 -07:00
John Firebaugh
5868875833 Split "other" preset into geometry specific fallbacks
This way the name and icon can be geometry-specific.
2013-05-24 11:14:59 -07:00
John Firebaugh
9502729f5e Optimize presets.match
Previous implementation was linear in the number of
presets. This should be near constant time.
2013-05-13 21:07:26 -07:00
John Firebaugh
525d37c647 Preset#matchTags -> Preset#matchScore 2013-05-13 17:48:18 -07:00
John Firebaugh
fdd49233b1 Avoid recomputing geometry in an inner loop 2013-04-25 11:27:53 -07:00
John Firebaugh
d8e58c62ff Fix tests 2013-04-15 16:33:06 -07:00
Tom MacWright
b59f28424c Translatable documentation, Fixes #1108
* Adds Marked
* Fixes a global leak in toGeoJSON
* Removes marked from package.json
* Adds documentation to core.yaml
* Removes stray console.log from tests
2013-03-27 14:34:34 -04:00
Ansis Brammanis
8c319d0d15 make other presets localizable, and update tests 2013-03-26 16:40:42 -04:00
John Firebaugh
7912b33b4c Exclude presets with searchable: false from search (fixes #932) 2013-03-17 20:59:11 -07:00
John Firebaugh
d0336a0995 Extract preset names to translations (fixes #1044) 2013-03-14 17:27:34 -07:00
Ansis Brammanis
547f12f822 Fields now have an optional geometry type
field defaults aren't geometry specific
the geometry type determines whether
that field (and default value) apply
to an entity
2013-03-14 16:48:09 -04:00
John Firebaugh
41e696a2c5 Flatten presets match properties 2013-03-13 12:45:20 -07:00
John Firebaugh
c1aa8e0270 form/forms -> field/fields 2013-03-13 11:34:21 -07:00
John Firebaugh
107f6cfeba type -> geometry 2013-03-12 13:00:32 -07:00
Ansis Brammanis
f72e294156 score wildcard matches as half a match
so that building=* doesn't get prioritized over more
specific one tag presets, like amenity=hospital
2013-03-08 11:36:57 -05:00
Ansis Brammanis
4fb8688d83 add tests for iD.presets.Collection and .Category 2013-03-05 15:37:34 -05:00
Ansis Brammanis
3a680b027f add tests for iD.presets.Preset 2013-03-05 13:06:21 -05:00