CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-27 07:53:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,021 Commits 2 Branches 0 Tags
7423d192d4e0ab08092048c52efc525e57df6885
Commit Graph

1466 Commits

Author SHA1 Message Date
Bryan Housel
7423d192d4 Implement multi-fetch get for users from OSM API 
Eagerly load user details after loading notes
(re: openstreetmap/openstreetmap-website#1921)
 2018-07-10 23:02:37 -04:00
Bryan Housel
0d7c292c23 Refactor out uiNoteHeader and uiNoteComments into separate modules 
uiNoteEditor was getting big!
 2018-07-10 21:45:02 -04:00
Thomas Hervey
eafae6c58c WIP: update service calls; todo: note update event handling 2018-07-10 13:50:36 -04:00
Thomas Hervey
c460c03da5 fixed typo 2018-07-09 10:11:50 -04:00
Thomas Hervey
14356cefe2 WIP: toggle note status 2018-07-08 12:50:02 -05:00
Thomas Hervey
0f49514fbb updated: removed centering when clicking a note 2018-07-08 10:27:44 -05:00
Bryan Housel
7b42743513 pacify some eslint warnings 2018-07-07 23:00:48 -04:00
Bryan Housel
3eb3eefabd Combine Osm and Notes layers into the same ul 2018-07-07 22:54:27 -04:00
Bryan Housel
d137aa0046 Add "More/Less" toggle for too long comments (curr limit 600 chars) 2018-07-07 00:25:42 -04:00
Bryan Housel
01b33e3fb7 Linkify the usernames 2018-07-06 11:28:01 -04:00
Bryan Housel
263ec9e36a Add code to swap in avatar images for users that have them 2018-07-05 18:42:42 -04:00
Bryan Housel
6f1dc12f99 Add user method to osm service, _userCache, user parser 2018-07-04 03:20:16 -04:00
Thomas Hervey
73ee5c2fc9 fixed select_note mode, cleaned note_editor, TODO: enable note save 2018-07-03 22:45:51 -04:00
Bryan Housel
bf499d9438 Restore modeSelect, and make a new modeSelectNote just for the notes 2018-07-03 18:11:59 -04:00
Bryan Housel
b14d1b5061 resolve conflicts, fix a few minor bugs prob caused by merging: 
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
 2018-07-03 16:40:07 -04:00
Thomas Hervey
8121f585d5 added checks for multiclick and click on notes 2018-07-03 15:39:22 -04:00
Thomas Hervey
61ae541cfc updated: notes save buttons 2018-07-03 10:57:53 -04:00
Bryan Housel
ab8e793a72 Playing with note styling, add avatars and more metadata 2018-07-03 02:41:47 -04:00
Bryan Housel
e0cc6260f5 Switch innerHtml to textContent, which properly unescapes xml 
This commit also fixes a linter error, and switches some
lodash _forEach to normal for loops.
 2018-07-02 23:22:00 -04:00
Bryan Housel
2d2845e5d4 If notes are coincident, move them apart slightly 2018-07-02 16:56:05 -04:00
Thomas Hervey
bd8705bf85 updated: reintroduced hovering on notes 2018-07-02 16:32:17 -04:00
Bryan Housel
7999aca9e2 Add getNode and replaceNote methods, refactor caches 2018-07-02 16:02:53 -04:00
Thomas Hervey
86dc0c9012 updated: new comments in notes sidebar ui 2018-07-02 15:51:55 -04:00
Bryan Housel
94eae89fc3 Merge, continue to tweak note_editor 2018-07-02 12:50:53 -04:00
Bryan Housel
a474e3bb9f Working on note editor style and ui, simplify d3 code 2018-07-02 12:35:07 -04:00
Thomas Hervey
2c22fe00a2 updated: hacky note hovering; todo: complete note click handling 2018-07-02 10:44:47 -04:00
Thomas Hervey
5b4dde0004 pulled updates from remote 2018-07-02 07:48:56 -04:00
Bryan Housel
13a30c050f Add some dots if there is a comment thread 2018-07-02 00:00:06 -04:00
Bryan Housel
535208beb5 Move tests to spec/services/osm.js and remove old notes.js files 2018-07-01 23:35:10 -04:00
Bryan Housel
00c8ff4f69 Don't add notes to the _seenEntity cache 
re: 229484a940 (commitcomment-29560519)
 2018-07-01 22:50:28 -04:00
Thomas Hervey
fc4d800c69 updated: pull from remote 2018-07-01 16:30:32 -04:00
Bryan Housel
487ec9d837 Better spinner event management 
re: https://github.com/openstreetmap/iD/pull/5107#issuecomment-401617938
 2018-07-01 12:48:51 -04:00
Bryan Housel
f3d31f3075 Update css styles for notes 
- open notes are red (default)
- resolved notes are green
- orange on hover
- yellow on select (also added centerEase to note location)
 2018-06-30 10:44:28 -04:00
Thomas Hervey
dcef11459f updated: notes caching 2018-06-30 08:08:12 -04:00
Thomas Hervey
eba9bde337 updated: pull from remote 2018-06-30 08:06:46 -04:00
Bryan Housel
2f8efee26a Draw 2x icons (shadow and fill) so they stand out more 2018-06-30 03:47:03 -04:00
Bryan Housel
229484a940 Cleanup osm service notes and caches, remove state variable 
This seems like a lot but the main things here are:
- remove the _loadingTiles "global" variable.  It was causing problems because
it was being checked from the callbacks, which are async.
- cleanup the caches
- use DOM API getElementsByTagName('id') to get note id
- set a lower tilezoom z13 for notes (meaning: fetch larger bounding boxes)
 2018-06-30 03:46:42 -04:00
Thomas Hervey
1b06dbd8c9 delete: demo select file (unintentional commit) 2018-06-29 23:36:11 -04:00
Bryan Housel
ede561080d Add update method, remove getters.. 
This makes the osmNote work a bit more like other osm objects in iD.

- When working with the osm objects, we'll treat them as immutable.
  So all modifications will be through the update method:

  e.g. can do this in a repl, like chrome devtools console:
  >  n = iD.osmNote()
  osmNote { id: -1 }
  > n = n.update({ foo: 'bar' });
  osmNote { foo: "bar", id: -1, v: 1 }

- none of the other osm objects have getters, and in JavaScript all the
  properties are public anyway
 2018-06-29 22:47:14 -04:00
Bryan Housel
fd1d2f006b Fix the osmNote initializer 2018-06-29 22:39:40 -04:00
Bryan Housel
d034691fb0 Merge remote-tracking branch 'origin/merge_notes_service' into notes 2018-06-29 22:11:39 -04:00
Bryan Housel
9517635d4d Merge branch 'master' into notes 2018-06-29 21:54:24 -04:00
Thomas Hervey
b3f7b06f66 merged: services/notes into /osm; todo: fix some caching & rendering 2018-06-29 20:01:30 -04:00
Thomas Hervey
737ccfcfba updated: siebar displays note details on hover (via svg) 2018-06-29 14:43:01 -04:00
john gravois
50c371f77b continue to catch 404s 2018-06-29 09:57:52 -07:00
john gravois
dd951a9b35 use 22 as maxZoom for Esri imagery (selectively) 2018-06-29 09:20:05 -07:00
Bryan Housel
d668f79407 Merge branch 'jgravois-tilemap' 2018-06-28 23:21:24 -04:00
Bryan Housel
b6fb3a345d Fetch Esri tilemap at high zoom to determine max zoom 
The tilemap is only fetched if the user is at z > 18 and will not fetch again
unless the user has moved more than 1km away from the previous fetch
 2018-06-28 23:20:08 -04:00
Bryan Housel
98e4fed829 v2.9.2 2018-06-28 19:02:06 -04:00
Bryan Housel
6ac9e4fff5 v2.9.1 2018-06-25 21:15:25 -04:00