Commit Graph

166 Commits

Author SHA1 Message Date
Bryan Housel
cbcafaee15 Make sure sidebar is expanded before entering walkthrough or saving
(closes #5574)
2018-12-08 10:03:43 -05:00
Bryan Housel
77a9dde6f7 Make sure combobox can always receive arrow and esc events 2018-12-05 15:59:06 -05:00
Bryan Housel
152022aec4 Use context.keybinding for keybindings that don't change
(closes #5487)
2018-11-13 20:57:21 -05:00
Bryan Housel
bb30cbf555 Move lib/d3.keybinding.js -> util/keybinding.js
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
Bryan Housel
3bc841e95b Adjust layer ordering to draw touch targets above data layers 2018-11-09 21:48:45 -05:00
Bryan Housel
a1dbdea725 Merge branch 'master' into flexbox-buttons 2018-11-07 10:13:40 -05:00
Bryan Housel
b860bbb5f0 Expand sidebar when selecting notes and data 2018-11-07 09:54:54 -05:00
Quincy Morgan
50d0b98be8 Adds undo messages for connecting points to points, vertices, lines, and areas; and vertices to sibling and adjacent vertices
Closes #1252
2018-11-05 17:50:15 -08:00
Quincy Morgan
510d7e93e5 Fixes two lint warnings for unused vars 2018-10-18 18:47:04 -07:00
Quincy Morgan
70c3d9cf24 Adding a new point on a way now adds a vertex, not a standalone point 2018-10-18 17:36:30 -07:00
Bryan Housel
f347346e70 Variable cleanups in intro 2018-09-06 14:32:09 -04:00
Bryan Housel
eba115803a Variable cleanups in behavior and modes 2018-09-06 09:50:26 -04:00
Bryan Housel
cc938698e8 Add ability to select custom data 2018-08-25 11:14:04 -04:00
Bryan Housel
f8f1c1f541 Ensure both notes and nodes can be dragged in selectNote mode 2018-08-09 23:25:06 -04:00
Bryan Housel
ff9e60d205 Submit note comments with cmd+enter
(closes #5193)
2018-08-07 10:05:12 -04:00
Bryan Housel
f74d21557c Force redraws after moving a note or cancelling a note
similar to 95ea0dbbc, there is no history change event to force a redraw
2018-07-24 19:34:01 -04:00
Bryan Housel
95ea0dbbc9 Force a redraw after adding a note
Because notes dont exist in the history or graph, there is no history change
event to trigger a redraw, as there would be when adding points and other things.
2018-07-24 19:14:34 -04:00
Bryan Housel
69ebb97815 Simplify drag_note mode 2018-07-24 17:17:24 -04:00
Bryan Housel
89ad643977 Let new note generate its own id, instead of using -1
Also stringify the note id (because existing notes from OSM are this way)
Also make sure comments is initialized as an Array not an Object
Also clarify some of the tests
2018-07-24 14:11:08 -04:00
Thomas Hervey
3abca299b5 cleaned unused vars 2018-07-24 09:17:12 -04:00
Thomas Hervey
e23ef4ba4a redraw on note drag. TODO: change dispatch call 2018-07-23 15:09:25 -04:00
Thomas Hervey
658721a150 WIP: added note category, TODO: update input 2018-07-21 19:36:13 -04:00
Thomas Hervey
373353f40d added breathe behavior & cleaned hover/select styling on notes 2018-07-21 15:54:47 -04:00
Thomas Hervey
ef6a5bdf85 merged from 'master', fixed typo 2018-07-21 11:02:01 -04:00
Thomas Hervey
06a410107b cleaned up merge relics and comments 2018-07-20 23:31:49 -04:00
Thomas Hervey
a6bdbcabb2 merged from 2018-07-20 23:21:24 -04:00
Thomas Hervey
fbedbb1608 select note before rendering sidebar 2018-07-20 23:17:41 -04:00
Thomas Hervey
bf9b19359a WIP drag note 2018-07-20 21:41:44 -04:00
Thomas Hervey
24579b15bc WIP testing new drag_notes mode 2018-07-20 14:26:02 -04:00
Thomas Hervey
5d779f2fc5 WIP: readded missing vars 2018-07-20 12:56:36 -04:00
Thomas Hervey
18def6e576 fixed accidental deletion move function 2018-07-20 12:10:50 -04:00
Thomas Hervey
1edd9ae92f WIP: added incomplete move note action 2018-07-20 12:08:26 -04:00
Thomas Hervey
42e24c13d9 WIP drag note 2018-07-19 18:34:15 -04:00
Thomas Hervey
14212b47fe WIP: drag note 2018-07-19 15:21:46 -04:00
Thomas Hervey
438756103d update checking if note is new 2018-07-18 17:11:17 -04:00
Thomas Hervey
87615c56c4 deselect selected notes on mode exit 2018-07-18 10:16:39 -04:00
Thomas Hervey
b017616993 added new note icon and completed sidebar 2018-07-18 09:38:59 -04:00
Thomas Hervey
af2b67663b added new-note button 2018-07-17 11:35:27 -04:00
Bryan Housel
57da729837 Implement note save button code 2018-07-12 23:50:29 -04:00
Bryan Housel
91add0c33e WIP on buttons, simplify, remove some event dispatch
- I made the buttons work like GitHub comment-on-issue buttons
before typing:  "Close Note" / "Comment" (disabled)
after typing:   "Close and Comment" / "Comment" (enabled)

- I removed a bunch of the event dispatches.  These are useful for sending
events to listeners/observers outside of the module.  In this case I think
we can handle most of the things from within the uiNoteEditor.  We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.

TODO - make the buttons work / check the OSM API stuff.
2018-07-11 23:10:01 -04:00
Bryan Housel
0d7c292c23 Refactor out uiNoteHeader and uiNoteComments into separate modules
uiNoteEditor was getting big!
2018-07-10 21:45:02 -04:00
Thomas Hervey
eafae6c58c WIP: update service calls; todo: note update event handling 2018-07-10 13:50:36 -04:00
Thomas Hervey
73ee5c2fc9 fixed select_note mode, cleaned note_editor, TODO: enable note save 2018-07-03 22:45:51 -04:00
Bryan Housel
bf499d9438 Restore modeSelect, and make a new modeSelectNote just for the notes 2018-07-03 18:11:59 -04:00
Bryan Housel
b14d1b5061 resolve conflicts, fix a few minor bugs prob caused by merging:
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00
Thomas Hervey
8121f585d5 added checks for multiclick and click on notes 2018-07-03 15:39:22 -04:00
Bryan Housel
de718002b9 Replace suburb with town on "thank you for editing near"
(closes #4989)
2018-05-13 16:30:12 -04:00
Bryan Housel
7a0d0352d2 Use connection.disabled to prevent dragging from breaking a relation
(closes #4921)
2018-04-14 23:12:53 -04:00
Bryan Housel
8fb083578f Prevent drag/connect which could damage relations
(closes #4921)
2018-04-12 17:32:16 -04:00
Bryan Housel
2ed2d79aef Thank the user for their contribution 2018-04-04 23:49:42 -04:00