Commit Graph

86 Commits

Author SHA1 Message Date
Bryan Housel 5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman 6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Max Grossman 64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman 8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman 96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
J Guthrie a23c975232 Fix specs 2018-11-24 21:27:20 +00:00
Bryan Housel 1731ce4651 Partition viewport by tiles, not by pixels
(closes #4297)

The previous approach split the viewport up by pixels, but each time the view
moved, the pixels would change, so it was not a stable selection of the
streetview data, and the markers would fight for position as the user moved
around.

This approach uses utilTiler to partition the view into stable tiles.
2018-11-14 14:48:42 -05:00
Bryan Housel b7df3eda38 Use new Mapillary API calls for map_features, image_detections
(closes #5374)
2018-11-07 23:09:11 -05:00
Bryan Housel a29af100df Remove test for unpopular values with a wiki page,
Restore test for unpopular keys with a wiki page
2018-11-07 11:06:48 -05:00
Mateusz Konieczny e285066032 invert tests for inverted behavior 2018-11-03 15:07:37 +01:00
Mateusz Konieczny bb054211c0 fix missing negation is specs 2018-11-03 14:26:52 +01:00
Bryan Housel 4cd442e09d Restore mapillary.js line endings back from CRLF -> CR, fix tests 2018-10-11 13:58:57 -04:00
Bryan Housel 0353b3110d Fix parse error in testing osm.js 2018-10-11 13:58:57 -04:00
Max Grossman 622b7b9e0c move validations to its own class
ref #remote-presets
2018-10-01 21:45:21 -04:00
Thomas Hervey 26f045b16c added/updated service/osm, osm/note, mode/add_note tests 2018-07-23 16:17:48 -04:00
Thomas Hervey 7ad765d408 added simple tests for loading and retrieving notes 2018-07-16 10:54:40 -04:00
Thomas Hervey bd1586500e added tests for notes service 2018-07-13 15:01:43 -04:00
Bryan Housel 535208beb5 Move tests to spec/services/osm.js and remove old notes.js files 2018-07-01 23:35:10 -04:00
Bryan Housel 9517635d4d Merge branch 'master' into notes 2018-06-29 21:54:24 -04:00
Bryan Housel 3943364852 Merge pull request #5106 from openstreetmap/remove_test_user_mocks
removed: user mocks from image service test specs
2018-06-26 21:11:23 -04:00
Thomas Hervey dab46d2778 updated: notes rendering 2018-06-22 17:43:07 -04:00
Bryan Housel 0c34ebdfed Dont fetch margin tiles when testing
(spy should be called 1 time, not 25 times)
2018-06-22 15:32:35 -04:00
Thomas Hervey db1c896ef2 removed: user mocks from image service test specs 2018-06-22 14:00:52 -04:00
Thomas Hervey e16b411576 added: first test (failing) 2018-06-21 15:26:05 -04:00
Bryan Housel 4458b94fc5 Add test coverage for streetside service
(closes #5081)
2018-06-19 23:09:06 -04:00
Bryan Housel e149c6be8e Remove old Mapillary signs code and assets
(closes #4145)
2018-06-07 01:35:12 -04:00
Bryan Housel b7997d3c64 Begin replacing mapillary signs html with svg spritesheet
(re: #4145)
2018-06-06 23:16:49 -04:00
Bryan Housel 9b705a6375 Don't call async callbacks after connection resets/switches
(closes #4288)
2017-11-14 21:30:01 -05:00
Bryan Housel 1dd437a1f2 Hide mapillary-js attribution and just handle it in iD
(closes #4526)

What we were doing before was d3.selecting the attribution line and
inserting the capture date into it. This was confusing the viewer
(which updates asynchronously) so that the sitelink would never update.
To make things easier, we'll just hide the viewer's built in attribution
and construct the attribution line the way we want it.
2017-11-14 11:32:42 -05:00
Bryan Housel 4571fd0563 Highlight selected/hovered streetview tracks, fade unselected
Also some code cleanups and nitpicky variable renames
More consistency in Mapillary/OpenStreetCam services
2017-11-08 00:35:44 -05:00
Bryan Housel 2947dcc2fb Add tests for Openstreetcam service and Mapillary sequences 2017-11-06 23:11:00 -05:00
Bryan Housel b3842d97f4 Remove lodash from the test suite
(closes #4378)
2017-10-18 14:37:39 -04:00
Bryan Housel b7d98b94fb loadEntity loadEntityVersion and loadMultiple all should ignore entityCache 2017-08-24 21:00:39 -04:00
Bryan Housel cd05c51432 loadEntity can use entityCache, but loadEntityVersion should not 2017-08-24 15:02:12 -04:00
Bryan Housel 99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Bryan Housel bde4d6510f Update mapillary tests 2017-07-14 00:53:44 -04:00
Bryan Housel b6c2645409 Add history urls to osm service and more URL tests 2017-06-30 00:52:05 -04:00
Bryan Housel 1c303edf18 Add generic reverse geocoder function to nominatim service 2017-06-29 01:23:33 -04:00
Bryan Housel 70d0a68c6d Use context.asset() to generate path to Mapillary image sprite 2017-06-09 10:53:48 -04:00
Bryan Housel 274552205d Merge pull request #4050 from mapillary/mapillary-api-v3
Update to Mapillary API v3 and add new traffic signs
2017-06-09 10:37:30 -04:00
Nikola Plesa 9c772a1058 Update to Mapillary API v3, use traffic signs from Mapillary sprites 2017-05-17 11:18:46 +02:00
Bryan Housel 62d0bc0bf5 Debounce should debounce all requests even cached, fix tests
(see https://github.com/openstreetmap/iD/pull/3975#issue-222747308)
2017-04-19 13:13:12 -04:00
Bryan Housel 1a8cfcc8b1 Changeset refactor
(closes #2633)

* move osmChangeJXON from osm service to osmChangeset
* cleanup putChangeset for code clarity
* adjust params for callbacks (pass changeset around instead of changeset_id)
* add commit.reset() to reset changeset object after successful save
* improve checks for changeset tags (trim whitespace, etc)
2017-03-15 11:03:43 -04:00
Bryan Housel d1aac857a4 Ignore server changesets with missing comment tag or empty comment 2017-03-11 14:28:30 -05:00
mstn 05e5cf9030 add type information to references 2017-03-02 11:26:14 +01:00
mstn 3205650798 order to-be-created relations by dependencies in a changeset 2017-03-02 09:17:08 +01:00
Bryan Housel d7416b2d0c Fix nominatim / geocoder test
(closes #3767)
2017-02-02 16:00:45 -05:00
Bryan Housel 94483af4c7 Fix service name nominatim -> geocoder 2017-01-17 16:46:41 +05:30
Bryan Housel a7ac44f6e8 Refactor imageryBlacklists so it can be called without triggering a GET
Previous code was problematic because we need the function to
to properly blacklist custom imagery passed in through the url hash,
before iD is completely initialized.  Triggering GET causes tests to
break because osm service testing has side effects :-/
2016-12-04 21:35:55 -05:00
Bryan Housel b9888e45e4 Add imageryBlacklists function to get blacklists from OSM API
(for #3623)
2016-12-03 19:25:07 -05:00