Commit Graph

96 Commits

Author SHA1 Message Date
Bryan Housel
222b3f1b04 Don't render contents of collapsed sections
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Tom Hughes
d617d9c588 Fix wikipedia UI tests to mock XHR instead of JSONP 2018-07-04 17:07:27 +01:00
Bryan Housel
f247bd1e66 Move icon code into uiFlash, default flash icon to icon-no
Previously it was up to the caller to draw whatever they want into the
footer flash.  With this change, uiFlash creates an icon and a text, so
the caller doesn't need to do as much work.
2017-12-05 23:41:34 -05:00
Bryan Housel
b3842d97f4 Remove lodash from the test suite
(closes #4378)
2017-10-18 14:37:39 -04:00
Bryan Housel
99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Bryan Housel
b7958415b3 Don't remove all the divs under body when testing 2017-08-09 22:02:58 -04:00
Bryan Housel
e8bd6bff6c Fix wikidata clearing, failed lookup when entity no longer selected
(closes #3987)
(closes #3684)
(related #3929)
2017-06-23 16:37:13 -04:00
Bryan Housel
3b54743f86 Add more d3.timerFlush to avoid false test failures (hopefully) 2017-04-24 16:15:41 -04:00
Bryan Housel
b803730a4b More modal and confirm tests, d3.timerFlush to avoid false failures 2017-04-24 14:57:47 -04:00
Bryan Housel
5f44c9a00a Add combobox menus to id-container instead of document.body
(re: https://github.com/openstreetmap/iD/issues/3925#issuecomment-290718356)
2017-03-31 13:44:55 -04:00
Bryan Housel
48d1b0b28e .wiki-link is now a button so we can't test href attribute 2017-03-22 02:50:27 -04:00
Bryan Housel
e9b8b743e7 Update sinon and sinon-chai dependencies 2017-03-21 16:25:29 -04:00
Bryan Housel
3908da03cf Fix styling of flash and footer and use absolutely positioned divs
Also fix flash tests
2017-02-17 00:23:24 -05:00
Bryan Housel
c18cc7577d Add flash test, avoid using sinon.useFakeTimers in tests.
sinon.useFakeTimers mocks setInterval, setTimeout, etc,
but not requestAnimationFrame, which d3 transitions rely on.
2017-02-11 00:19:49 -05:00
Bryan Housel
9b7d79a3fe Use live bound object for presets object, change context.presets() getter 2016-11-14 15:44:02 -05:00
Bryan Housel
f800e5afbc Remove unnecessary window parameter to Context 2016-11-10 15:19:03 -05:00
Bryan Housel
b2c8f72c95 no-native-reassign -> no-global-assign 2016-10-29 14:42:04 -04:00
Bryan Housel
e83b2ea2be Allow delete key without modifier as shortcut for deleting
(closes #3455)

Also fixed a minor bug in `iD.uiCmd` that was causing keyboard shortcuts
like '⌘⌫' to convert to 'Ctrl+Backspace+'  (note extra trailing '+')
It affected only the tooltip display, not the key event binding.
2016-10-24 23:57:44 -04:00
Bryan Housel
1d03414b80 Allow forced utilDetect(), useful for testing 2016-10-18 21:56:24 -04:00
Bryan Housel
87950fd472 Fix lib export, flatten names in tests and docs 2016-10-04 21:56:09 -04:00
Bryan Housel
4522d8f89a Add some namespaces to test labels 2016-09-12 21:40:00 -04:00
Bryan Housel
482b4d7cbe mock userAgents in a way that works in both Phantom and real browsers 2016-09-09 14:59:55 -04:00
Tom MacWright
a28e24bb4c Fix lints 2016-09-06 17:29:03 -04:00
Tom MacWright
6bfe6a8640 Down to 7 test failures 2016-09-06 11:16:47 -04:00
Tom MacWright
2b366b5f78 Fix access field 2016-09-06 10:06:28 -04:00
Tom MacWright
92f2908ffe Fix wikipedia 2016-09-05 21:48:22 -04:00
Tom MacWright
6189af9b47 fix localized 2016-09-05 21:40:41 -04:00
Tom MacWright
cb50b7b03a Fix raw tag editor tests 2016-09-05 21:30:21 -04:00
Tom MacWright
e659bd75e9 Fix assumption that [0] contains the nodes 2016-09-04 18:19:02 -04:00
Tom MacWright
0236389611 Fix Circularize logic 2016-09-03 19:33:19 -04:00
Bryan Housel
5a045933c6 Rename confirm -> uiconfirm and import to save.js
(closes #3373)
2016-08-24 16:03:23 -04:00
Tom MacWright
6341d4e4b5 one-shot build (#3266)
* One-shot development

* Move jsonp to module
* Tooltip -> module
* Remove d3.jsonp
* Fix tooltip lint
* Load all libs but d3 itself with require
* Add top-level brfs

* Unformat intro graph
2016-08-10 15:25:19 -07:00
Tom MacWright
af776501d3 Require locale, second pass (#3259)
* Require locale, second pass

* Remove t global, remove t where it isn't needed
2016-07-21 16:20:13 -04:00
Bryan Housel
7ca6d06254 Replace iD global with iD.Context() module (#3254) 2016-07-19 10:15:32 -04:00
Bryan Housel
cb71e90384 Module for iD.Detect() (#3243)
* convert iD.Detect() iife to a module

* iD.Detect() should return loaded locale (except for 'en')

(The previous code was a hack to replace the detected locale with the loaded
locale.  Now that Detect is a module, we can not replace the detected locale
from external code, but we can have Detect() return the locale we really want)
2016-07-13 09:15:47 -04:00
Bryan Housel
5e57ff0771 Fix eslint ; 2016-07-11 12:59:44 -04:00
Tom MacWright
d7a89a41d2 Stub jsonp 2016-07-11 12:08:43 -04:00
Tom MacWright
e30d5f3299 Fix references to iD 2016-07-05 17:58:34 -04:00
Kushan Joshi
477d446772 final touch up 2016-07-06 01:05:21 +05:30
Kushan Joshi
4b2431a4e3 Remove linting error spec/ui 2016-06-15 18:26:11 +05:30
Bryan Housel
db6234b2fc Initiate async wikidata lookup onchange only (not onblur), add tests 2016-05-26 16:16:37 -04:00
Bryan Housel
0135fbe4a6 Update async wikidata tag if graph unchanged 2016-05-25 23:43:27 -04:00
Minh Nguyễn
669cad74f6 Add wikidata asynchronously based on wikipedia
ref #2680
2016-05-23 19:16:02 -04:00
Kushan Joshi
6ef52256f3 Migrating to lodash v4 2016-05-17 12:37:25 +05:30
Kushan Joshi
4f328f6bfb change http to https
(closes #2960)

Interim
2016-02-04 21:42:38 +05:30
Bryan Housel
b365a2062c Handle multi-character keys in iD.ui.cmd (closes #2786) 2015-09-27 21:28:04 -04:00
Bryan Housel
dc9f29fd09 Use stricter regex for localized field key (closes #2658)
Now it will no longer match `old_name`
2015-09-18 10:22:39 -04:00