CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,180 Commits 2 Branches 0 Tags
7cd57789fe4a06a2ee2f718f4da853b4268ab5db
Commit Graph

303 Commits

Author SHA1 Message Date
Quincy Morgan
7cd57789fe Improve "add a bridge/tunnel" fix variable names somewhat (re: #7055) 
Add a minimum structure length as derived from the crossing feature's width
 2019-11-20 16:58:42 -05:00
Quincy Morgan
ff6eb88957 Update add a bridge/tunnel fix icons 2019-11-20 16:04:10 -05:00
Quincy Morgan
e791b7514c Use existing vertices for "add a bridge/tunnel" endpoints if the edge is too short to add a new vertex (re: #7055) 
Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
 2019-11-20 15:44:14 -05:00
Quincy Morgan
5640d7867a Simplify some "add bridge or tunnel" fix code (re: #7055) 
Add endpoint to actionSplit to get the created ways after running the action
Change "Use bridge" or "tunnel" fix labels to "Add a bridge" or "tunnel"
Add layer tags on structure feature when adding a bridge or tunnel via a fix
Select all components of the split way when adding a bridge or tunnel via a fix
Don't recommend adding a bridge to a waterway
Don't show "change layers" fixes along with "add structure" fixes
Don't split or change the tags of coincident ways when adding a bridge or tunnel
 2019-11-20 13:09:27 -05:00
Katarzyna Król
5ed22cce21 create bridge or tunnel when crossed ways 2019-11-20 12:54:43 -05:00
Quincy Morgan
d2c73f8a86 Restore fixes for very close vertices issues 2019-11-18 12:07:48 -05:00
Quincy Morgan
96c8bcb152 Add tooltip to delete feature fix explaining if it's disabled (close #6588) 2019-11-13 14:52:57 -05:00
Quincy Morgan
24c72b64d1 Load issue fixes dynamically instead of cacheing them (close #7037) 2019-11-13 14:35:01 -05:00
Quincy Morgan
c32cca2a71 Add additional comment to close nodes validation 2019-11-11 15:34:55 +01:00
Quincy Morgan
bc39b0eb25 Don't flag nonstandard brands with a matching not:brand:wikidata tag (close #6577) 2019-11-11 14:56:05 +01:00
Quincy Morgan
40edee1275 Don't flag very close nodes with different house or unit numbers (close #6998) 2019-11-11 13:40:37 +01:00
Quincy Morgan
e85b6b9c45 Include default field values when upgrading a preset with a specific replacement (close #7033) 2019-11-11 13:25:49 +01:00
Quincy Morgan
538829d171 Don't flag nonstandard brands from incompatible countries (close #6513) 2019-11-07 19:08:50 +01:00
Bryan Housel
3886f2dad8 Merge branch '2.15-building-crossing-layers' into 2.x 2019-10-24 15:15:06 -04:00
Quincy Morgan
769c95af55 Add non-actionable fix suggestion for "Fix Me" request issues 2019-10-14 11:03:49 +02:00
Quincy Morgan
56f31adcf1 Always sort the entity issues list deterministically 
Don't skip validations just because a different validation produced issues
 2019-10-12 17:01:03 +02:00
Quincy Morgan
abd94a940f Show non-actionable "Connect this feature" fix for disconnected roads and paths with both ends as noexits 
Correctly reverse the "continue" fix icons for the right-to-left layout
 2019-10-11 17:04:45 +02:00
Quincy Morgan
d7bde50649 Locate impossible way issues at the questionable node, not at the center of the way's extent 2019-10-10 15:08:54 +02:00
Quincy Morgan
bd1e1b34ff Add subtypes to crossing_ways validation warnings 
Allow the `indoor` tag to indicate a crossing feature is indoors
 2019-10-09 15:24:42 +02:00
Quincy Morgan
a3d6097d40 Rename "Fix Me" Requests validation rule to more general Help Requests 
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100)
 2019-10-09 15:00:28 +02:00
Quincy Morgan
d57807478e Start validation documentation (re: #6100) 
Add subtypes to close_nodes and unsquare_way validations
 2019-10-09 12:43:38 +02:00
Quincy Morgan
7251a2ab90 Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user" 
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459)
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658)
Don't cache crossing ways issues at the rule level
 2019-10-04 16:50:44 +02:00
Quincy Morgan
badde3d583 Add warning for features with names that equal values in their not:name tag (close #6411) 2019-10-04 11:06:27 +02:00
Quincy Morgan
f5995dffb0 Cherry pick crossing buildings fix 2019-10-03 20:09:49 +02:00
Quincy Morgan
0dc890a9ee Show more specific message when nonstandard brand has simply incomplete tags (close #6909) 2019-10-03 15:25:18 +02:00
Quincy Morgan
9ccace9022 Don't warn about websites missing http:// or https:// (close #6831) 2019-10-01 18:34:20 +02:00
Quincy Morgan
6a515576f1 Add an "Extract this point" quick fix for points-as-vertices validation warnings (re: #6319) 2019-10-01 18:21:03 +02:00
Quincy Morgan
525916da74 Recategorize tags_suggests_area validation rule into mismatched_geometry rule 
Warn about points tagged as vertices and vertices tagged as points (close #6319)
 2019-09-26 10:56:30 +02:00
Quincy Morgan
b8b8c66d02 Warn when multilingual feature names appear to be generic (close #6876) 2019-09-24 13:22:02 +02:00
Quincy Morgan
1abcc7fccf Show warning for elevator nodes that are disconnected from the highway network (close #6812) 
Simplify disconnected way validation code
 2019-09-13 15:17:48 -04:00
Quincy Morgan
16747cf888 Cherry pick generic brand name fix 2019-08-15 13:49:02 -05:00
Quincy Morgan
070cfec7c7 Specify that connecting waterways and highways with the fix will add a ford (close #6734) 2019-08-09 09:34:35 -05:00
Quincy Morgan
5984f6b118 Don't flag google books as an incompatible data source (close #6556) 2019-07-09 09:58:39 -04:00
Quincy Morgan
8003e7b3d3 Allow the layer and level tag to differentiate very close points (close #6612) 2019-07-05 10:17:15 -04:00
Bryan Housel
ca2c6b1098 Allow for some tags (takeaway) to be kept thru a NSI upgrade 
(closes #6530, closes #6581)
 2019-06-30 01:42:43 -04:00
Bryan Housel
2307125842 Remove existing NSI keys before upgrading to a NSI preset 
(closes #6575)
 2019-06-30 01:24:42 -04:00
Quincy Morgan
b10ae96d62 Don't suggest adding nonsquare=yes to physically unsquare buildings (close #6332) 2019-06-16 18:47:32 -04:00
Quincy Morgan
67f7995559 Avoid stale "connect endpoints" fix for "tags imply area" that could cause invalid areas (close #6525) 
Lower match score for man_made/bridge preset
 2019-06-12 09:31:06 -04:00
Quincy Morgan
2eff493d37 Add outdated tags validation issue subtype for noncanonical brands 
Add specific warning message for noncanonical brands (close #6443)
Don't allow autofixing noncanonical brand issues
 2019-06-10 11:39:42 -04:00
SilentSpike
f402748706 Fix email validation for unicode characters 
Also fix format validation for lists with excess whitespace (6494#issuecomment-499620002).
 2019-06-10 11:02:56 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
SilentSpike
0b8ddd9240 Fix email and website validation for empty values 2019-06-06 13:55:53 -04:00
SilentSpike
f02238ce23 Fix varied validation messages and redeclaration 
I've hijacked the data property for the purposes of changing the message
based on whether multiple values in a list are erroneous
 2019-06-06 13:55:53 -04:00
SilentSpike
591e41f5ec Fix email and website validation for list values 
Also improved the UI message to be more clear for websites and simplify
"is tagged with" to "has" which works in context.
 2019-06-06 13:55:53 -04:00
SilentSpike
770cffe7de Add email and website format validation 
Simple validation following the HTML5 standard for emails as we don't
expect POIs to have convoluted email addresses. Only checks the
`website` and `email` tags as these are what iD currently supports with
fields.
 2019-06-06 13:55:53 -04:00
Bryan Housel
44349c8015 Swap wikidata/wikipedia for brand: tags if possible 
(closes #6416)

This also ignores any features with an office tag, to avoid
changing a wikipedia/wikidata tag on a corporate office.
 2019-05-24 14:24:10 -04:00
Bryan Housel
149a0b43b3 Use latest entity at time of fix for private_data validation too 
(re: #6407)
 2019-05-23 19:40:10 -04:00
Bryan Housel
5440467db0 Undo 5b8db55b4 and instead get latest entity at time of fix 
Per conversation w @quincylvania we need the issue ids to remain
stable so that users can ignore them.

So instead of forcing a refresh by changing the `id` we will grab current
versions of entities at fix time so that tags aren't replaced wrongly.
 2019-05-23 18:52:32 -04:00
Bryan Housel
5b8db55b47 Need issue id to actually change for d3 to replace it 
(re: #6407)

What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.

Need to review all the validators to see if others have this problem too.
 2019-05-22 23:47:53 -04:00
Quincy Morgan
28db4df86b Flag detached points that are very close together (close #6394) 
Fix lint error
 2019-05-22 15:50:20 -04:00