Commit Graph

34 Commits

Author SHA1 Message Date
Bryan Housel
ac86869b4a Add conflict checking progress, guard code for user authentication 2018-01-05 18:11:49 -05:00
Bryan Housel
a63c4a72fe Improvements to save flow
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056)
- Block reentry of save, and dont keep focus on save button (closes #4641)
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
2018-01-05 15:11:44 -05:00
Bryan Housel
437893ebb8 Don't reenter putChangeset, allow reuse of open changeset id
We are going to start trying an opportunistic save, then only
start the conflict resolution stuff if the server returns a 409.
Reusing an already open changeset makes sense in this situation.
2018-01-04 23:27:00 -05:00
Bryan Housel
2e2b037e36 Move a bunch of commonly used vector and projection math functions into geo
- geoVecAdd
- geoVecSubtract
- geoVecScale
- geoZoomToScale
- geoScaleToZoom
2017-12-18 15:05:42 -05:00
Bryan Housel
9b705a6375 Don't call async callbacks after connection resets/switches
(closes #4288)
2017-11-14 21:30:01 -05:00
Bryan Housel
50da78c1fd Convert lodah-es and d3 to named imports for services 2017-09-25 15:10:47 -04:00
Bryan Housel
b7d98b94fb loadEntity loadEntityVersion and loadMultiple all should ignore entityCache 2017-08-24 21:00:39 -04:00
Bryan Housel
cd05c51432 loadEntity can use entityCache, but loadEntityVersion should not 2017-08-24 15:02:12 -04:00
Bryan Housel
cabc98649f Clear entity id cache on reset() 2017-08-24 13:10:51 -04:00
Kushan Joshi
82686b10a5 Add requestIdleCallback 2017-08-22 17:38:42 +05:30
Kushan Joshi
442f0831b1 add enitity cache 2017-08-21 15:56:50 +05:30
Bryan Housel
b6c2645409 Add history urls to osm service and more URL tests 2017-06-30 00:52:05 -04:00
Bryan Housel
fdd6b329a8 Get changeset, timestamp, uid for all elements; changeset_count for users 2017-06-29 22:02:54 -04:00
Bryan Housel
1a8cfcc8b1 Changeset refactor
(closes #2633)

* move osmChangeJXON from osm service to osmChangeset
* cleanup putChangeset for code clarity
* adjust params for callbacks (pass changeset around instead of changeset_id)
* add commit.reset() to reset changeset object after successful save
* improve checks for changeset tags (trim whitespace, etc)
2017-03-15 11:03:43 -04:00
Bryan Housel
d1aac857a4 Ignore server changesets with missing comment tag or empty comment 2017-03-11 14:28:30 -05:00
Bryan Housel
a1323e482e Change putChangeset to create osmChangeset and asJXON 2017-03-11 14:12:34 -05:00
Bryan Housel
e0157f48ac Merge pull request #3871 from mstn/3208-cant-create-a-new-master-relation
Order to-be-created relations by dependencies in the changeset
2017-03-11 01:05:11 -05:00
mstn
05e5cf9030 add type information to references 2017-03-02 11:26:14 +01:00
mstn
3205650798 order to-be-created relations by dependencies in a changeset 2017-03-02 09:17:08 +01:00
Bryan Housel
be07dcccdf Always access OSM over https now
If you were logged in before, you might need to logout with
`id.connection().logout()` or delete the OAuth data from localStorage
2017-03-02 00:54:24 -05:00
Bryan Housel
3246ca176f Eagerly load user's details and changesets
(closes #3787)

Also, don't redo authentication in save.js if user is already authenticated
2017-01-22 12:43:39 -05:00
Milad Karbasizadeh
3ef1103c3a Remove signs of real_name ever existed. 2017-01-03 21:57:29 +03:30
Milad Karbasizadeh
5da7d83fe9 Modify railways arabic/persian names 2017-01-03 16:34:57 +03:30
Nick Doiron
94ee7d4916 move changes to svg display name 2017-01-03 18:18:18 +08:00
Milad Karbasizadeh
af1ac89df7 Rename fix-string.js and fixTextForSvg function name to a more readable name.
User regex to detect arabic characters.

Fix editing bugs.
2017-01-02 14:48:22 +03:30
Milad Karbasizadeh
92b5ce133d fix persian characters on chrome and safari 2017-01-01 15:41:47 +03:30
Bryan Housel
a7ac44f6e8 Refactor imageryBlacklists so it can be called without triggering a GET
Previous code was problematic because we need the function to
to properly blacklist custom imagery passed in through the url hash,
before iD is completely initialized.  Triggering GET causes tests to
break because osm service testing has side effects :-/
2016-12-04 21:35:55 -05:00
Bryan Housel
b9888e45e4 Add imageryBlacklists function to get blacklists from OSM API
(for #3623)
2016-12-03 19:25:07 -05:00
Bryan Housel
9bf6c25bde Clear saved rate limit error when calling reset() 2016-11-09 17:58:25 -05:00
Bryan Housel
16ada1f29a Better error handling for common osm api error conditions
* if 509 Bandwidth Exceeded / 429 Too Many Requests, prompt for login
(closes #2262)
* if 400 Bad Request / 401 Unauthorized / 403 Forbidden - logout and retry
(closes #3546)
2016-11-08 21:43:27 -05:00
Bryan Housel
a601ccc0c9 Use osm-auth 1.0.1, make authenticated OSM API calls
(re: #2262)
2016-10-24 18:40:52 -04:00
Bryan Housel
45d85e04c5 Make authenticated api calls if possible 2016-10-24 01:21:38 -04:00
Bryan Housel
e81b6e626a WIP: authenticate OSM API calls if user is logged in 2016-10-22 12:17:52 -04:00
Bryan Housel
b5c95af3b7 Refactor from coreConnection to serviceOsm
(closes #3497)
2016-10-19 09:25:34 -04:00