CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,714 Commits 2 Branches 0 Tags
82281ea4bbd35652cff4dbf9d0db586dc30ca150
Commit Graph

267 Commits

Author SHA1 Message Date
Quincy Morgan
b10ae96d62 Don't suggest adding nonsquare=yes to physically unsquare buildings (close #6332) 2019-06-16 18:47:32 -04:00
Quincy Morgan
67f7995559 Avoid stale "connect endpoints" fix for "tags imply area" that could cause invalid areas (close #6525) 
Lower match score for man_made/bridge preset
 2019-06-12 09:31:06 -04:00
Quincy Morgan
2eff493d37 Add outdated tags validation issue subtype for noncanonical brands 
Add specific warning message for noncanonical brands (close #6443)
Don't allow autofixing noncanonical brand issues
 2019-06-10 11:39:42 -04:00
SilentSpike
f402748706 Fix email validation for unicode characters 
Also fix format validation for lists with excess whitespace (6494#issuecomment-499620002).
 2019-06-10 11:02:56 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
SilentSpike
0b8ddd9240 Fix email and website validation for empty values 2019-06-06 13:55:53 -04:00
SilentSpike
f02238ce23 Fix varied validation messages and redeclaration 
I've hijacked the data property for the purposes of changing the message
based on whether multiple values in a list are erroneous
 2019-06-06 13:55:53 -04:00
SilentSpike
591e41f5ec Fix email and website validation for list values 
Also improved the UI message to be more clear for websites and simplify
"is tagged with" to "has" which works in context.
 2019-06-06 13:55:53 -04:00
SilentSpike
770cffe7de Add email and website format validation 
Simple validation following the HTML5 standard for emails as we don't
expect POIs to have convoluted email addresses. Only checks the
`website` and `email` tags as these are what iD currently supports with
fields.
 2019-06-06 13:55:53 -04:00
Bryan Housel
44349c8015 Swap wikidata/wikipedia for brand: tags if possible 
(closes #6416)

This also ignores any features with an office tag, to avoid
changing a wikipedia/wikidata tag on a corporate office.
 2019-05-24 14:24:10 -04:00
Bryan Housel
149a0b43b3 Use latest entity at time of fix for private_data validation too 
(re: #6407)
 2019-05-23 19:40:10 -04:00
Bryan Housel
5440467db0 Undo 5b8db55b4 and instead get latest entity at time of fix 
Per conversation w @quincylvania we need the issue ids to remain
stable so that users can ignore them.

So instead of forcing a refresh by changing the `id` we will grab current
versions of entities at fix time so that tags aren't replaced wrongly.
 2019-05-23 18:52:32 -04:00
Bryan Housel
5b8db55b47 Need issue id to actually change for d3 to replace it 
(re: #6407)

What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.

Need to review all the validators to see if others have this problem too.
 2019-05-22 23:47:53 -04:00
Quincy Morgan
28db4df86b Flag detached points that are very close together (close #6394) 
Fix lint error
 2019-05-22 15:50:20 -04:00
Quincy Morgan
030b4b3efa Flag almost junctions between highways and themselves (close #6373) 2019-05-22 14:12:23 -04:00
Quincy Morgan
82ab18dd8b Show better warning message if tags and incomplete rather than deprecated (close #6410) 2019-05-22 09:38:47 -04:00
Quincy Morgan
9a8623748f Don't flag private data only buildings that are also offices (close #6404) 
Flag private data on building=houseboat
 2019-05-22 08:40:48 -04:00
Quincy Morgan
460f136819 Lower default threshold for unsquare building detection to 5 degrees 
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
 2019-05-20 15:48:01 -04:00
Quincy Morgan
39784cdd1f Merge in master 2019-05-20 14:38:52 -04:00
Quincy Morgan
e599488121 Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374) 
Flag very close nodes in indoor features but with an extremely small threshold
 2019-05-20 11:21:50 -04:00
Bryan Housel
0f387c9fcd Include office key for name-suggestion-index matching 
In anticipation of https://github.com/osmlab/name-suggestion-index/issues/2634
 2019-05-19 21:42:57 -04:00
Bryan Housel
0982379187 Don't offer to upgrade brands without a brand:wikidata tag 2019-05-19 00:16:05 -04:00
Bryan Housel
511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Bryan Housel
f062570eef Merge pull request #6376 from openstreetmap/routing-island-validation 
Flag routing islands
 2019-05-17 10:21:51 -04:00
Bryan Housel
7a07506edc Skip ambiguous matches (like Target~(USA) vs Target~(Australia)) 
This also reorders the nsiKeys array to maybe match slightly quicker
 2019-05-17 09:45:08 -04:00
Bryan Housel
8d0fa289cf Include name-suggestion-index matcher in outdated_tags validator 2019-05-17 01:58:57 -04:00
Quincy Morgan
e697bdbeb1 Flag disconnected ferry routes 
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
 2019-05-17 00:15:53 -04:00
Quincy Morgan
07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Quincy Morgan
93a475c9a2 Correct issue with almost junction layer handling 2019-05-14 16:48:24 -04:00
Quincy Morgan
99565e8457 Don't flag crossing waterways and pier highways 2019-05-14 15:39:04 -04:00
Quincy Morgan
a9c30e840c Revalidate immediately after running most fixes (close #6354) 
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
 2019-05-14 14:41:07 -04:00
Quincy Morgan
4eedfa8b25 Don't allow autofixing unsquare buildings unless they are already very close to square 
Allow autofixing buildings with tags
 2019-05-13 16:28:08 -04:00
Quincy Morgan
bb4aa84a3b Don't flag almost junction issues between features on different layers or levels (close #6355) 2019-05-13 13:03:34 -04:00
Quincy Morgan
36a564f453 Add explicit check for very close nodes with an identical location 2019-05-10 12:14:29 -04:00
Quincy Morgan
8de10def2a Use actionMergeNodes instead of operationMerge for the very close nodes issue fix (close #6343) 2019-05-10 09:12:11 -04:00
Quincy Morgan
ad744a75ef Use "nonsquare" instead of "nosquare" for marking unsquare ways as physically unsquare (re: #6332) 2019-05-09 19:11:11 -04:00
Quincy Morgan
7b441ab766 Don't flag unsquare buildings connected to building multipolygons 2019-05-09 18:06:40 -04:00
Quincy Morgan
58e6afd3ea Don't flag very close nodes in boundaries 2019-05-09 17:50:22 -04:00
Quincy Morgan
f264cc47f0 Don't flag almost junctions when endpoint is building or parking entrance 
Include issues for disabled rules in entity issues
 2019-05-09 14:38:19 -04:00
Quincy Morgan
0e7a63f5c5 Add quick fix to unsquare way validation to tag a way as having unsquare corners (close #6332) 2019-05-09 12:04:18 -04:00
Quincy Morgan
399b9be006 Don't flag very close nodes in ways with too few nodes, indoor ways, and very small ways 2019-05-08 17:15:18 -04:00
Quincy Morgan
fd8f460739 Don't flag oneway highways that connect to highway areas or ferry routes as impossible 
Don't flag oneway waterways that connect to springs, storm drains, water bodies, or coastlines as impossible
 2019-05-08 15:36:37 -04:00
Quincy Morgan
3a78cf512c Move connect ways fix to its own function 
Make the edges and connection tags part of the crossing ways issue ID
 2019-05-08 10:32:25 -04:00
Quincy Morgan
73467d53b4 Don't flag highways connected to amenity=parking_entrance nodes as disconnected 
Don't flag oneways with entrance endpoints as impossible
 2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
fd35e10aa7 Make the very close nodes validation work for any way (close #6326) 2019-05-07 12:28:59 -04:00
Bryan Housel
7551dd9093 fix typo 2019-05-06 13:04:00 -04:00
Bryan Housel
e3ea4b8484 Additional improvements to unsquare_way validation 
(re: #6288)

- use default params for actionOrthogonalize, not relaxed epsilon
- only allow autofix if there are no extra tags on the building (e.g. source)
 2019-05-06 12:58:40 -04:00
Bryan Housel
4608e9598c Adjust thresholds for unsquare_way detection 
(re: #6288)

I'd like to keep the angle threshold the same as what the action does
for UI consistency, but use a larger epsilon, so that fewer nearly-orthogonal
errors are reported.

With previous constants, it was strange that very orthogonal buildings
were being flagged, and very not-orthogonal buildings were not.
 2019-05-06 11:42:57 -04:00
Bryan Housel
59c34e2537 Perform orthagonalization fixes without a transition 
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
 2019-05-06 10:23:30 -04:00