Commit Graph

10299 Commits

Author SHA1 Message Date
SilentSpike a566d58f81 Fix error on ImproveOSM issues with no comments 2019-02-05 21:48:06 +00:00
SilentSpike 0346d8060f Retrieve ImproveOSM comments only once
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
2019-02-05 21:46:17 +00:00
Bryan Housel b87ae4e98b Exclude existing keys from auto-completion in raw tag editor
(closes #3625)
2019-02-05 16:14:18 -05:00
SilentSpike 78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
SilentSpike c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike 5fc87fb0a4 Pacify eslint
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
SilentSpike f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike fa87ed75ae Display ImproveOSM comments oldest to newest 2019-02-05 19:57:22 +00:00
SilentSpike 2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel 51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing
(closes #5857)
2019-02-05 14:52:13 -05:00
SilentSpike 28bb12b7ae Add function to retrieve ImproveOSM comments
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
Chad Rockey c34f010e05 Remove golf tags 2019-02-05 10:44:20 -08:00
Chad Rockey 0bc5c13b88 Cleanup according to comments 2019-02-05 09:14:07 -08:00
SilentSpike 448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Bryan Housel 13e9e99c4a Allow "Monitoring Station" preset on vertex geometry
(closes #5827)
2019-02-05 11:21:37 -05:00
Bryan Housel 5c10aa397f Merge branch 'SilentSpike-unify' 2019-02-05 11:18:19 -05:00
Quincy Morgan 23ab1b66fb Revert "Update places of worship to use field inheritance"
This reverts commit 44d4f2378d.
2019-02-05 11:06:31 -05:00
Bryan Housel e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
Quincy Morgan 7763626b02 Add access_simple field to library preset
Update Website field placeholder to use https
2019-02-05 10:22:43 -05:00
Quincy Morgan 44d4f2378d Update places of worship to use field inheritance
Add website to defaults fields for places of worship
Add presets for common place of worship denominations
2019-02-05 10:16:22 -05:00
greenkeeper[bot] 91285bc4f0 chore(package): update esm to version 3.2.1 2019-02-05 10:00:15 -05:00
Chad Rockey d3afa9449e Add driving range preset 2019-02-04 22:29:06 -08:00
Chad Rockey a7955bc3f9 Presets for golf paths and cartpaths 2019-02-04 21:14:17 -08:00
SilentSpike b55830485d Fix use of old variable name 2019-02-04 22:55:47 +00:00
SilentSpike 781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
Bryan Housel b340b65df4 Improve "club" icons
(closes #5854)
2019-02-04 13:35:12 -05:00
Bryan Housel 002f3ba590 switch far-clock to temaki-clock (one less clock icon) 2019-02-04 13:16:19 -05:00
SilentSpike ddf44377e8 Fix errors without templates not working 2019-02-04 18:12:21 +00:00
Bryan Housel 2d7800582f Upgrade FontAwesome to 5.7 2019-02-04 13:06:51 -05:00
Bryan Housel 7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
SilentSpike d7147996ed Merge remote-tracking branch 'upstream/master' into unify 2019-02-04 17:17:17 +00:00
SilentSpike 450c549ea5 Remove old error type files 2019-02-04 16:54:07 +00:00
SilentSpike 40af841d53 Fix sidebar preview for new generic errors 2019-02-04 16:54:07 +00:00
SilentSpike 3ed13e9a4a Convert KeepRight to use generic error type 2019-02-04 16:54:07 +00:00
SilentSpike 20ed8b50c9 Add generic QA error
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.

Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
Bryan Housel 3efd8dbe2d Merge pull request #5852 from AndreasHae/5844-lanes-preset-usability
Improve number field usability
2019-02-04 10:11:03 -05:00
Andreas Haessler 82ea58d943 Add default value to number field 2019-02-04 15:59:08 +01:00
Bryan Housel e4e0d9d13a Add oneway icon for ImproveOSM oneway markers 2019-02-03 23:55:16 -05:00
Bryan Housel ebdf6431f7 Support classing of aerialway and piste, and adjust line widths
(closes #5843)
2019-02-02 15:32:36 -05:00
Bryan Housel f1b5efc81a Revise the list of oneway aerialways (notably, drop yes)
(re: #5843)
2019-02-02 15:30:42 -05:00
Bryan Housel 96a15934ca Don't snake_case values for destination and destination:ref fields
(closes #5842)

But continue to snake_case the values for `destination:symbol`
2019-02-02 12:05:19 -05:00
Bryan Housel 6be72709d5 Adjust tag_classes perimeter overrides to style barriers as lines
(closes #5761)
2019-02-02 11:52:23 -05:00
Bryan Housel 3f2abbe7c6 Merge pull request #5739 from SilentSpike/ImproveOSM
Add ImproveOSM Q/A Layer
2019-02-01 20:03:36 -05:00
SilentSpike 9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
SilentSpike c9e249ee6c Send only relevant query parameters 2019-02-01 23:14:54 +00:00
Max Grossman b7786fd081 if on address interpolation, match and don't look through keys...
ref #5811
2019-02-01 17:58:15 -05:00
SilentSpike e9397aa14f Fix incorrect usage of osm.userDetails callback
Javascript is not my usual domain so still getting used to how scope
works and working with callbacks. Believe this code is now written as
intended.

As a bonus a response status to the error update request which isn't the
expected 200 now returns before visibly removing the error and adding it
to the closed cache.
2019-02-01 22:51:05 +00:00
SilentSpike 03a5c26e74 Refer to ImproveOSM QA as detections 2019-02-01 22:51:05 +00:00
SilentSpike 21824e6377 Fix coincident errors
Potential for multiple missing turn restrictions on one node and I've
also seen a case of missing one-way along the same stretch of road in
opposite directions!

Missing geometry is tile based so can't really be coincident, but
doesn't hurt to check in case they happen to land on a one-way or turn
restriction.
2019-02-01 22:51:04 +00:00
SilentSpike 183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00