Commit Graph

107 Commits

Author SHA1 Message Date
Huon Wilson dd0be84da4 Add one-sided triangular markers to ways with sides (e.g. natural=cliff).
This generalizes the oneway arrow logic for adding SVG markers along a
line. Using that functionality, certain tags get arrows on their
right-hand side, indicating which side is "inside", e.g. the
right-side of a cliff is the lower side.

The list of tags considered to be sided (unless there's a
two_sided=yes tag) is:

- natural=cliff
- natural=coastline
- barrier=retaining_wall
- barrier=kerb
- barrier=guard_rail
- barrier=city_wall
- man_made=embankment

The triangles attempt to be reminiscent of the triangles used for
rendering cliffs on OSM (and elsewhere). The different tags get
different renderings (e.g. colors that match the main way, and
different spacings). In addition, natural=coastline is special-cased
to have blue markers (despite having a green way), to emphasise that
the "inside" of a coastline is the water.

Fixes https://github.com/openstreetmap/iD/issues/1475.
2018-11-28 01:45:50 +11:00
Huon Wilson f356c6ac49 test: add tests for adding oneway arrows to lines 2018-11-28 01:25:04 +11:00
Bryan Housel 3bc841e95b Adjust layer ordering to draw touch targets above data layers 2018-11-09 21:48:45 -05:00
Bryan Housel 3e03102731 Simplify unpaved tag class logic, add tests
(re: #5422)
2018-10-31 16:13:03 -04:00
Bryan Housel 5368aa1972 Update data layer tests to check for both shadow and stroke paths 2018-08-25 11:30:06 -04:00
Bryan Housel 0f07393fb3 Fix data file tests (in both phantom and real browsers) 2018-08-23 11:11:14 -04:00
Bryan Housel 575c98ab28 Accept both file and vector tile url templates from settings screen 2018-08-21 01:25:24 -04:00
Bryan Housel 4b446e9e78 WIP merge 'gpx' and 'mvt' layers into single 'data' layer 2018-08-17 13:03:07 -04:00
Bryan Housel 4c9ef45448 Merge pull request #5149 from vershwal/mvt_test
Some mvt tests.
2018-07-17 01:15:28 -04:00
Bryan Housel 73d0f30453 Merge branch 'notes' 2018-07-16 16:59:35 -04:00
vershwal 213fa3706d Created new file for pbf test in test/data. 2018-07-16 22:10:59 +05:30
vershwal 0b32f4c4ee Some mvt tests. 2018-07-15 22:20:43 +05:30
Bryan Housel 4fda478f57 Merge branch 'check' of https://github.com/vershwal/iD into vershwal-check 2018-07-09 09:32:15 -04:00
Bryan Housel de12396654 Fix projection so the map is where the point is
Also remove gj redundancy
2018-07-08 00:50:26 -04:00
vershwal 73ac628880 gpx tests. 2018-07-04 19:56:51 +05:30
Bryan Housel 9517635d4d Merge branch 'master' into notes 2018-06-29 21:54:24 -04:00
Bryan Housel 76d21c8293 stub test/spec/svg/gpx.js 2018-06-29 02:23:42 -04:00
Thomas Hervey 1ed915e69c added: map data notes toggle 2018-06-19 10:31:26 -04:00
vershwal 7919f59a53 Fixed test file layers.js. 2018-06-18 01:30:21 +05:30
Bryan Housel d24790f17a Merge branch 'master' into jharpster-streetside 2018-06-11 23:51:23 -04:00
Bryan Housel 470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Shawna Paradee 2b50d36f65 adding points for streetside images 2018-03-20 13:05:33 -07:00
Bryan Housel de488e252f Draw covered/underground lines beneath areas
(closes #4718)
2018-01-22 15:06:58 -05:00
Bryan Housel 2e2b037e36 Move a bunch of commonly used vector and projection math functions into geo
- geoVecAdd
- geoVecSubtract
- geoVecScale
- geoZoomToScale
- geoScaleToZoom
2017-12-18 15:05:42 -05:00
Bryan Housel 6644c9db6b Fix context.js and vertices.js tests 2017-12-15 18:17:12 -05:00
Bryan Housel 89d8d37576 Drawing all the correct vertices now where I want them, simplify classes
Some highlights
- `getSiblingAndChildVertices` are expensive, so they're saved and called less frequently
- draw touch targets for all the visible vertices
- remove redundant css classes and `setClass` function
2017-12-15 17:28:20 -05:00
Bryan Housel b9e48d1682 WIP: Move layer-hit to layer-points with explict sublayers, update tests
This is more work to further isolate the layers that entities draw to.
It makes it easier to debug what is going on, and can eventually lead to
deferred drawing, if each draw function is in its own place and not dependant
on anything else.

I've started to replace the vertex-hover with an explicit layer for touch
targets.

Also had to change a lot of the svg tests, which are really brittle.
Things would happen like - the surface would be created, it would kick of a
deferred redraw, which would notice that the zoom was 0 and call
editOff, which would remove the osm layers that were just created and
that the tests were trying to draw to. These tests need proper zoom and
projection otherwise nothing works.
2017-12-14 17:38:43 -05:00
Bryan Housel bfaf17538e Move text to single group with subgroups for halo,label,debug 2017-12-14 12:32:28 -05:00
Bryan Housel a5bbc21728 Remove unnecessary zoom parameter 2017-12-11 17:34:01 -05:00
Bryan Housel 00b30e29f0 WIP: Add OpenStreetCam support
todo: Need to figure out API issue with bbox, then imageviewer
2017-11-02 22:04:47 -04:00
Bryan Housel c7044bec3a Better mock for select mode, fixes false test failures 2017-08-09 11:09:08 -04:00
Bryan Housel 89013627fb Don't consider untagged multipolygons as old multipolygons
Also add a lot of old-style multipolygon tests
(closes #4009)
2017-05-04 12:16:04 -04:00
Bryan Housel d07d20cba7 Drop custom "classed" chai assertation and just use d3 2017-04-24 10:27:29 -04:00
Bryan Housel 4903d495b7 Draw selected items last, so halos are more visible
(see #2914)
2017-03-21 02:17:04 -04:00
Bryan Housel f800e5afbc Remove unnecessary window parameter to Context 2016-11-10 15:19:03 -05:00
Bryan Housel 87950fd472 Fix lib export, flatten names in tests and docs 2016-10-04 21:56:09 -04:00
Bryan Housel bb942aa9b6 Add only a single defs element to surface 2016-09-09 23:20:48 -04:00
Bryan Housel 273407da3d Fix svg layer selections, fix and add tests.. 2016-09-09 14:19:13 -04:00
Tom MacWright 20962074ba Fix vertices areas midlines 2016-09-06 10:58:07 -04:00
Bryan Housel a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Bryan Housel 7ca6d06254 Replace iD global with iD.Context() module (#3254) 2016-07-19 10:15:32 -04:00
Bryan Housel 5f496f2020 Cleanup test html, alphabetize, make sure all tests run 2016-07-14 12:59:47 -04:00
Kushan Joshi 1db442b9e8 Remove linting errors fromspec/svg 2016-06-15 18:26:11 +05:30
Bryan Housel e22bd1eceb Pass projection to iD.svg.Layers in tests 2016-06-10 13:06:28 -04:00
Bryan Housel 45e4e730a8 iD.svg.Surface -> iD.svg.Layers 2016-02-24 15:41:22 -05:00
Bryan Housel f37a809001 Make point draw function more consistent with other draw functions 2016-02-22 16:52:49 -05:00
Bryan Housel 8a9accfe8d Replace generic "tag-ephemeral" with specific "tag-status tag-status-xxx" 2015-12-01 15:31:25 -05:00
Bryan Housel b4628298d9 Differentiate between paved/unpaved roads (closes #2564)
Now `iD.svg.TagClasses` will add the class 'tag-unpaved' for unpaved roads.
2015-11-25 15:28:37 -05:00
Bryan Housel 3853c0d993 Fix the rest of the icons (leave walkthrough graphics alone for now) 2015-11-02 20:46:08 -05:00