Commit Graph

4880 Commits

Author SHA1 Message Date
Deeptanshu Sankhwar
e48aa3c2c4 Ensure correct this context for addMembership function to call the blur method correctly. Fixes #10555 (#10560)
* Pass the  reference explicitly to the  function to ensure the correct context is available.

* refactor: handle blur() in a closure to separate UI logic from addMembership

* spacing

* Fixed typo

---------

Co-authored-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
2024-11-30 22:43:54 -08:00
Dimitar
b3579d6c7c Preserve 'opening_hours' when matching with NSI
re: https://github.com/osmlab/name-suggestion-index/issues/10170#issuecomment-2508129832
re: b1f2c3f4d0

These are tags that we want to leave alone (i.e. not offer an "upgrade")
if they already have a value. We assume the mapper knows best.
2024-11-29 20:28:31 +02:00
Martin Raifer
93c8e3dd7d Merge remote-tracking branch 'k-yle/kh/mismatched-geom-error' into develop 2024-11-13 15:27:30 +01:00
Minh Nguyễn
6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Martin Raifer
5024feafe8 Fix flickering when switching between background imagery layers
and make switching backgrounds snappier
2024-10-21 18:31:07 +02:00
Martin Raifer
b4e55c2027 backport fixes from PR#10452 missing in merge e839b6307 2024-10-16 13:49:03 +02:00
Kyle Hensel
108893c624 enable --no-isolate to speed up unit tests
This required fixing deferred code that was running after the unit test had unmounted
2024-10-16 13:42:51 +02:00
Martin Raifer
e839b63079 Merge branch 'kh/vitest' into develop 2024-10-16 13:37:20 +02:00
Minh Nguyễn
37939c869a wmf-sitematrix v0.2.0 (#10489) 2024-10-11 12:53:08 +02:00
Kyle Hensel
c3c0e23ba8 fix unsolvable validator error for presets with locationSet 2024-09-09 20:57:26 +10:00
Kyle Hensel
7bc94d6f4b migrate unit tests to vitest 2024-09-03 19:23:21 +10:00
Kyle Hensel
7afecd39ec minor tweaks to make some tests pass 2024-09-03 19:23:21 +10:00
Kyle Hensel
90c4241723 fix dependency cycle caused by utilDisplayLabel importing presetManager 2024-08-24 11:34:46 +10:00
Martin Raifer
34bb143561 fix undefined translation string, see #10417 2024-08-22 13:54:23 +02:00
Martin Raifer
31bef9f064 fix calculation of non-node feature extents, fixes #10417 2024-08-22 13:52:24 +02:00
Martin Raifer
942f0a0648 fix note not loading when both id and map hash parameters are set 2024-08-21 11:15:43 +02:00
Martin Raifer
b0e47ca93c make sure viewer is visible before selecting photo
otherwise the newly selected photo is not displayed correctly when switching between regular and 360 photos

see #10362
2024-08-08 14:55:46 +02:00
Martin Raifer
9e239df569 fix intermittent issues with Bing Streetside API
sometimes the API returns data in a format not matching the documented format (see https://learn.microsoft.com/en-us/bingmaps/articles/getting-streetside-tiles-from-imagery-metadata).

see https://github.com/openstreetmap/iD/issues/10341#issuecomment-2275724738

closes #10341
2024-08-08 14:44:50 +02:00
Martin Raifer
43dab66b3a only rotate selected image's cone to viewer yaw, fixes #10390 2024-08-08 13:58:58 +02:00
Martin Raifer
f570d9bfa3 increase max zoom for panellum viewer, closes #10391 2024-08-08 13:07:35 +02:00
Martin Raifer
a8e438c58d sort markers by date (newest on top) 2024-08-07 10:00:59 +02:00
Martin Raifer
136308821a make sure the active image is rendered above other photo markers 2024-08-07 09:54:54 +02:00
Martin Raifer
7e111944db try to equally space to be rendered markers in mid zoom levels
closes #10378
2024-08-07 09:30:46 +02:00
Mattia Pezzotti
9f643aaae1 hide panoramax markers in low zoom overview (#10386)
fixes #10377
2024-08-07 09:08:54 +02:00
Mattia Pezzotti
309735c25e Fix panoramax blur when switching imagery (#10385)
fixes #10362
2024-08-07 09:03:20 +02:00
Mattia Pezzotti
ebb68d610e Fix panoramax non existing inaccurate sequence (#10375)
fixes #10365
2024-08-03 21:08:57 +02:00
Mattia Pezzotti
dd7de08a35 Fix panoramax highlight selected sequence (#10374)
closes #10366
2024-08-03 21:03:58 +02:00
Mattia Pezzotti
e9095eb1bf Fix panoramax errors when image not in cache (#10376) 2024-08-03 20:45:38 +02:00
Martin Raifer
945fea1dc0 allow to enter strings with quote marks in raw tag editor's text mode (#10371)
and use fully quoted strings for cases which have characters that need to be encoded

old: tag=foo\"bar\" -> new: tag=foo"bar" or tag="foo\"bar\""
old: tag=foo\nbar   -> new: tag="foo\nbar"

falls back to raw tag values if a quoted string cannot be parsed
2024-08-01 15:19:33 +02:00
Martin Raifer
0ea3afa9f7 make sure map is not panned on arrow key input on 360° photo viewer
if the pannellum viewer is active, the arrow keys should rotate the view, and not also pan the map.

fixes #10360
2024-07-31 18:09:06 +02:00
Martin Raifer
e89121b550 fix vegbilder overlay from being overwritten by panoramax layer 2024-07-31 17:53:33 +02:00
Martin Raifer
b4eaeb3088 lint: remove unused code, code style and early update cached username 2024-07-29 16:29:39 +02:00
Martin Raifer
4646b67bac drop (for now) unused ui code 2024-07-29 16:22:46 +02:00
Martin Raifer
f25e94c71b update username filter on input change; fix multiple names/ids
in panoramax a username can resolve to multiple ids (when the same name is used on multiple servers).
further, the username filter input field can contain more than one username
2024-07-29 16:15:34 +02:00
Martin Raifer
608251a6ab update photos immediately when filters change 2024-07-29 15:47:24 +02:00
Martin Raifer
df3b5a4440 make "captured by …" translatable; single line if possible 2024-07-29 15:36:59 +02:00
Martin Raifer
b492627689 switch link to panoramax.xyz viewer 2024-07-29 15:36:26 +02:00
Martin Raifer
9407f309a7 Merge branch 'develop' into panoramax 2024-07-29 15:13:38 +02:00
Martin Raifer
e66cab06eb update all relation parents of an entity, fixes #10342
this had regressed in 5f1e405 – if an entity had two or more parent relations, the loop would abort after the first parent relation because `memo[entity.id]` would be set to true in the first parent iteration. what we want is to only abort if the same `relation` is seen again (in a r123 [-> …] -> r123 cirular relationship)
2024-07-25 18:13:27 +02:00
Martin Raifer
689d5f70a4 lint trailing spaces 2024-07-24 15:14:13 +02:00
Dimitar
42ea2b9dee Added railway=ventilation_shaft as area key (#10278)
fixes https://github.com/openstreetmap/id-tagging-schema/issues/1263
2024-07-22 15:28:28 +02:00
Waldir Pimenta
95ce7de78b Add waterway=flowline to waterway tags representing directional water flows (#10283) 2024-07-17 10:11:22 +02:00
Martin Raifer
984f25adbb Merge pull request #10046 from laigyu/add-button-to-mapillary
Add a button in the mapillary image photo viewer to "add the current image id as field to feature"
2024-07-16 22:14:21 +02:00
Martin Raifer
d13c202ac0 update "add mapillary tag" button state when tags of the feature change
addresses https://github.com/openstreetmap/iD/pull/10046#pullrequestreview-2176313208
2024-07-16 22:10:08 +02:00
Tobias
b0235f34d1 Improve/fix type definitions (#10324)
Co-authored-by: Kyℓe Hensel <k-yle@users.noreply.github.com>
2024-07-16 17:14:01 +02:00
Martin Raifer
da9aebbf68 Merge branch 'fix-localized-field-hidden' into develop 2024-07-16 17:08:08 +02:00
Martin Raifer
42f274f73f move reused regex to exported constant 2024-07-16 17:04:49 +02:00
Martin Raifer
175eea340b Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/mapbox/vector-tile-2.0.2' into develop 2024-07-16 16:53:25 +02:00
Sam Ho
43c65bf994 Fix localized field hidden despite nonempty subkeys (Closes#10323) 2024-07-16 12:38:06 +01:00
mattiapezzotti
b0d9a2c7ad fixing the mess 2024-07-14 10:13:16 +02:00