CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,794 Commits 2 Branches 0 Tags
8cc9ca6aa6f6f3d1a95500a70feef6fbeeba8167
Commit Graph

1457 Commits

Author SHA1 Message Date
Bryan Housel
392a242c02 Upgrade to eslint v6.0.0 
(closes #6567)
 2019-06-29 11:35:57 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan
14c0809426 Fix issue where cuisine -> diet upgrades could overwrite existing values (close #6462) 2019-05-31 08:25:29 -04:00
Quincy Morgan
94a47f05de Add tests for the indoor, piste, and aerialway map feature categories 2019-05-24 11:02:45 -04:00
Quincy Morgan
43cd46f046 Prevent Chrome autofill of recent values in the Allowed Access inputs (close #6414) 2019-05-24 09:30:06 -04:00
Quincy Morgan
0dfd0612b1 For ice rinks, prefer the "sport" values "ice_hockey" and "ice_skating" instead of "hockey" and "skating" since that latter are ambiguous 
Don't remove other values when upgrading a tag value within a semicolon-delimited list
 2019-05-23 15:39:15 -04:00
Quincy Morgan
2232d7dadf Fix code tests 2019-05-22 11:59:48 -04:00
Quincy Morgan
6260cdbb8f Fix several lint warnings 2019-05-22 10:48:39 -04:00
Bryan Housel
e1331016d1 Merge pull request #6386 from openstreetmap/configurable-squareness 
Allow user to adjust the threshold for the unsquare building warning
 2019-05-20 21:04:30 -04:00
Bryan Housel
2f0e0dffdb Merge pull request #6389 from openstreetmap/wikidata-style 
Support special styling for Wikidata-tagged features
 2019-05-20 18:05:29 -04:00
Bryan Housel
69a25fd6aa Move locking code from input and localized up to uiField 
Also adjust styles some more for wikidata tagged items
 2019-05-20 17:50:50 -04:00
Quincy Morgan
39784cdd1f Merge in master 2019-05-20 14:38:52 -04:00
Bryan Housel
1c97e29b5d No idea why this test keeps failing.. 2019-05-19 22:55:41 -04:00
Bryan Housel
e6dde01264 What will make you happy, mocha? 2019-05-19 21:51:33 -04:00
Bryan Housel
d68c49e66d Async tests running on dodgy Travis containers are not my friends 
(closes #6391)

Default timeout of 2000 regularly exceeded, causing spurious test failures.
Even a random garbage collection pause can take more than 2 seconds.
 2019-05-19 21:35:16 -04:00
Bryan Housel
344aec206c Support special styling for wikidata-tagged features 2019-05-18 23:57:23 -04:00
Bryan Housel
511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Quincy Morgan
e697bdbeb1 Flag disconnected ferry routes 
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
 2019-05-17 00:15:53 -04:00
Bryan Housel
86c6805cf7 Optionally include ids members of modified relations in extantIDs 
(closes #6273)
 2019-05-08 13:53:48 -04:00
Bryan Housel
b0d5f0dd48 Include multipolygon members in complete() 
(closes #3613)
 2019-05-08 00:49:33 -04:00
SilentSpike
5af7e86ef4 Fix findIssues test for dynamic issue messages 2019-05-07 20:43:27 +01:00
Bryan Housel
77801a3ecd Merge pull request #6284 from Bonkles/id-5869 
Improve validation for disconnected highways #5869
 2019-05-05 22:17:12 -04:00
Bryan Housel
ddc9d16b62 Merge pull request #6302 from openstreetmap/text-raw-tag-editor 
Text raw tag editor / Copy-paste tags
 2019-05-03 14:53:08 -04:00
Bryan Housel
7b4a9a43b0 Change utilTagDiff to return an object with details 2019-05-02 22:59:41 -04:00
Bryan Housel
ff1eea43a8 Remove Google Analytics, also actually export iD.utilDetect 2019-05-02 19:12:39 -04:00
Bryan Housel
ed9a436318 Move common tag diffing code from validators into utilTagDiff 2019-05-02 11:16:15 -04:00
Quincy Morgan
a180c794cb Merge branch 'master' into ignoring-issues 2019-05-01 20:13:49 -07:00
Bryan Housel
382e0a7dd6 Merge pull request #6270 from westnordost/patch-10 
inherit preset.removeTags from preset.addTags if not defined [Ready for Review]
 2019-05-01 19:15:24 -04:00
Benjamin Clark
ec01933d84 Disconnected highways will now be warning flagged only if unattached to existing highways. 2019-05-01 17:42:23 -04:00
Quincy Morgan
56544303ca Merge branch 'master' into ignoring-issues 2019-05-01 11:58:39 -07:00
Bryan Housel
37557a7c98 Defer processing clicks in behaviorSelect 
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
 2019-05-01 14:47:29 -04:00
Tobias Zwick
446dc1097d Merge branch 'master' into patch-10 
# Conflicts:
#	data/presets/presets/highway/crossing/unmarked-raised.json
#	data/presets/presets/highway/crossing/unmarked.json
 2019-04-30 22:20:05 +02:00
Tobias Zwick
a1b89332bb add test 2019-04-30 22:15:34 +02:00
Quincy Morgan
26f1e29072 Merge branch 'master' into ignoring-issues 
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
 2019-04-30 13:05:07 -07:00
Bryan Housel
0a4e2c03a3 Extend timeouts on slow async mapillary tests 
Trying to avoid false test failures.  Default timeout is 2sec, and we can't
be sure slow async tests will finish in that time esp. in a CI environment
 2019-04-30 09:59:51 -04:00
Bryan Housel
a72865e4d8 Treat anything with a from/via/to like a restriction 
(closes #6221)

Applies to actions like splitting, connecting, extracting a via node, etc
 2019-04-29 21:58:10 -04:00
Bryan Housel
2b46440429 Add Relation#hasFromViaTo method and tests 2019-04-29 21:39:40 -04:00
Bryan Housel
bd2490a965 Reverse internal left/right/forward/backward keyparts 
(closes #6235)

Previously only trailing keyparts would reverse:
 `cycleway:left` ⟺  `cycleway:right`
Now it can do internal keyparts too:
 `cycleway:left:surface` ⟺  `cycleway:right:surface`
 2019-04-29 21:13:18 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5 
d3 v5
 2019-04-29 15:46:08 -04:00
Bryan Housel
e981cd5dd5 Switch mapillary and openstreetcam tests to work async 
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
 2019-04-29 15:31:08 -04:00
Bryan Housel
af31b84b1d Keep track of whether requests have been processed 
This lets us call `respond` multiple times, which is useful for the
tests which fetch data in pages.
 2019-04-29 13:03:01 -04:00
Bryan Housel
452eb8b43a Bump timeouts on streetlevel loadimage-type tests 
This isn't perfect but might avoid spurious test failures.
 2019-04-27 17:41:58 -04:00
Bryan Housel
d0452e6be4 Convert fakeServer tests to use fakeFetch 
- Many text expects are now wrapped in setTimeout, as the fetch
  promises settle async now.
- This makes the tests somewhat brittle, and we should maybe consider
  reworking some of them. For example it is very hard to perform
  a test like `expect(spy).to.have.not.been.called` in an async way.
  (We could instead inspect the fakeServer requests() to know this.)
- Also includes some trickery for osm.js, which uses d3-xml (fetch)
  now for unauthenticated calls and osmauth (xhr) for authenticated calls
 2019-04-26 22:29:48 -04:00
Bryan Housel
552ea46c43 Wrap the fake-fetch methods with sinon.fakeServer-like interface 
This mimics `respondWith` and `respond` to keep the tests mostly
similar between `FakeFetch` and `sinon.fakeServer`

Major difference is that all the fakeServer tests which were sync
are now async and this is probably unavoidable.
 2019-04-26 22:25:57 -04:00
Bryan Housel
3e363fed8b Make sure to return a new Response each time, not the same one 
You can only consume a response once - thereafter the response
body becomes "locked" and will throw an error if you try.
https://stackoverflow.com/questions/53511974/javascript-fetch-failed-to-execute-json-on-response-body-stream-is-locked
 2019-04-25 19:22:11 -04:00
Bryan Housel
6f31062d32 Add support for sinon-stubbing fetch API to spec_helpers 2019-04-25 14:13:08 -04:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
aa91c2d768 Move old multipolygon warning into Outdated Tags rule (close #6218) 2019-04-24 15:46:50 -07:00
Quincy Morgan
13f7e536dc Move highway=road validation warning to the missing_tag validation rule (re: #6218) 2019-04-24 15:19:57 -07:00