Commit Graph

150 Commits

Author SHA1 Message Date
Quincy Morgan
5011039087 Clarify some variable names in osmEntity.deprecatedTags and add more code tests 2020-01-09 09:49:31 -05:00
Quincy Morgan
09ad21a26f Improve "add a bridge/tunnel" fixes by basing the structure length on the crossed feature type, not a fixed constant (re: #7202) 2020-01-08 12:03:30 -05:00
Quincy Morgan
1049c338c6 Add waterway=tidal_channel preset (close #7232) 2020-01-07 10:14:43 -05:00
Quincy Morgan
31941e9389 Fix JavaScript error that could cause validation warnings to appear unexpectedly (close #7166)
Add code test to account for deprecated tags with no replacement
2019-12-31 12:03:57 -05:00
Quincy Morgan
93ff34dc39 Add preset for waterway=fish_pass 2019-12-17 13:22:05 -05:00
Quincy Morgan
81b561fffc Don't close unclosed multipolygon parts with fewer than three nodes when generating geojson
Update multipolygon geojson code tests
2019-11-22 17:01:51 -05:00
Quincy Morgan
d0c5add378 Update some variable names to not be misleading 2019-11-22 14:43:16 -05:00
Quincy Morgan
4b9b0860bf Fix incomplete rendering of unclosed multipolygon rings (close #2945) 2019-11-22 13:09:46 -05:00
Quincy Morgan
1f5cce9bdd Don't treat source_ref subtags as descriptive tags 2019-11-18 15:49:32 -05:00
Quincy Morgan
b2611a941c Don't treat various source tags as descriptive tags 2019-11-18 15:43:46 -05:00
Quincy Morgan
3d9bcc8234 Add directional arrows to waterway=weir rendered as lines (close #6615) 2019-07-03 15:46:23 -04:00
Bryan Housel
2f0e0dffdb Merge pull request #6389 from openstreetmap/wikidata-style
Support special styling for Wikidata-tagged features
2019-05-20 18:05:29 -04:00
Quincy Morgan
e599488121 Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374)
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Bryan Housel
344aec206c Support special styling for wikidata-tagged features 2019-05-18 23:57:23 -04:00
Quincy Morgan
936822849a Don't consider "highway=raceway" as routable (#6385)
Update the icon for the raceway preset
2019-05-18 11:49:25 -04:00
Quincy Morgan
409968dfc2 Add index of tags that positively identify points or vertices, derived from the presets
Delete nodes that can only be vertices when deleting parent ways (close #6230)
Allow snapping ways to nodes that cannot be positively identified as vertex-only
2019-05-14 12:09:44 -04:00
Bryan Housel
2b46440429 Add Relation#hasFromViaTo method and tests 2019-04-29 21:39:40 -04:00
Quincy Morgan
228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan
ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Quincy Morgan
17f2c5c0f4 Add Zip Line preset 2019-04-05 09:40:35 -07:00
Bryan Housel
765d765477 Pick a fake loc value where equality tests actually work 2019-04-03 17:25:10 -04:00
Bryan Housel
167824a530 Make sure all nodes have an actual loc property
- This is to make difference comparisons easier
- The only nodes that didn't have a `loc` were fake nodes we made for testing
- So this commit also fixes the `osmIntersection` code and tests.
2019-04-03 16:20:45 -04:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Bryan Housel
3896b2282f Remove lodash isNaN, isNumber, isString, bind, uniqBy
(re: 6087)
2019-03-27 23:11:45 -04:00
Quincy Morgan
748c9c9598 Filter out deprecated tag values from combobox suggestions (close #6084) 2019-03-27 17:15:10 -04:00
Bryan Housel
5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
1ce4f0ad6a Remove lodash without
(re: #6087)
2019-03-25 21:56:54 -04:00
Bryan Housel
5280d07bad Remove lodash reject (re: #6087) 2019-03-23 12:51:13 -04:00
Bryan Housel
76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel
7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel
7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Bryan Housel
c7e375cbd7 Preserve directionality of sided way when joining to non-sided ways
(closes #6033)
2019-03-21 22:19:05 -04:00
Quincy Morgan
0781b70f38 Add drag-and-drop reordering of relation members (close #2283) 2019-03-15 12:22:24 -04:00
Quincy Morgan
8ac6ede028 Add highway=footway when setting pier, platform, and foot racing track presets
Add highway=bridleway when setting horse racetrack preset
Style racetracks with highway tag with white/yellow pattern
2019-03-12 14:01:15 -04:00
Quincy Morgan
93df5d42d9 Flag and upgrade deprecated tags in a semicolon-delimited tag value (close #6038) 2019-03-11 10:22:28 -04:00
Bryan Housel
3f8911c149 Merge pull request #5999 from openstreetmap/squarish
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
b47ab4ac50 Change orthogonalize to support degenerate shapes, non-closed ways
Also adds a handful of useful vector math functions to geo module
2019-02-28 22:52:45 -05:00
Quincy Morgan
a4e0bcb29c Make misplaced multipolygon tags check more consistent 2019-02-26 08:53:00 -05:00
Quincy Morgan
12b1af7002 Don't say tags imply area for tags that iD doesn't have a preset for (close #5933) 2019-02-25 12:42:39 -05:00
Quincy Morgan
bfefea422b Use iD's area tag logic for the tag_suggests_area validation 2019-02-05 13:55:59 -05:00
Quincy Morgan
8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
Quincy Morgan
c39c584b52 Fix false positive for deprecated tag validation 2019-02-04 18:36:42 -05:00
SilentSpike
781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
SilentSpike
ddf44377e8 Fix errors without templates not working 2019-02-04 18:12:21 +00:00