Commit Graph

1546 Commits

Author SHA1 Message Date
Bryan Housel f4b9abe474 Merge pull request #5867 from SilentSpike/iOSM-comments
Add comments to ImproveOSM issues
2019-02-07 09:46:57 -05:00
Quincy Morgan d3bbdfab7e Merge branch 'master' into validation 2019-02-07 07:01:36 -05:00
Quincy Morgan a702281fb6 Add "remove" tooltip to raw tag editor remove button 2019-02-06 15:56:12 -05:00
Quincy Morgan 7036523bfc Merge branch 'master' into validation 2019-02-06 15:37:03 -05:00
Bryan Housel e0a41656a1 Allow value to be entered before key in raw tag editor
(closes #5872)

This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
2019-02-06 15:03:03 -05:00
Quincy Morgan 703d560a94 Merge branch 'master' into validation 2019-02-06 12:49:59 -05:00
Bryan Housel 640730d38b Change focus to existing key instead of suffixing it with _1
(re: #3625, re: #2896)
2019-02-06 10:29:09 -05:00
Quincy Morgan 21967d2654 Show the area preset browser rather than editor upon selecting multipolygon from the relation preset browser 2019-02-06 09:48:45 -05:00
Quincy Morgan 0aa3ce2cee Fix issue with Issues section appearance if the sidebar was loaded with the section closed 2019-02-05 16:57:34 -05:00
SilentSpike a566d58f81 Fix error on ImproveOSM issues with no comments 2019-02-05 21:48:06 +00:00
Quincy Morgan 2aa285c378 Merge branch 'master' into validation 2019-02-05 16:38:02 -05:00
Bryan Housel b87ae4e98b Exclude existing keys from auto-completion in raw tag editor
(closes #3625)
2019-02-05 16:14:18 -05:00
SilentSpike 78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
Quincy Morgan 1055c239ed Merge branch 'master' into validation 2019-02-05 16:03:19 -05:00
SilentSpike c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike 5fc87fb0a4 Pacify eslint
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
SilentSpike f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike 2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel 51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing
(closes #5857)
2019-02-05 14:52:13 -05:00
SilentSpike 448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Quincy Morgan 8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
Bryan Housel e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
Quincy Morgan a23954d886 Fix issue where preset reset buttons would not initially work 2019-02-05 08:24:34 -05:00
Quincy Morgan 7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
SilentSpike 781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
Quincy Morgan ac7dba082f Merge branch 'master' into validation 2019-02-04 13:35:21 -05:00
Quincy Morgan bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Bryan Housel 7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
SilentSpike d7147996ed Merge remote-tracking branch 'upstream/master' into unify 2019-02-04 17:17:17 +00:00
Quincy Morgan b3d49f0978 Merge branch 'master' into validation 2019-02-04 12:10:45 -05:00
Quincy Morgan 190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
SilentSpike 40af841d53 Fix sidebar preview for new generic errors 2019-02-04 16:54:07 +00:00
SilentSpike 3ed13e9a4a Convert KeepRight to use generic error type 2019-02-04 16:54:07 +00:00
SilentSpike 20ed8b50c9 Add generic QA error
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.

Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
Quincy Morgan 977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan 2677a88df4 Zoom to ways and relations upon clicking on their issues in the issues pane 2019-02-04 10:27:35 -05:00
Andreas Haessler 82ea58d943 Add default value to number field 2019-02-04 15:59:08 +01:00
Quincy Morgan 6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan 8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
SilentSpike 9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
SilentSpike 183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00
SilentSpike ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike 54e02ec28d Introduce new container icon for errors
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.

I learned quite a bit about SVGs and using them in HTML while
implementing this 😝Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
SilentSpike 9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike ac4cec1429 Add sidebar preview for ImproveOSM errors 2019-02-01 22:50:57 +00:00
SilentSpike 214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike 9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike 23a4d71410 Handle turn restriction errors 2019-02-01 22:50:55 +00:00