6cd015901b
add man_made=beacon preset
2019-04-28 22:00:18 +02:00
77a6174d36
add missing ","
2019-04-28 21:42:27 +02:00
98827f6017
Add man_made=dyke preset
2019-04-28 21:41:44 +02:00
54612a168e
Add shop=general for general store
2019-04-28 18:56:07 +02:00
d3df05b9c2
Add preset for building=hangar
...
Make the hangar building preset have a lower matchScore so that first the aeroway=hangar is found
2019-04-28 18:43:56 +02:00
b5e87cadfb
Deprecate amenity/leisure=club/social_club
...
See https://wiki.openstreetmap.org/wiki/Key%3Aclub , club is documented as a top-level tag
2019-04-28 18:10:12 +02:00
5a17379c9c
Deprecate amenity=dancing_school
...
Also deprecated in the wiki and a replacement is available, see https://wiki.openstreetmap.org/wiki/Tag%3Aamenity%3Ddancing_school
2019-04-28 17:52:51 +02:00
ff4043ae58
Add presets for bicycle parkings...
...
... that are not essentially just a type of bicycle stands
2019-04-28 17:47:27 +02:00
20d75a5821
Deprecate lawyer=notary (re: #6248 )
2019-04-27 17:31:29 -07:00
061f61e7dd
Add derived data for j-bar preset
2019-04-27 17:07:57 -07:00
c812d11c03
Deprecate "todo" and "TODO" tags in favor of "fixme" (re: #6214 )
2019-04-27 17:07:39 -07:00
452eb8b43a
Bump timeouts on streetlevel loadimage-type tests
...
This isn't perfect but might avoid spurious test failures.
2019-04-27 17:41:58 -04:00
c9c5284996
Merge pull request #6246 from westnordost/patch-2
...
Add aerialway=j-bar to presets
2019-04-27 14:22:41 -04:00
bdb5add982
Add aerialway=j-bar to presets
2019-04-27 15:36:14 +02:00
d0452e6be4
Convert fakeServer tests to use fakeFetch
...
- Many text expects are now wrapped in setTimeout, as the fetch
promises settle async now.
- This makes the tests somewhat brittle, and we should maybe consider
reworking some of them. For example it is very hard to perform
a test like `expect(spy).to.have.not.been.called` in an async way.
(We could instead inspect the fakeServer requests() to know this.)
- Also includes some trickery for osm.js, which uses d3-xml (fetch)
now for unauthenticated calls and osmauth (xhr) for authenticated calls
2019-04-26 22:29:48 -04:00
552ea46c43
Wrap the fake-fetch methods with sinon.fakeServer-like interface
...
This mimics `respondWith` and `respond` to keep the tests mostly
similar between `FakeFetch` and `sinon.fakeServer`
Major difference is that all the fakeServer tests which were sync
are now async and this is probably unavoidable.
2019-04-26 22:25:57 -04:00
b48a7d1e1b
Workround for status errors thrown by d3-xml
...
Because the done callback is expecting something that has a `status` property,
(like an XHR would), we need to extract the status out of the error message.
d3-xml includes status in the error message, but we can't access the response itself.
2019-04-26 22:23:08 -04:00
1bb0a6a0bc
Add Fishing field to Pier preset
...
Deprecate shop=money_transfer
2019-04-26 16:40:53 -07:00
ea05d4e672
Unhighlight features when clicking issue quick fix ( close #6219 )
2019-04-26 16:26:19 -07:00
3fad3513c1
Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane
2019-04-26 16:05:10 -07:00
59bd6194e0
Add "autofix" for the unsquare building validation
2019-04-26 14:56:39 -07:00
239c622044
Don't tag redundant ignored warnings counts on changesets
2019-04-26 13:02:13 -07:00
228af9a000
Move areaKeys and setAreaKeys to modules/osm/tags
2019-04-26 12:53:05 -07:00
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
b99be67169
When calling an errback from a Promise.catch, pass err.message
2019-04-25 21:58:36 -04:00
3e363fed8b
Make sure to return a new Response each time, not the same one
...
You can only consume a response once - thereafter the response
body becomes "locked" and will throw an error if you try.
https://stackoverflow.com/questions/53511974/javascript-fetch-failed-to-execute-json-on-response-body-stream-is-locked
2019-04-25 19:22:11 -04:00
6f31062d32
Add support for sinon-stubbing fetch API to spec_helpers
2019-04-25 14:13:08 -04:00
7d29a98a14
Add subtype to some validation issues
2019-04-25 10:35:27 -07:00
f2ca5316b0
Add total ignored warnings count to changeset tags (re: #6123 )
2019-04-25 09:34:07 -07:00
36917ab644
Deprecate power=line + location=underground ( close #6206 )
2019-04-25 09:22:18 -07:00
68801468cc
Add One Way field to Gondola preset
2019-04-24 18:15:27 -07:00
6eeaf94076
Show members of selected relations even when their feature layer is otherwise hidden ( close #6220 )
2019-04-24 17:28:56 -07:00
0b14acd24a
Deprecate barrier=embankment ( close #6236 )
2019-04-24 17:07:29 -07:00
42de00e640
Add validation warning for "fixme" tags ( close #6214 )
2019-04-24 16:59:57 -07:00
05a6fd958f
Add more fields to landuse=construction
2019-04-24 16:15:18 -07:00
aa91c2d768
Move old multipolygon warning into Outdated Tags rule ( close #6218 )
2019-04-24 15:46:50 -07:00
6a9c7b97a8
Don't flag websites on residential buildings
2019-04-24 15:21:49 -07:00
13f7e536dc
Move highway=road validation warning to the missing_tag validation rule (re: #6218 )
2019-04-24 15:19:57 -07:00
b30c91828f
Don't flag buildings with lots of nodes or buildings connected to other buildings as unsquare (re: #6215 )
2019-04-24 14:52:41 -07:00
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
e6bc9d9e8f
Swap out d3-request, swap in d3-fetch
2019-04-24 16:25:25 -04:00
48b1ddc925
Rename fetch to fetchComboData to not conflict with fetch API
2019-04-24 16:24:36 -04:00
b6cd13508a
Add abortcontroller-polyfill to support abortable fetch calls
2019-04-24 16:24:13 -04:00
f72fd961cc
Update to d3 ~5.9.2
2019-04-24 10:52:28 -04:00
862eca9ddd
Update shortcut screen straighten text too
2019-04-24 01:58:19 -04:00
05949608aa
Support straightening of points
...
(closes #6217 )
- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
2019-04-24 01:55:43 -04:00
bc3353d386
Merge pull request #6234 from openstreetmap/unsquare-buildings-warning
...
Add validation warning for unsquare buildings
2019-04-23 16:16:26 -07:00
d1cd07e588
Add Name and Operator fields to the Car Wash preset ( close #6233 )
2019-04-23 15:56:36 -07:00
34fcd01f98
Add validation warning for unsquare buildings
2019-04-23 15:50:52 -07:00
a37ce90af7
Move "Fix All" from bottom of list to top
2019-04-23 17:42:14 -04:00
Tobias Zwick