Commit Graph

12493 Commits

Author SHA1 Message Date
J Guthrie ac29803b6f Fix eslint error 2019-04-08 16:38:10 +01:00
J Guthrie 4d24db597e Small refactor to improve efficiency 2019-04-08 16:28:01 +01:00
Jamie Guthrie a29da38230 Remove operationDisconnect test 2019-04-08 16:02:31 +01:00
Jamie Guthrie d3d0a560eb Remove excess whitespace 2019-04-08 16:01:08 +01:00
J Guthrie 57a0358061 Add test cases 2019-04-08 15:19:21 +01:00
Bryan Housel dcd2b4dfbe Update name-suggestion-index to v2.0.1 2019-04-08 09:43:00 -04:00
J Guthrie d7865ac4aa don't unclose way if it is part of a larger disconnect operation 2019-04-08 12:42:16 +01:00
J Guthrie 7edebb897f Only allow disconnect when selected ways relate to selected node 2019-04-08 12:41:05 +01:00
Bryan Housel 8d66289cba Run validation when switching fields, or when applying an issue fix 2019-04-07 23:10:20 -04:00
Quincy Morgan 3c515dcaaf Add or update icons for various presets 2019-04-07 16:42:25 -07:00
Quincy Morgan 8051ed5d82 Add Trailhead preset 2019-04-07 15:24:00 -07:00
Quincy Morgan c3653616e6 Make modals work better at small screen sizes
Flexbox the modal action buttons
Replace "col8" CSS class
2019-04-07 14:49:33 -07:00
Quincy Morgan 5e4e2ff7ee Fix an issue where stale warning counts would still appear in changeset tags if they had all been resolved (re: #6123) 2019-04-07 14:29:05 -07:00
Quincy Morgan eafd2cec3e Add a tooltip to the plus button in the "All relations" section (re: #3812) 2019-04-07 14:05:31 -07:00
Quincy Morgan 9d029a37a8 Delete newly-created untagged relations when deselecting them (close #3812) 2019-04-07 13:39:51 -07:00
Quincy Morgan 8815b878c5 Fix issue where selected way could not be disconnected if the connection point occurred more than once in the way (close #6149) 2019-04-07 12:47:20 -07:00
Quincy Morgan b0ba87c8fa Add terms to the Rail preset 2019-04-07 11:45:04 -07:00
Quincy Morgan 4ca7646896 Renamed Rail Under Construction to Railway Under Construction (since Rail has a more specific meaning) 2019-04-07 11:42:31 -07:00
Quincy Morgan 380a925c26 Add more terms for Underwear Store 2019-04-07 11:29:31 -07:00
Quincy Morgan 177b2df8d2 Add Underwear Store preset and deprecate shop=underwear and shop=lingerie (close #6152) 2019-04-07 11:26:58 -07:00
Quincy Morgan 11952c8f68 Don't flag traffic_calming=choker or chicane on line features (close #6153) 2019-04-07 10:28:17 -07:00
Quincy Morgan 9e91b606b9 Add Rail Under Construction preset (close #6151) 2019-04-07 10:20:34 -07:00
Bryan Housel e377270372 WIP: introduce validatedGraph, try on mode change not history change 2019-04-06 13:39:19 -04:00
Quincy Morgan b7b1ce3d7f Fix footway icon colors on Chrome 2019-04-06 08:36:08 -07:00
Quincy Morgan 2e693d2c03 Add derived taginfo data 2019-04-06 08:32:04 -07:00
Bryan Housel 1bcc0f613c WIP: fix caches, replace id() function with plain id property 2019-04-05 17:41:04 -04:00
Quincy Morgan 6dd9e9ce48 Add code tests for incompatible_source validation 2019-04-05 13:53:57 -07:00
Quincy Morgan d1399fd99b Merge pull request #6146 from jguthrie100/make_list_of_invalid_sources
Allow for multiple invalid sources
2019-04-05 13:40:13 -07:00
Quincy Morgan ebc14dd0df Deprecate craft=glass, shop=baby, and shop=baby_care 2019-04-05 12:30:30 -07:00
Quincy Morgan 251d27b5f0 Add various tag deprecations 2019-04-05 12:09:28 -07:00
J Guthrie 6e6ed7fad5 eslint fixes 2019-04-05 19:01:12 +01:00
J Guthrie 1328054b08 Allow for multiple invalid sources 2019-04-05 18:49:14 +01:00
Bryan Housel 78acd999c8 WIP: switch from validating everything to validating differences 2019-04-05 13:29:57 -04:00
Quincy Morgan 195c1376d6 Remove oneway tag from some aerialway presets where it would be highly uncommon 2019-04-05 09:59:49 -07:00
Quincy Morgan 3d9cd5b5bf Fix highway=unsurfaced replacement tags 2019-04-05 09:55:14 -07:00
Quincy Morgan 8e7b3e304a Deprecate aerialway=canopy 2019-04-05 09:47:53 -07:00
Quincy Morgan f735c8e511 Add One Way field to aerialway presets 2019-04-05 09:44:59 -07:00
Quincy Morgan 17f2c5c0f4 Add Zip Line preset 2019-04-05 09:40:35 -07:00
Bryan Housel af45dbce10 Trying to avoid one-off validations when history changes will trigger it 2019-04-05 11:37:02 -04:00
Quincy Morgan ae8f2c2ad3 Add Diplomatic Office, Embassy, Consulate, and Liaison Office presets (close #6144)
Deprecate amenity=embassy
2019-04-05 08:24:30 -07:00
Bryan Housel f17ebee402 Use Set, simplify util functions to collect entities with children 2019-04-05 11:05:04 -04:00
Bryan Housel 6508edf820 Avoid anonymous functions as validators
Givnig them names makes it easier to understand in the profiler
2019-04-05 09:50:22 -04:00
Bryan Housel 82a9375e0f Move coreValidator test to test/spec/core/validator.js 2019-04-05 09:34:53 -04:00
Bryan Housel 8b1c0551cc WIP: understand state held by the validator, avoid translations
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
Quincy Morgan 550a4df435 Prevent stale results when first searching presets 2019-04-04 18:24:05 -07:00
Quincy Morgan a054db6472 Fix issue where hover-highlighting wouldn't disappear upon removing a relation from a member or a member from a relation (close #5612) 2019-04-04 17:56:01 -07:00
Quincy Morgan 35c7cbd92b Ensure that undo/redo buttons look disabled when the map is not editable (close #6105) 2019-04-04 17:34:20 -07:00
Quincy Morgan 65e04acb2f Flag features that mention Google in the "source" tag (close #6135) 2019-04-04 08:32:03 -07:00
Bryan Housel d5e427289f Avoid delete/reinsert on the coreTree when not needed
(re: #6140)
2019-04-04 10:02:15 -04:00
Bryan Housel 68ed6da159 Merge branch 'master' into validation_and_change_perf 2019-04-04 09:30:30 -04:00